mirror of
https://github.com/electron/electron.git
synced 2026-01-09 15:38:08 -05:00
9e0a3c44dd
* chore: bump chromium in DEPS to 105.0.5179.0 * chore: update patches * 3758224: Reland^2 "[flags] Enable freezing of flags" https://chromium-review.googlesource.com/c/v8/v8/+/3758224 * chore: bump chromium in DEPS to 105.0.5181.0 * chore: update patches * chore: bump chromium in DEPS to 105.0.5183.0 * chore: bump chromium in DEPS to 105.0.5185.0 * chore: bump chromium in DEPS to 105.0.5187.0 * chore: update patches * 3723298: Pass RemoteFrame mojo channels through its creation messages. https://chromium-review.googlesource.com/c/chromium/src/+/3723298 * 3737382: [Code Heath] Replace base::{ListValue,DictionaryValue} in skia et al https://chromium-review.googlesource.com/c/chromium/src/+/3737382 * Pass RemoteFrame mojo channels through its creation messages. https://chromium-review.googlesource.com/c/chromium/src/+/3723298 * Changed PrintRenderFrame.PrintWithParams mojo interface to use callback. https://chromium-review.googlesource.com/c/chromium/src/+/3761203 * 3738183: [CSP] Add support for `DisableWasmEval` https://chromium-review.googlesource.com/c/chromium/src/+/3738183 * 3740498: Move LinuxUI from //ui/views/linux_ui to //ui/linux https://chromium-review.googlesource.com/c/chromium/src/+/3740498 * 3558277: Moves subsystem and semantics to enum class https://chromium-review.googlesource.com/c/chromium/src/+/3558277 * chore: fix broken steps-electron-gn-check * 3749583: [arm64] Fix undefined symbol linker error https://chromium-review.googlesource.com/c/v8/v8/+/3749583 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
31 lines
1.5 KiB
Diff
31 lines
1.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jeremy Rose <japthorp@slack-corp.com>
|
|
Date: Mon, 20 Jun 2022 14:53:37 -0700
|
|
Subject: disable freezing flags after init in node
|
|
|
|
This was introduced in
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/3687671.
|
|
|
|
When running node in the renderer, flags are updated after initialization, so
|
|
freezing the flags in Blink causes node initialization to fail.
|
|
|
|
If possible, it would be ideal to do this without a patch.
|
|
https://bugs.chromium.org/p/v8/issues/detail?id=12887 suggests that there may
|
|
at some point be an API to "unfreeze" the flags, or we may be able to refactor
|
|
node initialization to not update flags after V8 initialization.
|
|
|
|
diff --git a/content/renderer/render_process_impl.cc b/content/renderer/render_process_impl.cc
|
|
index 02b4f803369202a81f2d54f3b35aef04be13dfa2..04a8d29ba210313076eacf5074ed86402160c0c3 100644
|
|
--- a/content/renderer/render_process_impl.cc
|
|
+++ b/content/renderer/render_process_impl.cc
|
|
@@ -222,7 +222,8 @@ RenderProcessImpl::RenderProcessImpl()
|
|
SetV8FlagIfNotFeature(features::kWebAssemblyDynamicTiering,
|
|
"--no-wasm-dynamic-tiering");
|
|
|
|
- v8::V8::SetFlagsFromString("--freeze-flags-after-init");
|
|
+ // Freezing flags after init conflicts with node in the renderer.
|
|
+ v8::V8::SetFlagsFromString("--no-freeze-flags-after-init");
|
|
|
|
#if (BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)) && defined(ARCH_CPU_X86_64)
|
|
if (base::FeatureList::IsEnabled(features::kWebAssemblyTrapHandler)) {
|