mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
* ci: shrink src cache and fix Windows tar cleanup
- Exclude platform-specific toolchains (llvm-build, rust-toolchain) from
the src cache; all platforms now fetch them via fix-sync post-restore
- Exclude unused test data and benchmarks: blink/web_tests, jetstream,
speedometer, catapult/tracing/test_data, swiftshader/tests/regres
- Fix Windows restore leaving the tarball on disk after extraction
($src_cache was scoped to the previous PowerShell step)
- Bump src-cache key v1 -> v2
* ci: fetch llvm/rust toolchains in gn-check and clang-tidy
These workflows restore the src cache but don't run fix-sync. Now that
llvm-build and rust-toolchain are excluded from the cache, they need to
download them directly — gn gen read_file()s both, and clang-tidy runs
the binary from llvm-build.
* ci: fetch clang-tidy package explicitly
update.py's default 'clang' package doesn't include the clang-tidy
binary; it ships as a separate package.
* ci: preserve blink/web_tests/BUILD.gn when stripping test data
//BUILD.gn references //third_party/blink/web_tests:wpt_tests as a
target label, so the BUILD.gn must exist for gn gen. The data = [...]
entries it declares are runtime-only and not existence-checked at gen
time, so the actual test directories can still be removed.
* ci: compress src cache with zstd and drop gclient sync -vv
The src cache was an uncompressed tar (~16GB after exclusions). Switch
to zstd -T0 --long=30 for ~4x smaller transfer and multi-threaded
compression. Decompress on restore:
- Linux/macOS: zstd -d -c | tar -xf -
- Windows: zstd -d to an intermediate .tar, then the existing 7z
-snld20 extraction (preserves symlink handling)
All filename references updated .tar -> .tar.zst. -f added to the two
-o invocations so re-runs overwrite instead of failing.
Also drop -vv from gclient sync; default verbosity is sufficient.
* ci: keep .tar extension for src cache (zstd content inside)
The sas-sidecar that issues Azure SAS tokens validates filenames against
/^v[0-9]+-[a-z\-]+-[a-f0-9]+\.(tar|tgz)$/ and is not easily redeployed,
so keep the .tar extension and decode zstd on restore. Windows
decompresses to a distinct intermediate (src_cache.tar) so input and
output don't collide.
* ci: log NTFS 8.3/lastaccess/Defender state before Windows cache extract
Temporary diagnostics to see whether 8.3 short-name generation is the
cause of the ~20 min tar extraction.
* ci: revert src-cache exclusion additions
The new exclusions (web_tests contents, jetstream, speedometer,
catapult test_data, regres, llvm-build, rust-toolchain) caused siso/RBE
cache misses — even data-only deps are part of action input hashes.
Revert to the original exclusion list and drop the corresponding
toolchain-fetch plumbing. zstd compression, the Windows tar cleanup,
and the -vv removal remain.
* ci: drop win_toolchain from src cache; remove NTFS diagnostics
The Windows src cache includes 14.6GB of depot_tools/win_toolchain —
7.3GB of MSVC/SDK doubled because tar captures both the vs_files.ciopfs
backing store and the live ciopfs mount at vs_files/. Every Windows
cache consumer already re-fetches this via vs_toolchain.py update
--force (fix-sync for build/publish, inline for gn-check/clang-tidy),
so the cached copy is never used.
Diagnostics removed — CI confirmed 8dot3, last-access, and Defender are
all already off on the AKS Windows nodes.
* ci: unmount ciopfs vs_files before removing win_toolchain
vs_files is a live ciopfs mount during the win-targeted checkout; rm -rf
fails with EBUSY until it's unmounted.
* ci: skip win_toolchain download during checkout instead of removing after
fusermount isn't on the checkout container, so the ciopfs mount can't be
torn down before rm. Setting DEPOT_TOOLS_WIN_TOOLCHAIN=0 makes the
win_toolchain hook a no-op (vs_toolchain.py:525-527), so there's no
download and no mount. All Windows consumers re-fetch it post-restore
anyway. The rm -rf stays as a safety net.
* ci: also set ELECTRON_DEPOT_TOOLS_WIN_TOOLCHAIN=0 for checkout sync
build.yml sets ELECTRON_DEPOT_TOOLS_WIN_TOOLCHAIN=1 at the job level for
the Windows checkout, which makes e d inject DEPOT_TOOLS_WIN_TOOLCHAIN=1
and override the inline =0. Need both: the ELECTRON_ var stops e d from
overriding, the plain one stops vs_toolchain.py from defaulting to 1.
* ci: extract Windows src cache with piped tar instead of 7z
7z takes ~20 min to extract the ~1.1M-entry tar regardless of size —
~1ms per entry of header parsing and path handling, single-threaded,
well under the 75k IOPS / 1000 MBps the ephemeral disk can do. Switch
to the same zstd -d | tar -xf - pipe used on Linux/macOS (via Git Bash
tar). No intermediate src_cache.tar, download deleted after extract.
The -snld20 flag was working around 7z's own "dangerous symlink"
refusal; GNU tar extracts symlinks as-is so it shouldn't be needed.
* ci: keep depot_tools/win_toolchain scripts in src cache
The rm -rf removed get_toolchain_if_necessary.py (a depot_tools source
file), breaking vs_toolchain.py update --force on restore.
DEPOT_TOOLS_WIN_TOOLCHAIN=0 on the sync already prevents the vs_files
download, so the rm was only removing scripts.
* ci: split src cache into 4 parallel-extractable shards
Windows tar extraction is ~1ms/entry for ~1.2M entries (~20 min)
regardless of tool, well under the 75k IOPS / 1000 MBps the D16lds_v5
ephemeral disk can do. Tar is a sequential stream so the only way to
parallelize is to split at creation time.
Shards (balanced by entry count, ~220-360k each):
a: src/third_party/blink
b: src/third_party/{dawn,electron_node,tflite,devtools-frontend}
c: src/third_party (rest)
d: src (excluding third_party)
DEPSHASH is now the raw hash; shard files are
v2-src-cache-shard-{a..d}-${DEPSHASH}.tar (all pass the sas-sidecar
filename regex). sas-token is now a JSON keyed by shard letter. All
restore paths extract the four shards in parallel with per-PID wait so
a failed shard aborts the step.
* Revert "ci: split src cache into 4 parallel-extractable shards"
This reverts commit 970574998b.
121 lines
4.1 KiB
YAML
121 lines
4.1 KiB
YAML
name: 'Restore Cache AZCopy'
|
|
description: 'Restores Electron src cache via AZCopy'
|
|
inputs:
|
|
target-platform:
|
|
description: 'Target platform, should be linux, win, macos'
|
|
runs:
|
|
using: "composite"
|
|
steps:
|
|
- name: Obtain SAS Key
|
|
continue-on-error: true
|
|
uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
|
|
with:
|
|
path: sas-token
|
|
key: sas-key-${{ inputs.target-platform }}-${{ github.run_number }}-1
|
|
enableCrossOsArchive: true
|
|
- name: Obtain SAS Key
|
|
continue-on-error: true
|
|
uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
|
|
with:
|
|
path: sas-token
|
|
key: sas-key-${{ inputs.target-platform }}-${{ github.run_number }}-${{ github.run_attempt }}
|
|
enableCrossOsArchive: true
|
|
- name: Download Src Cache from AKS
|
|
# The cache will always exist here as a result of the checkout job
|
|
# Either it was uploaded to Azure in the checkout job for this commit
|
|
# or it was uploaded in the checkout job for a previous commit.
|
|
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
|
|
with:
|
|
timeout_minutes: 30
|
|
max_attempts: 3
|
|
retry_on: error
|
|
shell: bash
|
|
command: |
|
|
sas_token=$(cat sas-token)
|
|
if [ -z "$sas_token" ]; then
|
|
echo "SAS Token not found; exiting src cache download early..."
|
|
exit 1
|
|
else
|
|
sas_token=$(jq -r '.sasToken' sas-token)
|
|
account_name=$(jq -r '.accountName' sas-token)
|
|
if [ "${{ inputs.target-platform }}" = "win" ]; then
|
|
azcopy copy --log-level=ERROR \
|
|
"https://$account_name.file.core.windows.net/${{ env.AZURE_AKS_WIN_CACHE_SHARE_NAME }}/${{ env.CACHE_PATH }}?$sas_token" $DEPSHASH.tar
|
|
else
|
|
azcopy copy --log-level=ERROR \
|
|
"https://$account_name.file.core.windows.net/${{ env.AZURE_AKS_CACHE_SHARE_NAME }}/${{ env.CACHE_PATH }}?$sas_token" $DEPSHASH.tar
|
|
fi
|
|
fi
|
|
env:
|
|
AZURE_AKS_CACHE_SHARE_NAME: linux-cache
|
|
AZURE_AKS_WIN_CACHE_SHARE_NAME: windows-cache
|
|
- name: Clean SAS Key
|
|
shell: bash
|
|
run: rm -f sas-token
|
|
- name: Unzip and Ensure Src Cache
|
|
if: ${{ inputs.target-platform == 'macos' }}
|
|
shell: bash
|
|
run: |
|
|
echo "Downloaded cache is $(du -sh $DEPSHASH.tar | cut -f1)"
|
|
if [ `du $DEPSHASH.tar | cut -f1` = "0" ]; then
|
|
echo "Cache is empty - exiting"
|
|
exit 1
|
|
fi
|
|
|
|
mkdir temp-cache
|
|
zstd -d --long=30 -c $DEPSHASH.tar | tar -xf - -C temp-cache
|
|
echo "Unzipped cache is $(du -sh temp-cache/src | cut -f1)"
|
|
|
|
if [ -d "temp-cache/src" ]; then
|
|
echo "Relocating Cache"
|
|
rm -rf src
|
|
mv temp-cache/src src
|
|
|
|
echo "Deleting zip file"
|
|
rm -rf $DEPSHASH.tar
|
|
fi
|
|
|
|
if [ ! -d "src/third_party/blink" ]; then
|
|
echo "Cache was not correctly restored - exiting"
|
|
exit 1
|
|
fi
|
|
|
|
echo "Wiping Electron Directory"
|
|
rm -rf src/electron
|
|
|
|
- name: Unzip and Ensure Src Cache (Windows)
|
|
if: ${{ inputs.target-platform == 'win' }}
|
|
shell: bash
|
|
run: |
|
|
echo "Downloaded cache is $(du -sh $DEPSHASH.tar | cut -f1)"
|
|
if [ `du $DEPSHASH.tar | cut -f1` = "0" ]; then
|
|
echo "Cache is empty - exiting"
|
|
exit 1
|
|
fi
|
|
|
|
mkdir temp-cache
|
|
zstd -d --long=30 -c $DEPSHASH.tar | tar -xf - -C temp-cache
|
|
rm -f $DEPSHASH.tar
|
|
|
|
- name: Move Src Cache (Windows)
|
|
if: ${{ inputs.target-platform == 'win' }}
|
|
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
|
|
with:
|
|
timeout_minutes: 30
|
|
max_attempts: 3
|
|
retry_on: error
|
|
shell: powershell
|
|
command: |
|
|
if (Test-Path "temp-cache\src") {
|
|
Write-Host "Relocating Cache"
|
|
Remove-Item -Recurse -Force src
|
|
Move-Item temp-cache\src src
|
|
}
|
|
if (-Not (Test-Path "src\third_party\blink")) {
|
|
Write-Host "Cache was not correctly restored - exiting"
|
|
exit 1
|
|
}
|
|
|
|
Write-Host "Wiping Electron Directory"
|
|
Remove-Item -Recurse -Force src\electron
|