mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
676605bdf3
Key fixes: - Replace `base::WeakPtrFactory` with `gin::WeakCellFactory` in MenuMac, MenuViews, and NetLog, since weak pointers to cppgc-managed objects must go through weak cells - Replace `v8::Global<v8::Value>` with `cppgc::Persistent<Menu>` for the menu reference in BaseWindow - Stop using `gin_helper::Handle<T>` with cppgc types; use raw `T*` and add a `static_assert` to prevent future misuse - Add proper `Trace()` overrides for Menu, MenuMac, MenuViews, and NetLog to ensure cppgc members are visited during garbage collection - Replace `SelfKeepAlive` prevent-GC mechanism in Menu with a `cppgc::Persistent` prevent-GC captured in `BindSelfToClosure` - Introduce `GC_PLUGIN_IGNORE` macro to suppress known-safe violations: mojo::Remote fields, ObjC bridging pointers, and intentional persistent self-references - Mark `ArgumentHolder` as `CPPGC_STACK_ALLOCATED()` in both Electron's and gin's function_template.h to silence raw-pointer-to-GC-type warnings
57 lines
1.9 KiB
C++
57 lines
1.9 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ELECTRON_SHELL_BROWSER_API_ELECTRON_API_DATA_PIPE_HOLDER_H_
|
|
#define ELECTRON_SHELL_BROWSER_API_ELECTRON_API_DATA_PIPE_HOLDER_H_
|
|
|
|
#include <string>
|
|
|
|
#include "gin/wrappable.h"
|
|
#include "mojo/public/cpp/bindings/remote.h"
|
|
#include "services/network/public/cpp/data_element.h"
|
|
#include "services/network/public/mojom/data_pipe_getter.mojom.h"
|
|
#include "shell/common/gc_plugin.h"
|
|
|
|
namespace electron::api {
|
|
|
|
// Retains reference to the data pipe.
|
|
class DataPipeHolder final : public gin::Wrappable<DataPipeHolder> {
|
|
public:
|
|
// gin::Wrappable
|
|
static const gin::WrapperInfo kWrapperInfo;
|
|
const gin::WrapperInfo* wrapper_info() const override;
|
|
const char* GetHumanReadableName() const override;
|
|
|
|
static DataPipeHolder* Create(v8::Isolate* isolate,
|
|
const network::DataElement& element);
|
|
static DataPipeHolder* From(v8::Isolate* isolate, std::string_view id);
|
|
|
|
// Make public for cppgc::MakeGarbageCollected.
|
|
explicit DataPipeHolder(const network::DataElement& element);
|
|
~DataPipeHolder() override;
|
|
|
|
// Read all data at once.
|
|
//
|
|
// TODO(zcbenz): This is apparently not suitable for really large data, but
|
|
// no one has complained about it yet.
|
|
v8::Local<v8::Promise> ReadAll(v8::Isolate* isolate);
|
|
|
|
// The unique ID that can be used to receive the object.
|
|
const std::string& id() const { return id_; }
|
|
|
|
// disable copy
|
|
DataPipeHolder(const DataPipeHolder&) = delete;
|
|
DataPipeHolder& operator=(const DataPipeHolder&) = delete;
|
|
|
|
private:
|
|
std::string id_;
|
|
GC_PLUGIN_IGNORE(
|
|
"Context tracking of remote is not needed in the browser process.")
|
|
mojo::Remote<network::mojom::DataPipeGetter> data_pipe_;
|
|
};
|
|
|
|
} // namespace electron::api
|
|
|
|
#endif // ELECTRON_SHELL_BROWSER_API_ELECTRON_API_DATA_PIPE_HOLDER_H_
|