mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
676605bdf3
Key fixes: - Replace `base::WeakPtrFactory` with `gin::WeakCellFactory` in MenuMac, MenuViews, and NetLog, since weak pointers to cppgc-managed objects must go through weak cells - Replace `v8::Global<v8::Value>` with `cppgc::Persistent<Menu>` for the menu reference in BaseWindow - Stop using `gin_helper::Handle<T>` with cppgc types; use raw `T*` and add a `static_assert` to prevent future misuse - Add proper `Trace()` overrides for Menu, MenuMac, MenuViews, and NetLog to ensure cppgc members are visited during garbage collection - Replace `SelfKeepAlive` prevent-GC mechanism in Menu with a `cppgc::Persistent` prevent-GC captured in `BindSelfToClosure` - Introduce `GC_PLUGIN_IGNORE` macro to suppress known-safe violations: mojo::Remote fields, ObjC bridging pointers, and intentional persistent self-references - Mark `ArgumentHolder` as `CPPGC_STACK_ALLOCATED()` in both Electron's and gin's function_template.h to silence raw-pointer-to-GC-type warnings
72 lines
2.4 KiB
C++
72 lines
2.4 KiB
C++
// Copyright 2014 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/browser/extensions/electron_extension_host_delegate.h"
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
#include <utility>
|
|
|
|
#include "extensions/browser/media_capture_util.h"
|
|
#include "shell/browser/api/electron_api_web_contents.h"
|
|
#include "shell/browser/extensions/electron_extension_web_contents_observer.h"
|
|
#include "shell/common/gin_helper/handle.h"
|
|
#include "v8/include/v8.h"
|
|
|
|
namespace extensions {
|
|
|
|
ElectronExtensionHostDelegate::ElectronExtensionHostDelegate() = default;
|
|
|
|
ElectronExtensionHostDelegate::~ElectronExtensionHostDelegate() = default;
|
|
|
|
void ElectronExtensionHostDelegate::OnExtensionHostCreated(
|
|
content::WebContents* web_contents) {
|
|
ElectronExtensionWebContentsObserver::CreateForWebContents(web_contents);
|
|
v8::Isolate* isolate = v8::Isolate::GetCurrent();
|
|
v8::HandleScope scope(isolate);
|
|
electron::api::WebContents::FromOrCreate(isolate, web_contents);
|
|
}
|
|
|
|
void ElectronExtensionHostDelegate::CreateTab(
|
|
std::unique_ptr<content::WebContents> web_contents,
|
|
const GURL& target_url,
|
|
const ExtensionId& extension_id,
|
|
WindowOpenDisposition disposition,
|
|
const blink::mojom::WindowFeatures& window_features,
|
|
bool user_gesture) {
|
|
// TODO(jamescook): Should app_shell support opening popup windows?
|
|
NOTREACHED();
|
|
}
|
|
|
|
void ElectronExtensionHostDelegate::ProcessMediaAccessRequest(
|
|
content::WebContents* web_contents,
|
|
const content::MediaStreamRequest& request,
|
|
content::MediaResponseCallback callback,
|
|
const Extension* extension) {
|
|
// Allow access to the microphone and/or camera.
|
|
media_capture_util::GrantMediaStreamRequest(web_contents, request,
|
|
std::move(callback), extension);
|
|
}
|
|
|
|
bool ElectronExtensionHostDelegate::CheckMediaAccessPermission(
|
|
content::RenderFrameHost* render_frame_host,
|
|
const url::Origin& security_origin,
|
|
blink::mojom::MediaStreamType type,
|
|
const Extension* extension) {
|
|
media_capture_util::VerifyMediaAccessPermission(type, extension);
|
|
return true;
|
|
}
|
|
|
|
content::PictureInPictureResult
|
|
ElectronExtensionHostDelegate::EnterPictureInPicture(
|
|
content::WebContents* web_contents) {
|
|
NOTREACHED();
|
|
}
|
|
|
|
void ElectronExtensionHostDelegate::ExitPictureInPicture() {
|
|
NOTREACHED();
|
|
}
|
|
|
|
} // namespace extensions
|