mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
2b07e6450c
* chore: bump chromium in DEPS to 138.0.7152.0 * chore: update patches * chore: bump chromium in DEPS to 138.0.7154.0 * chore: update patches * ozone/wayland: Fix bookmark dropdown right click context menu https://chromium-review.googlesource.com/c/chromium/src/+/6488801 * Use base::cstring_view in base::Environment https://chromium-review.googlesource.com/c/chromium/src/+/6494292 * [A11yPerformance] Remove Add/Remove AXMode methods https://chromium-review.googlesource.com/c/chromium/src/+/6418444 xref: https://chromium-review.googlesource.com/c/chromium/src/+/6383275 * build: update filenames.libcxx.gni * Use base::cstring_view in base::Environment https://chromium-review.googlesource.com/c/chromium/src/+/6494292 * Use getters to expose NativePixmapHandle from GpuMemoryBufferHandle https://chromium-review.googlesource.com/c/chromium/src/+/6374406 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
31 lines
1.4 KiB
Diff
31 lines
1.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jeremy Rose <japthorp@slack-corp.com>
|
|
Date: Mon, 20 Jun 2022 14:53:37 -0700
|
|
Subject: disable freezing flags after init in node
|
|
|
|
This was introduced in
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/3687671.
|
|
|
|
When running node in the renderer, flags are updated after initialization, so
|
|
freezing the flags in Blink causes node initialization to fail.
|
|
|
|
If possible, it would be ideal to do this without a patch.
|
|
https://bugs.chromium.org/p/v8/issues/detail?id=12887 suggests that there may
|
|
at some point be an API to "unfreeze" the flags, or we may be able to refactor
|
|
node initialization to not update flags after V8 initialization.
|
|
|
|
diff --git a/content/renderer/render_process_impl.cc b/content/renderer/render_process_impl.cc
|
|
index 7a20f5199bd6cb5d13f31ec5db3e3cc03821bc3a..22167f808cb7b27d5b2a8e517cdeee63205ab9ad 100644
|
|
--- a/content/renderer/render_process_impl.cc
|
|
+++ b/content/renderer/render_process_impl.cc
|
|
@@ -212,6 +212,9 @@ RenderProcessImpl::RenderProcessImpl()
|
|
v8::V8::SetFlagsFromString(kSABPerContextFlag, sizeof(kSABPerContextFlag));
|
|
}
|
|
|
|
+ // Freezing flags after init conflicts with node in the renderer.
|
|
+ v8::V8::SetFlagsFromString("--no-freeze-flags-after-init");
|
|
+
|
|
if (base::FeatureList::IsEnabled(features::kWebAssemblyTrapHandler)) {
|
|
content::GetContentClient()->renderer()->SetUpWebAssemblyTrapHandler();
|
|
}
|