mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
refactor: add static `ReplyChannel::SendError()` helper (#49338) * refactor: add static void ReplyChannel::SendError() * refactor: use static SendError() instead of instantiating a temporary * refactor: remove non-static version of SendError() * refactor: remove redundant callback-is-non-null checks Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
64 lines
2.0 KiB
C++
64 lines
2.0 KiB
C++
// Copyright (c) 2023 Salesforce, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ELECTRON_SHELL_COMMON_GIN_HELPER_REPLY_CHANNEL_H_
|
|
#define ELECTRON_SHELL_COMMON_GIN_HELPER_REPLY_CHANNEL_H_
|
|
|
|
#include <string_view>
|
|
|
|
#include "shell/common/api/api.mojom.h"
|
|
#include "shell/common/gin_helper/wrappable.h"
|
|
|
|
namespace gin_helper {
|
|
template <typename T>
|
|
class Handle;
|
|
} // namespace gin_helper
|
|
|
|
namespace v8 {
|
|
class Isolate;
|
|
template <typename T>
|
|
class Local;
|
|
class Object;
|
|
class ObjectTemplate;
|
|
} // namespace v8
|
|
|
|
namespace gin_helper::internal {
|
|
|
|
// This object wraps the InvokeCallback so that if it gets GC'd by V8, we can
|
|
// still call the callback and send an error. Not doing so causes a Mojo DCHECK,
|
|
// since Mojo requires callbacks to be called before they are destroyed.
|
|
class ReplyChannel : public gin_helper::DeprecatedWrappable<ReplyChannel> {
|
|
public:
|
|
using InvokeCallback = electron::mojom::ElectronApiIPC::InvokeCallback;
|
|
static gin_helper::Handle<ReplyChannel> Create(v8::Isolate* isolate,
|
|
InvokeCallback callback);
|
|
|
|
// gin_helper::Wrappable
|
|
static gin::DeprecatedWrapperInfo kWrapperInfo;
|
|
gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
|
|
v8::Isolate* isolate) override;
|
|
const char* GetTypeName() override;
|
|
|
|
// Invokes `callback` (if it's non-null) with `errmsg` as an arg.
|
|
static void SendError(v8::Isolate* isolate,
|
|
InvokeCallback callback,
|
|
std::string_view errmsg);
|
|
|
|
private:
|
|
explicit ReplyChannel(InvokeCallback callback);
|
|
~ReplyChannel() override;
|
|
|
|
static bool SendReplyImpl(v8::Isolate* isolate,
|
|
InvokeCallback callback,
|
|
v8::Local<v8::Value> arg);
|
|
|
|
bool SendReply(v8::Isolate* isolate, v8::Local<v8::Value> arg);
|
|
|
|
InvokeCallback callback_;
|
|
};
|
|
|
|
} // namespace gin_helper::internal
|
|
|
|
#endif // ELECTRON_SHELL_COMMON_GIN_HELPER_REPLY_CHANNEL_H_
|