trop[bot] 573c8aa656 refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> (#47452) ...

* refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fixup! refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>

2025-06-13 10:03:05 +02:00

..

views

chore: bump chromium to 135.0.7015.0 (main) (#45500)

2025-02-18 11:51:27 -05:00

electron_api_app_mac.mm

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_api_app_mas.mm

chore: bump chromium to 117.0.5923.0 (main) (#39304)

2023-08-04 10:47:29 +02:00

electron_api_app.cc

chore: bump chromium to 136.0.7095.0 (36-x-y) (#46184)

2025-04-07 13:09:35 -05:00

electron_api_app.h

refactor: remove unused electron::api::App::FileIconCallback (#46510)

2025-04-05 10:44:18 -05:00

electron_api_auto_updater.cc

refactor: only pass v8::Context to gin_helper::MicrotasksScope constructor (#45484)

2025-02-07 10:44:19 +09:00

electron_api_auto_updater.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_base_window_mac.mm

fix: explicitly call GetNativeNSView() on macOS (#46750)

2025-04-24 09:53:53 -05:00

electron_api_base_window.cc

feat: expose win.isContentProtected() (#47311)

2025-06-05 15:47:23 +02:00

electron_api_base_window.h

refactor: make TrackableObject::weak_map_id() constexpr (#47116)

2025-05-16 02:32:44 -05:00

electron_api_browser_window.cc

refactor: remove public method BrowserWindow::GetWeakPtr() (#46796)

2025-04-25 20:09:44 -05:00

electron_api_browser_window.h

refactor: remove public method BrowserWindow::GetWeakPtr() (#46796)

2025-04-25 20:09:44 -05:00

electron_api_content_tracing.cc

refactor: in StopTracing(), use string literals instead of optional<string> (#45270)

2025-01-21 17:41:52 -06:00

electron_api_cookies.cc

chore: bump chromium to 136.0.7095.0 (36-x-y) (#46184)

2025-04-07 13:09:35 -05:00

electron_api_cookies.h

chore: remove unused isolate argument from Cookies constructor (#44907)

2024-12-02 11:34:21 -05:00

electron_api_crash_reporter.cc

refactor: fix modernize-return-braced-init-list warnings (#44838)

2024-11-27 09:41:46 +09:00

electron_api_crash_reporter.h

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_api_data_pipe_holder.cc

refactor: make node Buffers more friendly to base::span / std::span (#46778)

2025-04-25 10:24:43 -05:00

electron_api_data_pipe_holder.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_debugger.cc

fix: crash calling Fetch.continueResponse with WebContentsView (#47442)

2025-06-11 16:28:41 -05:00

electron_api_debugger.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_desktop_capturer_mac.mm

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

electron_api_desktop_capturer.cc

perf: don't wait for thumbnails if they were not requested on macOS (#46251)

2025-03-25 10:03:08 -05:00

electron_api_desktop_capturer.h

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

electron_api_dialog.cc

refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> (#47452)

2025-06-13 10:03:05 +02:00

electron_api_download_item.cc

refactor: return-braced-init-list pt 2 of 2 (#44870)

2024-11-29 11:44:33 -06:00

electron_api_download_item.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_event_emitter.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_api_event_emitter.h

chore: add ELECTRON_ prefix to C++ include guards (#31925)

2021-11-22 16:34:31 +09:00

electron_api_extensions.cc

refactor: move extension APIs to session.extensions (#45597)

2025-02-21 17:36:51 -06:00

electron_api_extensions.h

refactor: move extension APIs to session.extensions (#45597)

2025-02-21 17:36:51 -06:00

electron_api_global_shortcut.cc

perf: avoid redundant map lookups in GlobalShortcut (#46261)

2025-03-25 13:09:14 -05:00

electron_api_global_shortcut.h

refactor: remove unused v8::Isolate* arg from GlobalShortcut constructor (#45773)

2025-02-24 19:38:20 -06:00

electron_api_in_app_purchase.cc

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

electron_api_in_app_purchase.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_menu_mac.h

feat: add support for associating a Menu with a WebFrameMain (#46350)

2025-04-01 09:00:46 -05:00

electron_api_menu_mac.mm

fix: fallback to old MacOS context menu behavior if no frame is present (#46619)

2025-04-14 11:24:01 +02:00

electron_api_menu_views.cc

feat: add support for associating a Menu with a WebFrameMain (#46350)

2025-04-01 09:00:46 -05:00

electron_api_menu_views.h

feat: add support for associating a Menu with a WebFrameMain (#46350)

2025-04-01 09:00:46 -05:00

electron_api_menu.cc

feat: add support for associating a Menu with a WebFrameMain (#46350)

2025-04-01 09:00:46 -05:00

electron_api_menu.h

feat: add support for associating a Menu with a WebFrameMain (#46350)

2025-04-01 09:00:46 -05:00

electron_api_native_theme_mac.mm

chore: cleanup arc migration helpers (#39606)

2023-08-23 09:54:21 -04:00

electron_api_native_theme.cc

feat: expose nativeTheme.shouldUseDarkColorsForSystemIntegratedUI (#46598)

2025-04-16 19:40:55 +02:00

electron_api_native_theme.h

feat: expose nativeTheme.shouldUseDarkColorsForSystemIntegratedUI (#46598)

2025-04-16 19:40:55 +02:00

electron_api_net_log.cc

refactor: fix modernize-return-braced-init-list warnings (#44838)

2024-11-27 09:41:46 +09:00

electron_api_net_log.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_notification.cc

fix: crash in gin::wrappable::secondweakcallback (#45368)

2025-01-29 10:20:37 -08:00

electron_api_notification.h

fix: crash in gin::wrappable::secondweakcallback (#45368)

2025-01-29 10:20:37 -08:00

electron_api_power_monitor_mac.mm

fix: remove extra 'suspend'/'resume' handling from powerMonitor (#47189)

2025-05-22 12:37:09 +02:00

electron_api_power_monitor_win.cc

fix: remove extra 'suspend'/'resume' handling from powerMonitor (#47189)

2025-05-22 12:37:09 +02:00

electron_api_power_monitor.cc

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

electron_api_power_monitor.h

docs: fix spelling errors in code comments (#45842)

2025-02-28 12:24:00 +01:00

electron_api_power_save_blocker.cc

refactor: use C++20's contains() method (#45742)

2025-02-21 17:33:43 -06:00

electron_api_power_save_blocker.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_printing.cc

chore: bump chromium to 135.0.7015.0 (main) (#45500)

2025-02-18 11:51:27 -05:00

electron_api_protocol.cc

refactor: reduce coupling in electron::api::Protocol (#46182)

2025-03-21 12:54:11 -05:00

electron_api_protocol.h

refactor: reduce coupling in electron::api::Protocol (#46182)

2025-03-21 12:54:11 -05:00

electron_api_push_notifications_mac.mm

fix: APNS token ids are lowercase ASCII (#46149)

2025-03-20 16:52:23 -05:00

electron_api_push_notifications.cc

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

electron_api_push_notifications.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_safe_storage.cc

refactor: make node Buffers more friendly to base::span / std::span (#46778)

2025-04-25 10:24:43 -05:00

electron_api_screen.cc

feat: support dip <-> screen conversion on Linux (#47125)

2025-05-21 09:57:32 -07:00

electron_api_screen.h

feat: support dip <-> screen conversion on Linux (#47125)

2025-05-21 09:57:32 -07:00

electron_api_service_worker_context.cc

feat: ServiceWorkerMain (#45232)

2025-01-24 08:33:44 -05:00

electron_api_service_worker_context.h

feat: ServiceWorkerMain (#45232)

2025-01-24 08:33:44 -05:00

electron_api_service_worker_main.cc

perf: use absl::flat_hash_map instead of std::unordered_map (#46217)

2025-03-24 09:30:52 -05:00

electron_api_service_worker_main.h

refactor: remove unused field ServiceWorkerMain::weak_factory_ (#46205)

2025-03-23 10:26:24 -05:00

electron_api_session.cc

fix: rework lifetime mgmt of ClearDataTask/ClearDataOperation (#47411)

2025-06-12 12:24:50 +02:00

electron_api_session.h

refactor: move extension APIs to session.extensions (#45597)

2025-02-21 17:36:51 -06:00

electron_api_system_preferences_mac.mm

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

electron_api_system_preferences_win.cc

chore: deprecate systemPreferences.isAeroGlassEnabled() (#45434)

2025-02-10 15:17:07 -05:00

electron_api_system_preferences.cc

chore: deprecate systemPreferences.isAeroGlassEnabled() (#45434)

2025-02-10 15:17:07 -05:00

electron_api_system_preferences.h

chore: deprecate systemPreferences.isAeroGlassEnabled() (#45434)

2025-02-10 15:17:07 -05:00

electron_api_tray.cc

fix: crash in gin::wrappable::secondweakcallback (#45368)

2025-01-29 10:20:37 -08:00

electron_api_tray.h

fix: crash in gin::wrappable::secondweakcallback (#45368)

2025-01-29 10:20:37 -08:00

electron_api_utility_process.cc

fix: postMessage crash with invalid transferrable (#46667)

2025-04-17 18:23:23 +02:00

electron_api_utility_process.h

refactor: use private inheritance from mojo::MessageReceiver (#45996)

2025-03-12 23:20:55 -05:00

electron_api_view.cc

fix: addChildView() crashes when adding a closed WebContentsView (#47340)

2025-06-04 14:08:44 +02:00

electron_api_view.h

refactor: make api::View methods const, private (#46551)

2025-04-08 08:53:17 -05:00

electron_api_web_contents_impl.cc

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

electron_api_web_contents_mac.mm

fix: explicitly call GetNativeNSView() on macOS (#46750)

2025-04-24 09:53:53 -05:00

electron_api_web_contents_view.cc

refactor: add NativeWindow::FromWidget() helper (36-x-y) (#46932)

2025-05-06 09:51:11 +02:00

electron_api_web_contents_view.h

feat: customize border radius of Views (#42320)

2024-07-16 20:16:25 -04:00

electron_api_web_contents.cc

refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> (#47452)

2025-06-13 10:03:05 +02:00

electron_api_web_contents.h

feat: allow intercepting mouse events (#47365)

2025-06-05 18:35:33 +02:00

electron_api_web_frame_main.cc

perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost() (#46331)

2025-03-27 18:13:39 -05:00

electron_api_web_frame_main.h

feat: add support for associating a Menu with a WebFrameMain (#46350)

2025-04-01 09:00:46 -05:00

electron_api_web_request.cc

refactor: add EmitDeprecationWarning helper (#46879)

2025-05-01 09:44:59 -05:00

electron_api_web_request.h

feat: add excludeUrls and modify urls in WebRequestFilter for better URL filtering (#44692)

2025-02-17 12:40:47 -08:00

electron_api_web_view_manager.cc

chore: rename built-in modules to bindings to match naming update in node (#37182)

2023-02-09 10:31:38 +09:00

frame_subscriber.cc

refactor: put empty virtual function definitions in header (#43285)

2024-08-12 09:56:51 +02:00

frame_subscriber.h

refactor: put empty virtual function definitions in header (#43285)

2024-08-12 09:56:51 +02:00

gpu_info_enumerator.cc

refactor: simplify code by using base::Value::EnsureList() (#41162)

2024-01-30 14:48:09 -06:00

gpu_info_enumerator.h

refactor: remove unused system header includes (#46043)

2025-03-14 17:06:04 -05:00

gpuinfo_manager.cc

fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8 (#46471)

2025-04-03 18:05:13 -05:00

gpuinfo_manager.h

fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8 (#46471)

2025-04-03 18:05:13 -05:00

ipc_dispatcher.h

refactor: dispatch IPC messages from Session (#45452)

2025-02-17 16:36:28 -05:00

message_port.cc

fix: postMessage crash with invalid transferrable (#46667)

2025-04-17 18:23:23 +02:00

message_port.h

refactor: use private inheritance from mojo::MessageReceiver (#45996)

2025-03-12 23:20:55 -05:00

process_metric.cc

build: make is_mas_build a generated header instead of config (#43737)

2024-09-17 01:38:56 -07:00

process_metric.h

chore: bump chromium to 100.0.4857.0 (main) (#32419)

2022-02-09 18:58:52 -08:00

save_page_handler.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

save_page_handler.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

ui_event.cc

chore: used nested namespaces (#34737)

2022-06-29 12:55:47 -07:00

ui_event.h

chore: used nested namespaces (#34737)

2022-06-29 12:55:47 -07:00