mirror of
https://github.com/electron/electron.git
synced 2026-02-19 03:14:51 -05:00
744142fe54
Reduce stack memory consumption in BytecodeGenerator Backports 1) https://chromium-review.googlesource.com/c/v8/v8/+/7180480 2) https://chromium-review.googlesource.com/c/v8/v8/+/7160576 3) https://chromium-review.googlesource.com/c/v8/v8/+/7062734 2 and 3 are needed to cleanly land 1. However, most of the code changes are noop since v8_flags.proto_assign_seq_opt is experimental and disabled by default for feature. The reason why stack memory consumption is improved for all scenarios can be found in https://github.com/microsoft/vscode/issues/283403#issuecomment-3737968271
Exporting node's patches to v8
$ cd third_party/electron_node
$ CURRENT_NODE_VERSION=vX.Y.Z # e.g. v10.11.0
# Find the last commit with the message "deps: update V8 to <some version>"
# This commit corresponds to node resetting V8 to its pristine upstream
# state at the stated version.
$ LAST_V8_UPDATE="$(git log --grep='^deps: update V8' --format='%H' -1 deps/v8)"
# This creates a patch file containing all changes in deps/v8 from
# $LAST_V8_UPDATE up to the current node version, formatted in a way that
# it will apply cleanly to the V8 repository (i.e. with `deps/v8`
# stripped off the path and excluding the v8/gypfiles directory, which
# isn't present in V8.
$ git format-patch \
--relative=deps/v8 \
$LAST_V8_UPDATE..$CURRENT_NODE_VERSION \
deps/v8 \
':(exclude)deps/v8/gypfiles' \
--stdout
When upgrading to a new version of node, make sure to match node's patches to
v8 by removing all the deps_* patches and re-exporting node's v8 patches
using the process above.