mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
1657908fa8
* fix: build angle dependency with VS 2019 Applies upstream patch to angle, fixing build errors when building the angle dependency with the STL shipped with Visual Studio 2019. Can be removed after this commit comes from upstream:755417dd79* fix: build v8 dependency with VS 2019 Applies upstream patch to v8, fixing build errors when building the v8 dependency with the STL shipped with Visual Studio 2019. Can be removed after this commit comes from upstream:53e62affd3* fix: build perfetto dependency with VS 2019 Applies upstream patch to perfetto, fixing build errors when building the perfetto dependency with the STL shipped with Visual Studio 2019. Can be removed after this commit comes from upstream:f10b2053be* fix: build quiche dependency with VS 2019 Applies upstream patch to quiche, fixing build errors when building the quiche dependency with the STL shipped with Visual Studio 2019. Can be removed after this commit comes from upstream: https://quiche.googlesource.com/quiche/+/c1e9121f16559b084bb80afc6922f0316d082160
Exporting node's patches to v8
$ cd third_party/electron_node
$ CURRENT_NODE_VERSION=vX.Y.Z # e.g. v10.11.0
# Find the last commit with the message "deps: update V8 to <some version>"
# This commit corresponds to node resetting V8 to its pristine upstream
# state at the stated version.
$ LAST_V8_UPDATE="$(git log --grep='^deps: update V8' --format='%H' -1 deps/v8)"
# This creates a patch file containing all changes in deps/v8 from
# $LAST_V8_UPDATE up to the current node version, formatted in a way that
# it will apply cleanly to the V8 repository (i.e. with `deps/v8`
# stripped off the path and excluding the v8/gypfiles directory, which
# isn't present in V8.
$ git format-patch \
--relative=deps/v8 \
$LAST_V8_UPDATE..$CURRENT_NODE_VERSION \
deps/v8 \
':(exclude)deps/v8/gypfiles' \
--stdout
When upgrading to a new version of node, make sure to match node's patches to
v8 by removing all the deps_* patches and re-exporting node's v8 patches
using the process above.