[FEATURE]: Make GEOCODES_MAPS_API optional again #63

New Issue

AtHeartEngineer · 2025-07-08T08:39:01-04:00

AtHeartEngineer commented

2025-07-08 08:39:01 -04:00

Originally created by @Millio345 on 5/27/2025

Summary

Until release 0.11.2 "GEOCODES_MAPS_API" defaulted to "changeme". I see that this default was removed, but the code for location_based_on_coordinates still supports skipping location address lookup when manually setting the value to "changeme".

I'm not completely sure what I'm missing out on by not having this geodata/address conversion, but since Endurain still seems to work perfectly fine without it , would it be possible to make this env variable optional again and just clearly explain in the docs what users miss out on.

Motivation

Since once of the main selling points of endurain and selfhosting in general is privacy and not having to rely on external services it would be nice to not require sending your location data to an external API.

Proposed Solution

Either revert back to the default "changeme" or support this variable being empty making location_based_on_coordinates return None.

*Originally created by @Millio345 on 5/27/2025* ## Summary Until release 0.11.2 "GEOCODES_MAPS_API" defaulted to "changeme". I see that this default was removed, but the code for location_based_on_coordinates still supports skipping location address lookup when manually setting the value to "changeme". I'm not completely sure what I'm missing out on by not having this geodata/address conversion, but since Endurain still seems to work perfectly fine without it , would it be possible to make this env variable optional again and just clearly explain in the docs what users miss out on. ## Motivation Since once of the main selling points of endurain and selfhosting in general is privacy and not having to rely on external services it would be nice to not require sending your location data to an external API. ## Proposed Solution Either revert back to the default "changeme" or support this variable being empty making location_based_on_coordinates return None.

AtHeartEngineer added the enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement labels 2025-07-08 08:39:01 -04:00

AtHeartEngineer referenced this issue

2025-07-08 08:41:45 -04:00

Read Endurain port from environment #164

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/endurain#63