Fix docker image tag (#274)

.github/workflows/test-zkvm.yml

@@ -18,12 +18,47 @@ env:
   CARGO_TERM_COLOR: always
 
 jobs:
-  build_image:
-    name: Build image
+  create_semver_image_tag:
+    name: Tag image with SemVer
+    if: startsWith(github.ref, 'refs/tags/')
     runs-on: ubuntu-latest
     permissions:
       contents: read
       packages: write
+    steps:
+      - name: Log in to GitHub Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Add SemVer tag to images
+        run: |
+          GIT_SHA="${{ github.sha }}"
+          GIT_SHA_TAG="${GIT_SHA:0:7}"
+
+          GIT_TAG="${{ github.ref_name }}"
+          SEMVER_TAG="${GIT_TAG#v}"
+
+          IMAGE_REGISTRY="ghcr.io/${{ github.repository }}"
+
+          for IMAGE in \
+            "ere-base" \
+            "ere-base-${{ inputs.zkvm }}" \
+            "ere-compiler-${{ inputs.zkvm }}" \
+            "ere-server-${{ inputs.zkvm }}"
+          do
+            echo "Tagging $IMAGE_REGISTRY/$IMAGE:$GIT_SHA_TAG as $SEMVER_TAG"
+            docker buildx imagetools create \
+              "$IMAGE_REGISTRY/$IMAGE:$GIT_SHA_TAG" \
+              --tag "$IMAGE_REGISTRY/$IMAGE:$SEMVER_TAG"
+          done
+
+  image_meta:
+    name: Get image metadata
+    if: github.event_name == 'pull_request' || (github.event_name == 'push' && github.ref == 'refs/heads/master')
+    runs-on: ubuntu-latest
     outputs:
       image_registry: ${{ steps.image_meta.outputs.image_registry }}
       image_tag: ${{ steps.image_meta.outputs.image_tag }}
@@ -36,16 +71,6 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-      - name: Free up disk space
-        run: bash .github/scripts/free-up-disk-space.sh
-
-      - name: Log in to GitHub Container Registry
-        uses: docker/login-action@v3
-        with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
       - name: Check Dockerfile changes
         id: changed_files
         uses: tj-actions/changed-files@v46
@@ -57,14 +82,8 @@ jobs:
       - name: Get image metadata
         id: image_meta
         run: |
-          TAG="${{ github.ref_name }}"
-          SHA="${{ github.sha }}"
-
-          if [ "${{ github.ref_type }}" == "tag" ]; then
-            IMAGE_TAG="${TAG#v}"
-          else
-            IMAGE_TAG="${SHA:0:7}"
-          fi
+          GIT_SHA="${{ github.sha }}"
+          IMAGE_TAG="${GIT_SHA:0:7}"
 
           CACHED_IMAGE_TAG=""
           if [ "${{ github.event_name }}" == "pull_request" ] && [ "${{ steps.changed_files.outputs.any_changed }}" == "false" ]; then
@@ -86,40 +105,59 @@ jobs:
           echo "compiler_zkvm_image=$COMPILER_ZKVM_IMAGE" >> $GITHUB_OUTPUT
           echo "server_zkvm_image=$SERVER_ZKVM_IMAGE" >> $GITHUB_OUTPUT
 
+  build_image:
+    name: Build image
+    needs: image_meta
+    if: github.event_name == 'push' && github.ref == 'refs/heads/master'
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      packages: write
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Free up disk space
+        run: bash .github/scripts/free-up-disk-space.sh
+
+      - name: Log in to GitHub Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Build and push ere-base and ere-base-${{ inputs.zkvm }} images
-        if: github.event_name == 'push'
         run: |
           bash .github/scripts/build-image.sh \
             --zkvm ${{ inputs.zkvm }} \
-            --registry ${{ steps.image_meta.outputs.image_registry }} \
-            --tag ${{ steps.image_meta.outputs.image_tag }} \
+            --registry ${{ needs.image_meta.outputs.image_registry }} \
+            --tag ${{ needs.image_meta.outputs.image_tag }} \
             --base
-          docker push ${{ steps.image_meta.outputs.base_image }}
-          docker push ${{ steps.image_meta.outputs.base_zkvm_image }}
+          docker push ${{ needs.image_meta.outputs.base_image }}
+          docker push ${{ needs.image_meta.outputs.base_zkvm_image }}
 
       - name: Build and push ere-compiler-${{ inputs.zkvm }} image
-        if: github.event_name == 'push'
         run: |
           bash .github/scripts/build-image.sh \
             --zkvm ${{ inputs.zkvm }} \
-            --registry ${{ steps.image_meta.outputs.image_registry }} \
-            --tag ${{ steps.image_meta.outputs.image_tag }} \
+            --registry ${{ needs.image_meta.outputs.image_registry }} \
+            --tag ${{ needs.image_meta.outputs.image_tag }} \
             --compiler
-          docker push ${{ steps.image_meta.outputs.compiler_zkvm_image }}
+          docker push ${{ needs.image_meta.outputs.compiler_zkvm_image }}
 
       - name: Build and push ere-server-${{ inputs.zkvm }} image
-        if: github.event_name == 'push'
         run: |
           bash .github/scripts/build-image.sh \
             --zkvm ${{ inputs.zkvm }} \
-            --registry ${{ steps.image_meta.outputs.image_registry }} \
-            --tag ${{ steps.image_meta.outputs.image_tag }} \
+            --registry ${{ needs.image_meta.outputs.image_registry }} \
+            --tag ${{ needs.image_meta.outputs.image_tag }} \
             --server
-          docker push ${{ steps.image_meta.outputs.server_zkvm_image }}
+          docker push ${{ needs.image_meta.outputs.server_zkvm_image }}
 
   clippy_via_docker:
     name: Clippy via Docker
-    needs: build_image
+    needs: image_meta
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -138,13 +176,13 @@ jobs:
         run: |
           bash .github/scripts/pull-or-build-base-zkvm-image.sh \
             --zkvm ${{ inputs.zkvm }} \
-            --registry ${{ needs.build_image.outputs.image_registry }} \
-            --tag ${{ needs.build_image.outputs.image_tag }} \
-            --cached-tag "${{ needs.build_image.outputs.cached_image_tag }}"
+            --registry ${{ needs.image_meta.outputs.image_registry }} \
+            --tag ${{ needs.image_meta.outputs.image_tag }} \
+            --cached-tag "${{ needs.image_meta.outputs.cached_image_tag }}"
 
       - name: Pull base zkvm image
         if: github.event_name == 'push'
-        run: docker pull ${{ needs.build_image.outputs.base_zkvm_image }}
+        run: docker pull ${{ needs.image_meta.outputs.base_zkvm_image }}
 
       - name: Run cargo clippy for ere-${{ inputs.zkvm }} via Docker
         run: |
@@ -155,7 +193,7 @@ jobs:
             --volume $HOME/.cargo/registry:/usr/local/cargo/registry \
             --volume $HOME/.cargo/git:/usr/local/cargo/git \
             --workdir /ere \
-            ${{ needs.build_image.outputs.base_zkvm_image }} \
+            ${{ needs.image_meta.outputs.base_zkvm_image }} \
             /bin/bash"
 
           cat <<EOF | $DOCKER_CMD
@@ -173,7 +211,7 @@ jobs:
 
   test_via_docker:
     name: Test via Docker
-    needs: build_image
+    needs: image_meta
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -192,13 +230,13 @@ jobs:
         run: |
           bash .github/scripts/pull-or-build-base-zkvm-image.sh \
             --zkvm ${{ inputs.zkvm }} \
-            --registry ${{ needs.build_image.outputs.image_registry }} \
-            --tag ${{ needs.build_image.outputs.image_tag }} \
-            --cached-tag "${{ needs.build_image.outputs.cached_image_tag }}"
+            --registry ${{ needs.image_meta.outputs.image_registry }} \
+            --tag ${{ needs.image_meta.outputs.image_tag }} \
+            --cached-tag "${{ needs.image_meta.outputs.cached_image_tag }}"
 
       - name: Pull base zkvm image
         if: github.event_name == 'push'
-        run: docker pull ${{ needs.build_image.outputs.base_zkvm_image }}
+        run: docker pull ${{ needs.image_meta.outputs.base_zkvm_image }}
 
       - name: Run cargo test for ere-${{ inputs.zkvm }} via Docker
         run: |
@@ -209,7 +247,7 @@ jobs:
             --volume $HOME/.cargo/registry:/usr/local/cargo/registry \
             --volume $HOME/.cargo/git:/usr/local/cargo/git \
             --workdir /ere \
-            ${{ needs.build_image.outputs.base_zkvm_image }} \
+            ${{ needs.image_meta.outputs.base_zkvm_image }} \
             /bin/bash"
 
           cat <<EOF | $DOCKER_CMD
@@ -225,7 +263,7 @@ jobs:
 
   test_ere_dockerized:
     name: Test ere-dockerized with the selected zkVM
-    needs: build_image
+    needs: image_meta
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -249,27 +287,27 @@ jobs:
         run: |
           bash .github/scripts/pull-or-build-base-zkvm-image.sh \
             --zkvm ${{ inputs.zkvm }} \
-            --registry ${{ needs.build_image.outputs.image_registry }} \
-            --tag ${{ needs.build_image.outputs.image_tag }} \
-            --cached-tag "${{ needs.build_image.outputs.cached_image_tag }}"
+            --registry ${{ needs.image_meta.outputs.image_registry }} \
+            --tag ${{ needs.image_meta.outputs.image_tag }} \
+            --cached-tag "${{ needs.image_meta.outputs.cached_image_tag }}"
 
           # Build ere-compiler-${{ inputs.zkvm }} and ere-server-${{ inputs.zkvm }}
           bash .github/scripts/build-image.sh \
             --zkvm ${{ inputs.zkvm }} \
-            --registry ${{ needs.build_image.outputs.image_registry }} \
-            --tag ${{ needs.build_image.outputs.image_tag }} \
+            --registry ${{ needs.image_meta.outputs.image_registry }} \
+            --tag ${{ needs.image_meta.outputs.image_tag }} \
             --compiler \
             --server
 
       - name: Pull ere-compiler-${{ inputs.zkvm }} and ere-server-${{ inputs.zkvm }} images
         if: github.event_name == 'push'
         run: |
-          docker pull ${{ needs.build_image.outputs.compiler_zkvm_image }}
-          docker pull ${{ needs.build_image.outputs.server_zkvm_image }}
+          docker pull ${{ needs.image_meta.outputs.compiler_zkvm_image }}
+          docker pull ${{ needs.image_meta.outputs.server_zkvm_image }}
 
       - name: Run cargo test for ere-${{ inputs.zkvm }} via ere-dockerized
         env:
-          ERE_IMAGE_REGISTRY: ${{ needs.build_image.outputs.image_registry }}
+          ERE_IMAGE_REGISTRY: ${{ needs.image_meta.outputs.image_registry }}
         run: |
           cargo test --release --package ere-dockerized \
             -- ${{ inputs.zkvm }} ${{ inputs.skip_prove_test && '--skip prove' || ''  }} --test-threads=1