Cleanup some todos in SP1 dockerfile (#79)

This commit is contained in:
Han
2025-08-07 22:06:12 +08:00
committed by GitHub
parent 1ad15f7379
commit f281ead60a
2 changed files with 17 additions and 23 deletions

View File

@@ -5,28 +5,25 @@ FROM ${BASE_IMAGE_TAG}
ARG USERNAME=ere_user
# Copy the SP1 SDK installer script
COPY scripts/sdk_installers/install_sp1_sdk.sh /tmp/install_sp1_sdk.sh
RUN chmod +x /tmp/install_sp1_sdk.sh
COPY --chmod=+x scripts/sdk_installers/install_sp1_sdk.sh /tmp/install_sp1_sdk.sh
# TODO: Check the sp1up script to see if most of the below path configs are needed
# Define where SP1 SDK will be installed within the image.
# The install_sp1_sdk.sh script will respect these ENV variables.
# TODO: we are hardcoding /root which may not work for other users
ENV SP1UP_HOME="/root/.sp1up" \
SP1UP_SDK_INSTALL_VERSION="v5.1.0" \
SP1_HOME="/root/.sp1"
ENV SP1_DIR="/root/.sp1" \
SP1_VERSION="v5.1.0"
# Run the SP1 SDK installation script
# It will use the SP1UP_HOME and SP1_HOME defined above.
RUN /tmp/install_sp1_sdk.sh && rm /tmp/install_sp1_sdk.sh # Clean up script
# It will use the SP1_DIR and SP1_VERSION defined above.
RUN /tmp/install_sp1_sdk.sh && rm /tmp/install_sp1_sdk.sh
# Update the image's persistent PATH to include SP1 binaries.
# This uses the SP1UP_HOME and SP1_HOME defined above.
ENV PATH="${SP1UP_HOME}/bin:${SP1_HOME}/bin:$PATH"
# This uses the SP1_DIR defined above.
ENV PATH="${SP1_DIR}/bin:$PATH"
# Verify SP1 installation (optional here, as script does it, but good for sanity)
RUN cargo prove --version
# Add Docker CLI
COPY --from=docker:cli /usr/local/bin/docker /usr/local/bin/docker
CMD ["/bin/bash"]