replace badrequests

This commit is contained in:
duwenxin
2026-02-09 19:16:00 -05:00
parent f3ed08bec5
commit 95b15e4db7
11 changed files with 74 additions and 88 deletions

View File

@@ -273,28 +273,22 @@ func TestPreCheckToolEndpoints(t *testing.T) {
want: `{"preCheckResponse":[{"actionsRequired":["Fix this now."],"type":"","message":"This is a critical error.","messageType":"ERROR"}]}`,
},
{
name: "instance not found",
toolName: "precheck-tool",
body: `{"project": "p1", "instance": "instance-notfound", "targetDatabaseVersion": "POSTGRES_18"}`,
expectError: true,
errorStatus: http.StatusBadRequest,
errorMsg: "Not authorized to access instance",
name: "instance not found",
toolName: "precheck-tool",
body: `{"project": "p1", "instance": "instance-notfound", "targetDatabaseVersion": "POSTGRES_18"}`,
want: `{"error":"Not authorized to access instance"}`,
},
{
name: "missing required parameter - project",
toolName: "precheck-tool",
body: `{"instance": "instance-ok", "targetDatabaseVersion": "POSTGRES_18"}`,
expectError: true,
errorStatus: http.StatusBadRequest,
errorMsg: "parameter \\\"project\\\" is required",
name: "missing required parameter - project",
toolName: "precheck-tool",
body: `{"instance": "instance-ok", "targetDatabaseVersion": "POSTGRES_18"}`,
want: `{"error":"parameter \"project\" is required"}`,
},
{
name: "missing required parameter - instance",
toolName: "precheck-tool",
body: `{"project": "p1", "targetDatabaseVersion": "POSTGRES_18"}`, // Missing instance
expectError: true,
errorStatus: http.StatusBadRequest,
errorMsg: "parameter \\\"instance\\\" is required",
name: "missing required parameter - instance",
toolName: "precheck-tool",
body: `{"project": "p1", "targetDatabaseVersion": "POSTGRES_18"}`, // Missing instance
want: `{"error":"parameter \"instance\" is required"}`,
},
{
name: "missing parameter - targetDatabaseVersion",