github/genai-toolbox
1
0
Fork 0
mirror of https://github.com/googleapis/genai-toolbox.git synced 2026-01-23 22:38:14 -05:00
Code Issues Packages Projects Releases 14 Wiki Activity

refactor!: update Kind field to Type in source code (#2312)

Browse Source 
Update source code `Kind` to `Type`. It's only changes within our code.
Changes to yaml tag (that will affect users) will be done in later PRs.

This is a breaking change since it updates telemetry's span attribute
from `source_kind` to `source_type`.

Related #817

Future updates will include: 
* Updating a preprocessing function to convert config file from v1 to v2
* Update unmarshal function for ToolsFile to convert config file (test
will fail since the yaml tag is not yet updated).
* Update yaml tag (test will pass).
This commit is contained in:
Yuan Teoh
2026-01-20 11:20:41 -08:00
committed by GitHub
parent 8e0fb03483
commit aef539bcf3
516 changed files with 2174 additions and 2174 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/tools/cloudsql/cloudsqlcloneinstance/cloudsqlcloneinstance.go
View File

@@ -30,7 +30,7 @@ const kind string = "cloud-sql-clone-instance"
func init() {
if !tools.Register(kind, newConfig) {
panic(fmt.Sprintf("tool kind %q already registered", kind))
panic(fmt.Sprintf("tool type %q already registered", kind))
}
}
@@ -52,7 +52,7 @@ type compatibleSource interface {
// Config defines the configuration for the clone-instance tool.
type Config struct {
Name string `yaml:"name" validate:"required"`
Kind string `yaml:"kind" validate:"required"`
Type string `yaml:"kind" validate:"required"`
Description string `yaml:"description"`
Source string `yaml:"source" validate:"required"`
AuthRequired []string `yaml:"authRequired"`
@@ -61,8 +61,8 @@ type Config struct {
// validate interface
var _ tools.ToolConfig = Config{}
// ToolConfigKind returns the kind of the tool.
func (cfg Config) ToolConfigKind() string {
// ToolConfigType returns the kind of the tool.
func (cfg Config) ToolConfigType() string {
return kind
}
@@ -125,7 +125,7 @@ func (t Tool) ToConfig() tools.ToolConfig {
// Invoke executes the tool's logic.
func (t Tool) Invoke(ctx context.Context, resourceMgr tools.SourceProvider, params parameters.ParamValues, accessToken tools.AccessToken) (any, error) {
source, err := tools.GetCompatibleSource[compatibleSource](resourceMgr, t.Source, t.Name, t.Kind)
source, err := tools.GetCompatibleSource[compatibleSource](resourceMgr, t.Source, t.Name, t.Type)
if err != nil {
return nil, err
}
@@ -176,7 +176,7 @@ func (t Tool) Authorized(verifiedAuthServices []string) bool {
}
func (t Tool) RequiresClientAuthorization(resourceMgr tools.SourceProvider) (bool, error) {
source, err := tools.GetCompatibleSource[compatibleSource](resourceMgr, t.Source, t.Name, t.Kind)
source, err := tools.GetCompatibleSource[compatibleSource](resourceMgr, t.Source, t.Name, t.Type)
if err != nil {
return false, err
}