mirror of
https://github.com/googleapis/genai-toolbox.git
synced 2026-01-14 01:48:29 -05:00
0cd3f16f87
This PR fixes #1232 by allowing the `CLOUD_SQL_MYSQL_IP_TYPE` environment variable to control the connection type for the `cloud-sql-mysql` prebuilt tool, defaulting to "PUBLIC". **Changes:** * **`internal/prebuiltconfigs/tools/cloud-sql-mysql.yaml`:** Updated `ipType` to use `${CLOUD_SQL_MYSQL_IP_TYPE:PUBLIC}`. * **`internal/sources/cloudsqlmysql/cloud_sql_mysql.go`:** Removed `validate:"required"` from the `IPType` field in the `Config` struct to allow the default to be used when the env var is unset. * **Documentation:** Updated relevant documentation to reflect the new `CLOUD_SQL_MYSQL_IP_TYPE` environment variable usage. **Testing:** Built a local Docker image and tested on a GCE VM: * Setting `CLOUD_SQL_MYSQL_IP_TYPE="private"` connects via Private IP. * Setting `CLOUD_SQL_MYSQL_IP_TYPE="PUBLIC"` connects via Public IP. * Leaving `CLOUD_SQL_MYSQL_IP_TYPE` unset defaults to Public IP. All tests initialized the toolbox successfully. Fixes #1232 ## Description --- > Should include a concise description of the changes (bug or feature), it's > impact, along with a summary of the solution ## PR Checklist --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #1232 --------- Co-authored-by: Averi Kitsch <akitsch@google.com>