mirror of
https://github.com/googleapis/genai-toolbox.git
synced 2026-01-14 09:57:58 -05:00
## Description --- > This PR introduces a new observability tool that allows fetching system and query level metrics from the Cloud Monitoring API for AlloyDB instances. > > The key changes include: > - A new observability tool that can make authenticated requests to the monitoring API. > - Pre-built configurations in observability.yaml for fetching AlloyDB system and query metrics. > - Unit and integration tests for the new observability tool. > - List of metrics is fetched from the public documentation available https://cloud.google.com/alloydb/docs/reference/system-insights-metrics > - Manual testing is also done by locally running the server/tools and integrating with Gemini CLI ## Followup Changes --- > - Similar observability tools for Postgres, MySQL and SQLServer. > - Documentation around the tools. ## PR Checklist --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed CONTRIBUTING.md (https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a bug/issue (https://github.com/googleapis/langchain-google-alloydb-pg-python/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [] Appropriate docs were updated (if necessary) - [ ] Make sure to add ! if this involve a breaking change Tested Locally: <img width="4886" height="3068" alt="image" src="https://github.com/user-attachments/assets/774d0776-6c91-48aa-8d1a-64d84cfdbc75" /> <img width="4752" height="2778" alt="image" src="https://github.com/user-attachments/assets/839f099a-dd1a-410c-bbe4-9913603e5ff3" />
136 lines
3.3 KiB
Go
136 lines
3.3 KiB
Go
// Copyright 2025 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cloudmonitoring_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
yaml "github.com/goccy/go-yaml"
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/googleapis/genai-toolbox/internal/server"
|
|
"github.com/googleapis/genai-toolbox/internal/sources"
|
|
"github.com/googleapis/genai-toolbox/internal/sources/cloudmonitoring"
|
|
"github.com/googleapis/genai-toolbox/internal/testutils"
|
|
)
|
|
|
|
func TestParseFromYamlCloudMonitoring(t *testing.T) {
|
|
t.Parallel()
|
|
tcs := []struct {
|
|
desc string
|
|
in string
|
|
want server.SourceConfigs
|
|
}{
|
|
{
|
|
desc: "basic example",
|
|
in: `
|
|
sources:
|
|
my-cloud-monitoring-instance:
|
|
kind: cloud-monitoring
|
|
`,
|
|
want: map[string]sources.SourceConfig{
|
|
"my-cloud-monitoring-instance": cloudmonitoring.Config{
|
|
Name: "my-cloud-monitoring-instance",
|
|
Kind: cloudmonitoring.SourceKind,
|
|
UseClientOAuth: false,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
desc: "use client auth example",
|
|
in: `
|
|
sources:
|
|
my-cloud-monitoring-instance:
|
|
kind: cloud-monitoring
|
|
useClientOAuth: true
|
|
`,
|
|
want: map[string]sources.SourceConfig{
|
|
"my-cloud-monitoring-instance": cloudmonitoring.Config{
|
|
Name: "my-cloud-monitoring-instance",
|
|
Kind: cloudmonitoring.SourceKind,
|
|
UseClientOAuth: true,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tc := range tcs {
|
|
tc := tc
|
|
t.Run(tc.desc, func(t *testing.T) {
|
|
t.Parallel()
|
|
got := struct {
|
|
Sources server.SourceConfigs `yaml:"sources"`
|
|
}{}
|
|
// Parse contents
|
|
err := yaml.Unmarshal(testutils.FormatYaml(tc.in), &got)
|
|
if err != nil {
|
|
t.Fatalf("unable to unmarshal: %s", err)
|
|
}
|
|
if !cmp.Equal(tc.want, got.Sources) {
|
|
t.Fatalf("incorrect parse: want %v, got %v", tc.want, got.Sources)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFailParseFromYaml(t *testing.T) {
|
|
t.Parallel()
|
|
tcs := []struct {
|
|
desc string
|
|
in string
|
|
err string
|
|
}{
|
|
{
|
|
desc: "extra field",
|
|
in: `
|
|
sources:
|
|
my-cloud-monitoring-instance:
|
|
kind: cloud-monitoring
|
|
project: test-project
|
|
`,
|
|
err: `unable to parse source "my-cloud-monitoring-instance" as "cloud-monitoring": [2:1] unknown field "project"
|
|
1 | kind: cloud-monitoring
|
|
> 2 | project: test-project
|
|
^
|
|
`,
|
|
},
|
|
{
|
|
desc: "missing required field",
|
|
in: `
|
|
sources:
|
|
my-cloud-monitoring-instance:
|
|
useClientOAuth: true
|
|
`,
|
|
err: "missing 'kind' field for source \"my-cloud-monitoring-instance\"",
|
|
},
|
|
}
|
|
for _, tc := range tcs {
|
|
tc := tc
|
|
t.Run(tc.desc, func(t *testing.T) {
|
|
t.Parallel()
|
|
got := struct {
|
|
Sources server.SourceConfigs `yaml:"sources"`
|
|
}{}
|
|
// Parse contents
|
|
err := yaml.Unmarshal(testutils.FormatYaml(tc.in), &got)
|
|
if err == nil {
|
|
t.Fatalf("expect parsing to fail")
|
|
}
|
|
errStr := err.Error()
|
|
if errStr != tc.err {
|
|
t.Fatalf("unexpected error: got %q, want %q", errStr, tc.err)
|
|
}
|
|
})
|
|
}
|
|
}
|