mirror of
https://github.com/googleapis/genai-toolbox.git
synced 2026-02-05 20:54:56 -05:00
The `required` tag raises validation failure error when a boolean field is defined as `false`: ``` ERROR "unable to parse tool file at "mongodb_tools.yaml": unable to parse tool "insert-one-device" as kind "mongodb-insert-one": [2:12] Key: 'Config.Canonical' Error:Field validation for 'Canonical' failed on the 'required' tag\n 1 | authRequired: []\n> 2 | canonical: false\n ^\n 3 | collection: Device\n 4 | database: xiar\n 5 | description: Inserts a single new document into the Device collection. The 'data' parameter must be a string containing the JSON object to insert.\n 6 | " ``` All the `required` tags are removed from the boolean `canonical` field of the MongoDB tools. Unit tests are added.
174 lines
4.2 KiB
Go
174 lines
4.2 KiB
Go
// Copyright 2025 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package mongodbinsertone_test
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/googleapis/genai-toolbox/internal/tools/mongodb/mongodbinsertone"
|
|
|
|
yaml "github.com/goccy/go-yaml"
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/googleapis/genai-toolbox/internal/server"
|
|
"github.com/googleapis/genai-toolbox/internal/testutils"
|
|
)
|
|
|
|
func TestParseFromYamlMongoQuery(t *testing.T) {
|
|
ctx, err := testutils.ContextWithNewLogger()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
tcs := []struct {
|
|
desc string
|
|
in string
|
|
want server.ToolConfigs
|
|
}{
|
|
{
|
|
desc: "basic example",
|
|
in: `
|
|
tools:
|
|
example_tool:
|
|
kind: mongodb-insert-one
|
|
source: my-instance
|
|
description: some description
|
|
database: test_db
|
|
collection: test_coll
|
|
`,
|
|
want: server.ToolConfigs{
|
|
"example_tool": mongodbinsertone.Config{
|
|
Name: "example_tool",
|
|
Kind: "mongodb-insert-one",
|
|
Source: "my-instance",
|
|
AuthRequired: []string{},
|
|
Database: "test_db",
|
|
Collection: "test_coll",
|
|
Canonical: false,
|
|
Description: "some description",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
desc: "true canonical",
|
|
in: `
|
|
tools:
|
|
example_tool:
|
|
kind: mongodb-insert-one
|
|
source: my-instance
|
|
description: some description
|
|
database: test_db
|
|
collection: test_coll
|
|
canonical: true
|
|
`,
|
|
want: server.ToolConfigs{
|
|
"example_tool": mongodbinsertone.Config{
|
|
Name: "example_tool",
|
|
Kind: "mongodb-insert-one",
|
|
Source: "my-instance",
|
|
AuthRequired: []string{},
|
|
Database: "test_db",
|
|
Collection: "test_coll",
|
|
Canonical: true,
|
|
Description: "some description",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
desc: "false canonical",
|
|
in: `
|
|
tools:
|
|
example_tool:
|
|
kind: mongodb-insert-one
|
|
source: my-instance
|
|
description: some description
|
|
database: test_db
|
|
collection: test_coll
|
|
canonical: false
|
|
`,
|
|
want: server.ToolConfigs{
|
|
"example_tool": mongodbinsertone.Config{
|
|
Name: "example_tool",
|
|
Kind: "mongodb-insert-one",
|
|
Source: "my-instance",
|
|
AuthRequired: []string{},
|
|
Database: "test_db",
|
|
Collection: "test_coll",
|
|
Canonical: false,
|
|
Description: "some description",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tc := range tcs {
|
|
t.Run(tc.desc, func(t *testing.T) {
|
|
got := struct {
|
|
Tools server.ToolConfigs `yaml:"tools"`
|
|
}{}
|
|
// Parse contents
|
|
err := yaml.UnmarshalContext(ctx, testutils.FormatYaml(tc.in), &got)
|
|
if err != nil {
|
|
t.Fatalf("unable to unmarshal: %s", err)
|
|
}
|
|
if diff := cmp.Diff(tc.want, got.Tools); diff != "" {
|
|
t.Fatalf("incorrect parse: diff %v", diff)
|
|
}
|
|
})
|
|
}
|
|
|
|
}
|
|
|
|
func TestFailParseFromYamlMongoQuery(t *testing.T) {
|
|
ctx, err := testutils.ContextWithNewLogger()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
tcs := []struct {
|
|
desc string
|
|
in string
|
|
err string
|
|
}{
|
|
{
|
|
desc: "Invalid method",
|
|
in: `
|
|
tools:
|
|
example_tool:
|
|
kind: mongodb-insert-one
|
|
source: my-instance
|
|
description: some description
|
|
collection: test_coll
|
|
canonical: true
|
|
`,
|
|
err: `unable to parse tool "example_tool" as kind "mongodb-insert-one"`,
|
|
},
|
|
}
|
|
for _, tc := range tcs {
|
|
t.Run(tc.desc, func(t *testing.T) {
|
|
got := struct {
|
|
Tools server.ToolConfigs `yaml:"tools"`
|
|
}{}
|
|
// Parse contents
|
|
err := yaml.UnmarshalContext(ctx, testutils.FormatYaml(tc.in), &got)
|
|
if err == nil {
|
|
t.Fatalf("expect parsing to fail")
|
|
}
|
|
errStr := err.Error()
|
|
if !strings.Contains(errStr, tc.err) {
|
|
t.Fatalf("unexpected error string: got %q, want substring %q", errStr, tc.err)
|
|
}
|
|
})
|
|
}
|
|
|
|
}
|