mirror of
https://github.com/googleapis/genai-toolbox.git
synced 2026-02-06 05:04:58 -05:00
391cb5bfe8
## Summary - Added configurable query timeout to MySQL source configuration - Updated connection DSN to include readTimeout parameter - Added documentation and example usage - Added test coverage for queryTimeout configuration ## Test plan - [x] Added unit test for queryTimeout configuration parsing - [x] Updated documentation with queryTimeout field description - [x] Verified timeout parameter is correctly added to DSN when specified ## Caveat When queryTimeout is exceeded, we get an obscure error message ([screenshot](https://github.com/user-attachments/assets/fd292f91-328d-4ebc-9a87-2d92e9887300)): ``` unable to execute query: invalid connection ``` This seems to be a problem with the mysql-go library: https://stackoverflow.com/q/65253798/10720618 I tried to use [MAX_EXECUTION_TIME](https://dev.mysql.com/doc/refman/8.0/en/optimizer-hints.html#optimizer-hints-execution-time) but it didn't work as expected (my `sleep(MAX_EXECUTION_TIME+3)` query finished successfully after MAX_EXECUTION_TIME milliseconds) Any ideas on what can be done here? The error message is very misleading. My goal with adding timeouts is to communicate to the LLM when it has issued a slow query and force it to adjust (e.g. query indexes and write a more optimized query) but this defeats the purpose. --------- Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>