mirror of
https://github.com/googleapis/genai-toolbox.git
synced 2026-02-01 10:44:58 -05:00
8752e05ab6
## Description Implements the 'postgres-upgrade-precheck' tool to allow users to validate instance readiness for major version upgrades for CloudSQL PostgreSQL. This includes the tool implementation, unit tests for YAML parsing, integration tests for tool invocation, and documentation. The tool is also added to the CloudSQL PostgreSQL prebuilt set. TEST output: <img width="3406" height="1646" alt="image" src="https://github.com/user-attachments/assets/6abaa535-285d-4645-9dd3-7ebcd447d448" /> <img width="3532" height="1490" alt="image" src="https://github.com/user-attachments/assets/4d512af1-51fd-4187-b80f-be13198aba68" /> ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #1721 --------- Co-authored-by: Averi Kitsch <akitsch@google.com>
94 lines
2.7 KiB
Go
94 lines
2.7 KiB
Go
// Copyright 2025 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cloudsqlpgupgradeprecheck_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
yaml "github.com/goccy/go-yaml"
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/googleapis/genai-toolbox/internal/server"
|
|
"github.com/googleapis/genai-toolbox/internal/testutils"
|
|
"github.com/googleapis/genai-toolbox/internal/tools/cloudsqlpg/cloudsqlpgupgradeprecheck"
|
|
)
|
|
|
|
func TestParseFromYaml(t *testing.T) {
|
|
ctx, err := testutils.ContextWithNewLogger()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
tcs := []struct {
|
|
desc string
|
|
in string
|
|
want server.ToolConfigs
|
|
}{
|
|
{
|
|
desc: "basic precheck example",
|
|
in: `
|
|
tools:
|
|
precheck-upgrade-tool:
|
|
kind: postgres-upgrade-precheck
|
|
description: a precheck test description
|
|
source: some-admin-source
|
|
authRequired:
|
|
- https://www.googleapis.com/auth/cloud-platform
|
|
`,
|
|
want: server.ToolConfigs{
|
|
"precheck-upgrade-tool": cloudsqlpgupgradeprecheck.Config{
|
|
Name: "precheck-upgrade-tool",
|
|
Kind: "postgres-upgrade-precheck",
|
|
Description: "a precheck test description",
|
|
Source: "some-admin-source",
|
|
AuthRequired: []string{"https://www.googleapis.com/auth/cloud-platform"},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
desc: "precheck example with no auth",
|
|
in: `
|
|
tools:
|
|
precheck-upgrade-tool-no-auth:
|
|
kind: postgres-upgrade-precheck
|
|
description: a precheck test description no auth
|
|
source: other-admin-source
|
|
`,
|
|
want: server.ToolConfigs{
|
|
"precheck-upgrade-tool-no-auth": cloudsqlpgupgradeprecheck.Config{
|
|
Name: "precheck-upgrade-tool-no-auth",
|
|
Kind: "postgres-upgrade-precheck",
|
|
Description: "a precheck test description no auth",
|
|
Source: "other-admin-source",
|
|
AuthRequired: []string{},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tc := range tcs {
|
|
t.Run(tc.desc, func(t *testing.T) {
|
|
got := struct {
|
|
Tools server.ToolConfigs `yaml:"tools"`
|
|
}{}
|
|
// Parse contents
|
|
err := yaml.UnmarshalContext(ctx, testutils.FormatYaml(tc.in), &got)
|
|
if err != nil {
|
|
t.Fatalf("unable to unmarshal: %s", err)
|
|
}
|
|
if diff := cmp.Diff(tc.want, got.Tools); diff != "" {
|
|
t.Fatalf("incorrect parse: diff (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|