From 314225b9207d8a477e8572feb3ee5c815a403aaa Mon Sep 17 00:00:00 2001 From: d-millar <33498836+d-millar@users.noreply.github.com> Date: Thu, 18 Dec 2025 11:57:18 -0500 Subject: [PATCH] GP-6228: missed these GP-6228: change to >= --- .../src/main/help/help/topics/dbgeng/dbgeng.html | 2 +- .../Debugger-agent-gdb/src/main/help/help/topics/gdb/gdb.html | 2 +- .../src/main/help/help/topics/lldb/lldb.html | 2 +- Ghidra/Debug/Debugger-rmi-trace/DEVNOTES.txt | 2 -- .../TraceRmiLauncherServicePlugin.html | 2 +- GhidraDocs/GettingStarted.md | 2 +- GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.html | 2 +- GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.md | 2 +- 8 files changed, 7 insertions(+), 9 deletions(-) diff --git a/Ghidra/Debug/Debugger-agent-dbgeng/src/main/help/help/topics/dbgeng/dbgeng.html b/Ghidra/Debug/Debugger-agent-dbgeng/src/main/help/help/topics/dbgeng/dbgeng.html index b945279ff9..9596589755 100644 --- a/Ghidra/Debug/Debugger-agent-dbgeng/src/main/help/help/topics/dbgeng/dbgeng.html +++ b/Ghidra/Debug/Debugger-agent-dbgeng/src/main/help/help/topics/dbgeng/dbgeng.html @@ -48,7 +48,7 @@ diff --git a/Ghidra/Debug/Debugger-agent-gdb/src/main/help/help/topics/gdb/gdb.html b/Ghidra/Debug/Debugger-agent-gdb/src/main/help/help/topics/gdb/gdb.html index 045dd98e80..04415f321d 100644 --- a/Ghidra/Debug/Debugger-agent-gdb/src/main/help/help/topics/gdb/gdb.html +++ b/Ghidra/Debug/Debugger-agent-gdb/src/main/help/help/topics/gdb/gdb.html @@ -38,7 +38,7 @@ diff --git a/Ghidra/Debug/Debugger-agent-lldb/src/main/help/help/topics/lldb/lldb.html b/Ghidra/Debug/Debugger-agent-lldb/src/main/help/help/topics/lldb/lldb.html index 241c0c9d22..e56238173a 100644 --- a/Ghidra/Debug/Debugger-agent-lldb/src/main/help/help/topics/lldb/lldb.html +++ b/Ghidra/Debug/Debugger-agent-lldb/src/main/help/help/topics/lldb/lldb.html @@ -38,7 +38,7 @@ diff --git a/Ghidra/Debug/Debugger-rmi-trace/DEVNOTES.txt b/Ghidra/Debug/Debugger-rmi-trace/DEVNOTES.txt index f03c229e4e..48878e4415 100644 --- a/Ghidra/Debug/Debugger-rmi-trace/DEVNOTES.txt +++ b/Ghidra/Debug/Debugger-rmi-trace/DEVNOTES.txt @@ -117,8 +117,6 @@ That said, for unit testing, I've had to incorporate package installation as a @ There's probably a better way, and that way may also help with out-of-the-box support. Something like setting PYTHON_PATH before invoking the debugger? There's still the issue of installing protobuf, though. -And the version we use is not the latest, which may put users who already have protobuf in dependency hell. -We use version 3.20, while the latest is 4.something. According to protobuf docs, major versions are not guaranteed backward compatible. To upgrade, we'd also have to upgrade the Java side. diff --git a/Ghidra/Debug/Debugger-rmi-trace/src/main/help/help/topics/TraceRmiLauncherServicePlugin/TraceRmiLauncherServicePlugin.html b/Ghidra/Debug/Debugger-rmi-trace/src/main/help/help/topics/TraceRmiLauncherServicePlugin/TraceRmiLauncherServicePlugin.html index 1c53fda4d8..878af066e8 100644 --- a/Ghidra/Debug/Debugger-rmi-trace/src/main/help/help/topics/TraceRmiLauncherServicePlugin/TraceRmiLauncherServicePlugin.html +++ b/Ghidra/Debug/Debugger-rmi-trace/src/main/help/help/topics/TraceRmiLauncherServicePlugin/TraceRmiLauncherServicePlugin.html @@ -134,7 +134,7 @@ diff --git a/GhidraDocs/GettingStarted.md b/GhidraDocs/GettingStarted.md index 9c8e0871c7..6970f8a186 100644 --- a/GhidraDocs/GettingStarted.md +++ b/GhidraDocs/GettingStarted.md @@ -165,7 +165,7 @@ The Debugger now uses Python to connect to the host platform's native debuggers. a [supported](#minimum-requirements) version of Python and some additional packages. These packages are included in the distribution, but you may still install them from PyPI if you prefer: * psutil -* protobuf==3.20.3 +* protobuf>=3.20.3 * Pybag>=2.2.12 (for WinDbg support) Different native debuggers have varying requirements, so you do not necessarily have to install all diff --git a/GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.html b/GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.html index 0fbe63ac0a..d92af74851 100644 --- a/GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.html +++ b/GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.html @@ -287,7 +287,7 @@ the Python source over and add it to your PYTHONPATH.

Double-check that you have installed all the required packages and their dependencies. A common forgotten or incorrectly-versioned dependency is protobuf. We developed using -protobuf==3.20.3. Its “sdist” package is distributed with +protobuf==3.20.3, newer versions generally work fine. Its “sdist” package is distributed with Ghidra under Debugger-rmi-trace/pypkg/dist for your convenience.

It is also possible that gdb has embedded a different diff --git a/GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.md b/GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.md index d9461996a9..231cc0c455 100644 --- a/GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.md +++ b/GhidraDocs/GhidraClass/Debugger/B1-RemoteTargets.md @@ -126,7 +126,7 @@ If that doesn't work, then in the worst case, copy the Python source over and ad Double-check that you have installed all the required packages and their dependencies. A common forgotten or incorrectly-versioned dependency is `protobuf`. -We developed using `protobuf==3.20.3`. +We developed using `protobuf==3.20.3`, newer versions generally work fine. Its "sdist" package is distributed with Ghidra under `Debugger-rmi-trace/pypkg/dist` for your convenience. It is also possible that `gdb` has embedded a different version of the interpreter than the one that `python3` provides.