From ad158346ea465fc5dbcdf6156924cfc495d11e7b Mon Sep 17 00:00:00 2001 From: Christian Oliff <1212885+coliff@users.noreply.github.com> Date: Tue, 12 Apr 2022 10:54:41 +0900 Subject: [PATCH] update node version package.json to specify node 14.x and above (as support for Node 12.x ends very soon). https://nodejs.org/en/about/releases/ Update GitHub Actions to use Maintained and Active versions of Node. --- .github/workflows/build-dist.yaml | 2 +- .github/workflows/publish.yaml | 8 ++++---- .github/workflows/push-to-template.yaml | 2 +- .github/workflows/test.yaml | 2 +- package-lock.json | 3 +-- package.json | 3 +-- 6 files changed, 9 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build-dist.yaml b/.github/workflows/build-dist.yaml index c3292c70..5424d95a 100644 --- a/.github/workflows/build-dist.yaml +++ b/.github/workflows/build-dist.yaml @@ -30,7 +30,7 @@ jobs: node-version: ${{ matrix.node-version }} - run: npm install - run: npm run build - - name: commit + - name: commit uses: stefanzweifel/git-auto-commit-action@v4 with: commit_message: "[Bot] Update dist" diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index 9350ca4a..a7956099 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -15,9 +15,9 @@ jobs: - name: Get tag id: get_version run: echo ::set-output name=VERSION::$(echo $GITHUB_REF | cut -d / -f 3) - - name: Create Zip Folder + - name: Create Zip Folder working-directory: dist - run: zip -r ../html5-boilerplate_${{ steps.get_version.outputs.VERSION }}.zip ./ + run: zip -r ../html5-boilerplate_${{ steps.get_version.outputs.VERSION }}.zip ./ - name: Create Release id: create_release uses: actions/create-release@v1 @@ -29,7 +29,7 @@ jobs: draft: false prerelease: false - name: Upload Release Asset - id: upload-release-asset + id: upload-release-asset uses: actions/upload-release-asset@v1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -41,7 +41,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 12 + node-version: 16 registry-url: https://registry.npmjs.org/ - name: publish npm run: npm publish diff --git a/.github/workflows/push-to-template.yaml b/.github/workflows/push-to-template.yaml index 0622a2e7..f59a7cb9 100644 --- a/.github/workflows/push-to-template.yaml +++ b/.github/workflows/push-to-template.yaml @@ -38,4 +38,4 @@ jobs: user-name: 'roblarsen' user-email: rob@htmlcssjavascript.com commit-message: "The latest and greatest from HTML5 Boilerplate" - + diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 153e4265..69a2cd9d 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [12.x, 14.x] + node-version: [14.x, 16.x] steps: - name: Get npm cache directory id: npm-cache diff --git a/package-lock.json b/package-lock.json index e7d8d04d..267a8c47 100644 --- a/package-lock.json +++ b/package-lock.json @@ -33,8 +33,7 @@ "strip-json-comments": "^4.0.0" }, "engines": { - "node": ">=10", - "npm": ">=3" + "node": ">=14" } }, "node_modules/@ampproject/remapping": { diff --git a/package.json b/package.json index 27c20bfe..505451d3 100644 --- a/package.json +++ b/package.json @@ -45,8 +45,7 @@ "strip-json-comments": "^4.0.0" }, "engines": { - "node": ">=10", - "npm": ">=3" + "node": ">=14" }, "babel": { "presets": [