From d00a4b9fdadce8dc1992ce9b36c13eb9c1d3a9d8 Mon Sep 17 00:00:00 2001 From: Rob Larsen Date: Mon, 8 Apr 2024 16:22:49 -0400 Subject: [PATCH] node 18+ (#3104) * node 18+ * Remove LGTM mention (service is no longer available) --------- Co-authored-by: Christian Oliff --- .github/workflows/test.yml | 2 +- docs/about-this-repo.md | 2 +- package.json | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index aa1cec52..9983cf17 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [16.x, 18.x] + node-version: [18.x, 20.x] steps: - name: Get npm cache directory id: npm-cache diff --git a/docs/about-this-repo.md b/docs/about-this-repo.md index 3fbdbee7..e296ae45 100644 --- a/docs/about-this-repo.md +++ b/docs/about-this-repo.md @@ -50,8 +50,8 @@ Our branch protection rules are as follows: - We require a pull request (PR) with one approving reviewer to merge code - In addition to the PR and approving reviewer, we require three status checks to pass before code can be merged + _ Build with Node 20 _ Build with Node 18 - _ Build with Node 16 \* LGTM analysis: JavaScript - We _allow_ force pushes for project admins. While force pushes can create some head scratching moments for people who have cloned the repo and update before and after the force push, the ability to clean up the `HEAD` of a diff --git a/package.json b/package.json index ec61b620..226dc667 100644 --- a/package.json +++ b/package.json @@ -39,8 +39,8 @@ "strip-json-comments": "^5.0.1" }, "engines": { - "node": ">=16", - "npm": ">=8" + "node": ">=18", + "npm": ">=10" }, "h5bp-configs": { "directories": {