mirror of
https://github.com/farcasterxyz/hub-monorepo.git
synced 2026-01-14 15:47:57 -05:00
@farcaster/hub-nodejs@0.13.1
607 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Sanjay
|
be0e240eb9 |
chore: Release hub-nodejs 0.13.1 (#2568)
## Why is this change needed? Release hub-nodejs 0.13.1 ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the version of the `@farcaster/hub-nodejs` package from `0.13.0` to `0.13.1` and includes a changelog entry for the patch changes made. ### Detailed summary - Deleted the file `.changeset/nasty-eagles-grin.md`. - Updated `CHANGELOG.md` to include version `0.13.1` with a patch change for snapchain error codes. - Updated `packages/hub-nodejs/package.json` version from `0.13.0` to `0.13.1`. - Updated `apps/hubble/package.json` to reflect the new version `^0.13.1` for `@farcaster/hub-nodejs`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
b39166ec27 |
fix: Ensure snapchain error codes are passed through (#2567)
## Why is this change needed? Snapchain sends the error codes back using a different header name. Read that as well. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving error handling in the `hub-nodejs` package by ensuring that error codes from the snapchain are correctly passed through to the `HubError`. ### Detailed summary - Updated error handling in `packages/hub-nodejs/src/client.ts`. - Modified the way `HubError` is instantiated to use `hubErrorCode`, which retrieves error codes from both `err.metadata.get("errCode")` and `err.metadata.get("x-err-code")`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
9b0d11ccaf |
chore: Release snapchain patches (#2562)
## Why is this change needed? Release snapchain updates ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating package versions and changelogs across multiple modules in the `@farcaster` ecosystem, including new features and dependency updates. ### Detailed summary - Updated `@farcaster/core` version from `0.15.6` to `0.16.0`. - Updated `@farcaster/hub-nodejs` version from `0.10.x` to `0.13.0`. - Updated `@farcaster/hub-web` version from `0.9.5` to `0.9.6`. - Updated `@farcaster/shuttle` version from `0.6.13` to `0.6.14`. - Updated `@farcaster/hubble` version from `1.19.1` to `1.19.2`. - Added changelog entries for each module reflecting the updates. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
846336eaee |
feat: Update builders and examples for snapchain (#2560)
## Why is this change needed? Update builders to use dataBytes so messages work with snapchain ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the package versions and modifying various `HUB_URL` configurations to support the `snapchain` functionality, alongside some validation and message handling improvements. ### Detailed summary - Updated package versions for `@farcaster/hub-nodejs` and `@farcaster/core` to minor. - Changed `HUB_URL` in multiple examples to point to `juno.farcaster.xyz:3383`. - Enhanced validation by checking both `message.data` and `message.dataBytes`. - Updated message creation to use `dataBytes` for `snapchain` compatibility. - Adjusted signature handling to use `_unsafeUnwrap()`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Aditi Srinivasan
|
9c497b35f5 |
chore: release shuttle v0.6.13 (#2512)
Release shuttle v0.6.13 ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the version of the `@farcaster/shuttle` package from `0.6.12` to `0.6.13`, adds a new feature related to environment variables for `shuttle`, and removes an outdated changelog file. ### Detailed summary - Updated `@farcaster/shuttle` version from `0.6.12` to `0.6.13` in `package.json`. - Added a new feature: environment variables for consuming from `snapchain` in the changelog. - Deleted the `.changeset/wild-rabbits-tap.md` file. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Aditi Srinivasan
|
63eb140798 |
feat: add envvars to shuttle for consuming from snapchain (#2510)
For subscribing to the snapchain cluster, it's useful to have a longer subscribe rpc timeout given there isn't consistent activity on the cluster and it's required to use the standard (non-streaming) bulk rpcs. This feature adds config via envvars for these parameters. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on adding environment variables to the `shuttle` application for configuration, particularly for streaming RPCs and timeout settings. ### Detailed summary - Introduced `USE_STREAMING_RPCS_FOR_BACKFILL` and `SUBSCRIBE_RPC_TIMEOUT` environment variables in `env.ts`. - Modified the `constructor` in `MessageReconciliation` to accept a new parameter `useStreamingRpcs`. - Updated `establishStream` method call to conditionally execute based on `useStreamingRpcs`. - Adjusted the instantiation of `MessageReconciliation` in `reconcileFids` to include `USE_STREAMING_RPCS_FOR_BACKFILL`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Shane da Silva
|
73d5dac561 |
fix: Correct typo in Factory builder (#2507)
## Why is this change needed? Typo was breaking tests. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the use of `Factories.Ed25519PPublicKey` to `Factories.Ed25519PublicKey` in test files to ensure consistency and correctness in the handling of public key types. ### Detailed summary - In `apps/hubble/src/storage/db/message.test.ts`, changed `Factories.Ed25519PPublicKey.build()` to `Factories.Ed25519PublicKey.build()` in a test case. - In `packages/core/src/validations.test.ts`, updated `Factories.Ed25519PPublicKey.build()` to `Factories.Ed25519PublicKey.build()` in two instances where a message is created for validation testing. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Yauheni Kryshneu
|
ef80eb385c |
fix: update Twitter URL to x.com format (#2484)
Replaced the outdated Twitter URL (twitter) with the updated x.com
format (x) to align with the platform's rebranding.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR updates references from "twitter" to "x" across multiple files
to reflect the rebranding of Twitter to X.
### Detailed summary
- Updated `CHANGELOG.md` to change "twitter" to "x".
- In `message.ts` files (both `hub-nodejs` and `core`), modified the
comment for `TWITTER` from "Username of user on twitter" to "Username of
user on x".
- In `message.proto`, changed the comment for `USER_DATA_TYPE_TWITTER`
from "Username of user on twitter" to "Username of user on x".
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Maxim Evtush
|
cc2c9d9e7b |
fix typographical errors and improve code readability (#2483)
**This PR includes the following changes:**
1. Fixed typographical error in comment: changed `the` to `to`
2. Improved variable naming consistency for better code readability
3. Increased timeouts in `nightwatch` config to resolve test failures
**Changes made:**
- Fixed comment wording in `hubEventProcessor.ts`
- Updated variable names for consistency in
`validateOrRevokeMessagesJob.ts`
- Increased timeouts and retry attempts in `nightwatch` configuration
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on correcting typos in comments and variable names
related to time allocation in the `pruneMessagesJob.ts` and
`validateOrRevokeMessagesJob.ts` files, ensuring clarity and consistency
in the code.
### Detailed summary
- Corrected the comment in `hubEventProcessor.ts` from "consider" to "to
consider".
- Changed variable name `allotedTimeMs` to `allottedTimeMs` in:
- `pruneMessagesJob.ts`
- `validateOrRevokeMessagesJob.ts`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Fallengirl
|
0a92fa0bca |
Corrected the number index.ts (#2480)
Corrected the numbering for accuracy and consistency.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR updates the example number in the documentation comment of the
`index.ts` file within the `packages/hub-nodejs/examples/write-data`
directory.
### Detailed summary
- Changed the example number from 7 to 8 in the documentation comment.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Brawn
|
e4524eb219 |
fix: Fix error handling Update index.ts (#2476)
## Why is this change needed? The error handling in the userdata fetch block assumes the error object always has a `response` property, which isn't guaranteed. This can cause crashes if the error is unrelated to an HTTP request (e.g., network issues or code errors). I've updated the `console.error` statement to safely handle cases where `e.response` is undefined. Now it logs either the response data or the error message, preventing potential runtime errors. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR improves error handling in the `packages/hub-web/examples/profile/index.ts` file by making the error logging more robust. It adds a fallback to log the error message if the response data is not available. ### Detailed summary - Updated the error logging in the `catch` block. - Changed `console.error` to log `e.response?.data` or fallback to `e.message` if `e.response.data` is undefined. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Bryer
|
ba618b6484 |
chore: Fix typo in class name Update factories.ts (#2475)
## Why is this change needed? I noticed a typo in the class name `Ed25519PPublicKey` where an extra "P" was added. This doesn't align with the correct naming convention used in the codebase, particularly with the `Ed25519PublicKeyFactory` defined earlier. I've corrected the name to `Ed25519PublicKey` to ensure consistency and accuracy. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on correcting a naming inconsistency in the `packages/core/src/factories.ts` file by updating the key from `Ed25519PPublicKey` to `Ed25519PublicKey`. ### Detailed summary - Changed the key name from `Ed25519PPublicKey` to `Ed25519PublicKey` in the export list. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
georgehao
|
50cd650ff8 |
Fix typos (#2469)
## Why is this change needed? Fix some typos ## Changes: - Fixed typo: `Rasied` to `Raised` in `syncHealth.ts`. - Corrected `reuslt` to `result` in `userDataStore.ts`. - Changed `doesnt` to `doesn't` in `merkleTrie.test.ts`. - Fixed `propogate` to `propagate` in `logger.ts` and `hubble.ts`. - Corrected `Wether` to `Whether` in `validateOrRevokeMessagesJob.ts` and `hubble.ts`. - Fixed `trucated` to `truncated` in `main.rs`. - Changed `cound` to `count` in `multiPeerSyncEngine.test.ts`. - Corrected `succeds` to `succeeds` in `index.test.ts`. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on correcting typos and improving comments throughout the codebase for better clarity and readability. ### Detailed summary - Fixed typo: `Rasied` to `Raised` in `syncHealth.ts`. - Corrected `reuslt` to `result` in `userDataStore.ts`. - Changed `doesnt` to `doesn't` in `merkleTrie.test.ts`. - Fixed `propogate` to `propagate` in `logger.ts` and `hubble.ts`. - Corrected `Wether` to `Whether` in `validateOrRevokeMessagesJob.ts` and `hubble.ts`. - Fixed `trucated` to `truncated` in `main.rs`. - Changed `cound` to `count` in `multiPeerSyncEngine.test.ts`. - Corrected `succeds` to `succeeds` in `index.test.ts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Woolfgm
|
214dcd7793 |
Remove duplicate Snapshots Options section (#2471)
Changes: - Removed duplicate "Snapshots Options" section from CLI documentation as it already exists in the main options list. Before (appears twice): Snapshots Options: --enable-snapshot-to-s3 Enable daily snapshots to be uploaded to S3. (default: disabled) --s3-snapshot-bucket <bucket> The S3 bucket to upload snapshots to --disable-snapshot-sync Disable syncing from snapshots. (default: enabled) File changed: apps/hubble/www/docs/docs/cli.md Screenshot needed:  |
||
|
planetBoy
|
43b89fd1f5 |
replace castWithEmojiLinkAttachmnent - castWithEmojiLinkAttachment index.ts (#2451)
I reviewed the entire repository, no more typos found in docs.
Hope this helps streamline the project!
Best regards,
Bilogweb3
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on correcting a typo in the variable name from
`castWithEmojiLinkAttachmnent` to `castWithEmojiLinkAttachment` in the
`packages/hub-nodejs/examples/write-data/index.ts` file, ensuring
consistency and clarity in the code.
### Detailed summary
- Changed variable name from `castWithEmojiLinkAttachmnent` to
`castWithEmojiLinkAttachment` for consistency.
- Updated the corresponding push to `castResults` to reflect the
corrected variable name.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Bilog WEB3
|
90a073d765 |
doc: Fix typo Update factories.ts (#2450)
I reviewed the entire repository, no more typos found in docs.
Hope this helps streamline the project!
Best regards,
Bilogweb3
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on renaming a public key factory in the codebase for
clarity and consistency.
### Detailed summary
- Renamed `Ed25519PPublicKeyFactory` to `Ed25519PublicKeyFactory` in
`packages/core/src/factories.ts`.
- Updated references to the factory in the `SignerEventBodyFactory` and
`Factories` export to match the new name.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Bob
|
47f5e7d41d |
Fixed typos and improved clarity in documentation (#2455)
Changes made:
typos - types ( Correcting a typo to the intended word)
LocalACcount - LocalAccount (Fixing the capitalization error to match
the proper format)
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on correcting typos in test descriptions and
documentation related to the `getStoreLimit` function and the
`Eip712Signer` class.
### Detailed summary
- Changed the test description from "multiple unit typos" to "multiple
unit types" in `packages/core/src/limits.test.ts`.
- Corrected "LocalACcount" to "LocalAccount" in
`packages/hub-nodejs/docs/signers/ViemLocalEip712Signer.md`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
teenager-ETH
|
ec23c0af8e |
Fix Typos in Documentation and Tests (#2460)
# Fix Typos in Documentation and Tests
## Summary
This pull request addresses minor typos in the following files:
1. `apps/hubble/src/test/e2e/gossipNetworkBundle.test.ts`
2. `packages/hub-nodejs/docs/signers/EthersV5Eip712Signer.md`
## Changes Made
### 1. `gossipNetworkBundle.test.ts`
- Fixed a typo in the comment:
- From: "beacuse"
- To: "because"
### 2. `EthersV5Eip712Signer.md`
- Fixed a typo in the comment:
- From: "can't erro"
- To: "can't error"
## Testing
These changes only affect comments and do not impact the functionality
of the code. No new tests were added as the code logic remains
unchanged.
## Checklist
- [x] Followed the [contributing guidelines](link-to-guidelines).
- [x] Verified changes locally.
- [x] Added clear descriptions and comments.
---
Thank you for reviewing this PR! Let me know if there’s anything else to
address.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on correcting minor typographical errors in comments
within the documentation and test files related to the
`EthersV5Eip712Signer` and `gossipNetworkBundle`.
### Detailed summary
- Fixed a typo in the comment for `blockHashBytes` in
`packages/hub-nodejs/docs/signers/EthersV5Eip712Signer.md`.
- Corrected a typo in the comment regarding invalid bundle gossiping in
`apps/hubble/src/test/e2e/gossipNetworkBundle.test.ts`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
CODe
|
a4c5f2e7af |
Fix typo Update CHANGELOG.md (#2464)
# Fix Typo in CHANGELOG.md ## Summary of Changes - Corrected a typo: "endoint" to "endpoint" in the `packages/core/CHANGELOG.md` file. --- ## Additional Notes This is a minor documentation update and does not affect the functionality of the project. Please review and merge at your convenience. Thank you! 😊 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on a fix in the `http` endpoint's response behavior, ensuring it returns a "not found" status instead of an internal database error. ### Detailed summary - Fixed the `http` endpoint to return "not found" instead of an internal database error. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
futreall
|
5602bf180a |
chore: fix duplicate errors.ts (#2448)
Duplicate "if" in error message description.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on improving documentation clarity and correcting a
comment in the codebase.
### Detailed summary
- Updated the wording in `monitoring.md` to change "writeable" to
"writable".
- Corrected a comment in `errors.ts` by removing the redundant "if" in
"if if error message".
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
CrazyFrog
|
0fd5f3591d |
Fix incorrect type reference and enum value in Events.md (#2444)
Changes in packages/hub-nodejs/docs/Events.md:
1. Fixed IdRegistryEvent type reference:
- Old: [`NameRegistryEventType`]()
- New: [`IdRegistryEventType`](#idregistryeventtype)
2. Fixed NameRegistryEventType enum value:
- Changed NAME_REGISTRY_EVENT_TYPE_RENEW from 1 to 2
Why:
- Corrects incorrect type reference for proper documentation linking
- Fixes duplicate enum value to maintain proper enumeration consistency
<!-- start pr-codex -->
---
## PR-Codex overview
This PR updates the documentation for events related to the Farcaster
network, specifically changing event types and correcting the associated
values in the `NameRegistryEvent` section.
### Detailed summary
- Changed the type of event from `NameRegistryEventType` to
`IdRegistryEventType`.
- Updated the value for `NAME_REGISTRY_EVENT_TYPE_RENEW` from `1` to
`2`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
savvasmoke
|
584f5f2493 |
Correcting Invalid Links with Valid URLs (#2435)
### Replacing not working links to working **Before:**  **After:**  <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the documentation for several signers in the `hub-nodejs` package, specifically changing the links to the `Builders` documentation from relative URLs to absolute URLs. ### Detailed summary - Updated link to `Builders` documentation in `NobleEd25519Signer.md` - Updated link to `Builders` documentation in `ViemLocalEip712Signer.md` - Updated link to `Builders` documentation in `EthersV5Eip712Signer.md` - Updated link to `Builders` documentation in `EthersEip712Signer.md` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Viacheslav
|
03457c2b2b |
documentation(hub-web): Added getFnameFromFid to readme (#2433)
## Why is this change needed? Since changes were requested in docs (https://github.com/farcasterxyz/docs/issues/54), I have made a PR to update Farcaster's docs (https://github.com/farcasterxyz/docs/pull/356), thus decided to update the readme file. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [ ] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR adds a new function for retrieving a user's first name using their FID from the `HubRpcClient`. ### Detailed summary - Introduced a new function `getFnameFromFid`. - The function takes `fid` (number) and `client` (`HubRpcClient`) as parameters. - It retrieves user data of type `UserDataType.FNAME`. - Returns the user's first name or an empty string if not found. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Donny
|
ccfb458b04 |
docs: Fix typo Update README.md (#2428)
## Why is this change needed? <img width="852" alt="Снимок экрана 2024-12-10 в 19 00 33" src="https://github.com/user-attachments/assets/6a803a7a-ff1c-43bb-972f-c78318266766"> The problem lies in the use of "Cast's," which could be unclear or grammatically incorrect in this context. The possessive form of "Cast" may not be necessary here, and it could be better to rewrite it as: `console.log(`The first cast's text is ${response.messages[0].data.castAddBody.text}`);` ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the wording in a log message for clarity. ### Detailed summary - Changed the log message from `First Cast's text is` to `The first cast's text is` to improve readability and consistency in the console output. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
dependabot[bot]
|
08521b1746 |
chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /packages/hub-nodejs/examples/hello-world (#2425)
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md">cross-spawn's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/moxystudio/node-cross-spawn/compare/v7.0.5...v7.0.6">7.0.6</a> (2024-11-18)</h3> <h3>Bug Fixes</h3> <ul> <li>update cross-spawn version to 7.0.5 in package-lock.json (<a href=" |
||
|
Sanjay
|
926f53547d |
chore: Release shuttle 0.6.12 (#2424)
## Why is this change needed? Release shuttle with revert for reconciliation issue. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the version of the `@farcaster/shuttle` package from `0.6.11` to `0.6.12`, along with a changelog entry that documents a specific feature revert. ### Detailed summary - Updated `version` of `@farcaster/shuttle` from `0.6.11` to `0.6.12`. - Added changelog entry for version `0.6.12` noting the revert of the feature "Support deleting messages on DB that are missing on hub" (#2341). > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Cypher Pepe
|
29f5796e55 |
docs: documentation typos in Client.md and Events.md (#2420)
## Why is this change needed? This PR addresses minor typographical errors in the documentation to improve accuracy and readability: - **File: `Client.md`** - Fixed the incorrect reference `geSSLHubRpcClient` to `getSSLHubRpcClient` in the example code. - **File: `Events.md`** - Corrected the grammatical error by changing "an NameRegistryEvent" to "a NameRegistryEvent." These corrections enhance clarity and ensure the examples are error-free for developers using the documentation. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard. - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets). - [ ] PR has been tagged with a change label(s) (e.g., documentation, feature, bugfix, or chore). - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on correcting a function name in the import statement and making a minor grammatical adjustment in the documentation. ### Detailed summary - Changed the import from `geSSLHubRpcClient` to `getSSLHubRpcClient` in `packages/hub-nodejs/docs/Client.md`. - Updated the documentation in `packages/hub-nodejs/docs/Events.md` by adding a space before "Emit" in the description of `MergeNameRegistry`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Ty Book
|
a302bcd165 |
feat(shuttle): Revert unsafe "Support deleting messages on DB that are missing on hub" #2341 (#2422)
Reverts farcasterxyz/hub-monorepo#2341 We found this to be a fundamentally flawed action to take on messages missing in the hub. Reverting the change to not mislead other Shuttle users. Why is this unsafe? Imagine a simple Shuttle-powered app with a `links` table written to and deleted from by its `handleMessageMerge` method. Then imagine this series of Farcaster messages submitted to the network: 1. LINK_ADD: FID 123 follows FID 234 2. LINK_REMOVE: FID 123 unfollows FID 234 3. LINK_ADD: FID 123 refollows FID 234 Obviously the correct final `links` table state should be FID 123 following FID 234. But with my changes that I'm reverting here, this won't be the case. The hubs will eventually delete message 1, meaning Shuttle's reverse reconciliation would ultimately run `handleMessageMerge()` with a `state` arg of `"deleted"` on message 1. This means the `links` table would have its row deleted that signifies FID 123 following FID 234, regardless of message 3. I think it might be safe in general to have this `onDbMessage()` callback do something like hard delete missing-in-hub messages from the `messages` table to keep its disk usage in check, but calling into the app to have it perform all downstream deletion processing of the message like this isn't safe. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on reverting a previous change that allowed for the deletion of messages from the database if they were missing on the hub. It simplifies the `handleMissingMessage` method by removing the conditional check for `missingInHub`. ### Detailed summary - Reverted feature: "Support deleting messages on DB that are missing on hub". - Modified `handleMissingMessage` method in `hubEventProcessor.ts` to remove the `missingInHub` parameter. - Updated calls to `handleMissingMessage` in `app.ts` to reflect the removal of the `missingInHub` argument. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Maks
|
c02ef4973e |
Fix documentation typos and grammar (#2410)
> Changes:
> 1. In packages/hub-nodejs/docs/Client.md:
- Changed "quick" to "quirk"
- Reason: The word "quick" (meaning fast/rapid) was incorrectly used
where "quirk" (meaning peculiarity/oddity) was intended when describing
protobuf-generated types behavior.
> 2. In packages/hub-nodejs/docs/Client.md:
- Changed "Message are" to "Messages are"
- Reason: Fixed subject-verb agreement as "Messages" is plural and
requires the plural verb form "are".
> 3. In protobufs/README.md:
- Changed "Docs for the protobufs is" to "Docs for the protobufs are"
- Reason: Fixed subject-verb agreement as "Docs" (documentation) is
treated as plural in this context and requires the plural verb form
"are".
These changes improve the documentation's readability and grammatical
correctness without altering any technical content.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on improving documentation clarity in the
`protobufs/README.md` and `packages/hub-nodejs/docs/Client.md` files,
correcting minor typographical errors and ensuring consistency in
language.
### Detailed summary
- Fixed a minor typographical error in `protobufs/README.md` regarding
the documentation description.
- Corrected "quick" to "quirk" in `packages/hub-nodejs/docs/Client.md`.
- Changed "Docs for the protobufs is" to "Docs for the protobufs are"
for grammatical accuracy in `protobufs/README.md`.
- Changed "Message are" to "Messages are" in
`packages/hub-nodejs/docs/Client.md` for grammatical accuracy.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Danil
|
dc34dc8dca |
Fix grammatical errors and typo in code (#2411)
Fixed:
Changed "Commands must" to "Commands must be" for grammatical
correctness.
Corrected "import { geSSLHubRpcClient" to "import { getSSLHubRpcClient"
to fix the typo.
Why it's useful:
These changes fix grammatical errors and a typo, ensuring the code is
syntactically correct and easier to read.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on correcting a typo in the documentation and updating a
function name in the code.
### Detailed summary
- In `apps/hubble/www/docs/docs/cli.md`, the phrase "Commands must
invoked" was corrected to "Commands must be invoked".
- In `packages/hub-nodejs/docs/Client.md`, the function name
`geSSLHubRpcClient` was updated to `getSSLHubRpcClient`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Qvkare
|
686aeb7075 |
fix: typo corrections and path updates (#2415)
## Why is this change needed? Typographical errors in variable names, comments, and documentation, such as "recieved" instead of "received" and incorrect paths in examples, have been corrected to ensure clarity, consistency, and improved developer experience. ### Key Changes: 1. Replaced all instances of "recievedMessages" with "receivedMessages" for correct spelling. 2. Updated code comments and logs to reflect the corrected spelling: - `recievedMessages.size` → `receivedMessages.size` - Comments updated for clarity: "recieved" → "received." 3. Corrected a typo in error logging: `errMessaeg` → `errMessage`. 4. Fixed a typo in a code comment within `shuttle/index.ts`: - "gurantees" → "guarantees." - "recieved" → "received." ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review:_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard. - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets). - [x] PR has been tagged with a change label(s) (i.e., documentation, feature, bugfix, or chore). - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on correcting spelling errors related to the word "received" across multiple files, enhancing code clarity and consistency. ### Detailed summary - Fixed spelling of `errMessaeg` to `errMessage` in `dbSnapshotBackupJob.ts`. - Corrected comments and variable names from `recievedMessages` to `receivedMessages` in `gossipProfileWorker.ts` and `gossipProfileWorker.js`. - Updated console log messages for consistency in spelling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
rebustron
|
45e7ae1625 |
fix: typo correction validations.test.ts (#2405)
### Why is this change needed? Corrected a typographical error in the test description. Changed "inpt" to "input" in `validations.test.ts`. This fix improves code readability and consistency. --- ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard. - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets). - [ ] PR has been tagged with a change label(s) (i.e., documentation, feature, bugfix, or chore). - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. --- ## Commits - **Commit:** `typo validations.test.ts` - Changed "inpt" to "input" in the file `packages/core/src/validations.test.ts`. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on correcting a typo in a test description within the `validations.test.ts` file. ### Detailed summary - Changed the test description from `"succeeds with valid string inpt"` to `"succeeds with valid string input"` in the `test` function. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
futreall
|
b69cb8f302 |
fix typos in documentation files (#2398)
## Why is this change needed? This change is necessary to enhance documentation consistency, improve accuracy in code comments, and provide users with a clear understanding of the project’s structure and usage guidelines. Updating these files ensures that developers and contributors can navigate and utilize the codebase more effectively, reducing potential errors and miscommunications. These improvements directly support maintaining high-quality standards and accessibility in the Hubble ecosystem, benefiting both new and experienced users. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on fixing typos and improving documentation across various files in the project, enhancing clarity and consistency in language. ### Detailed summary - Fixed typo in `CHANGELOG.md` regarding "unexpectedly". - Updated "Go lang" to "Golang" in `CHANGELOG.md`. - Corrected phrasing in `feature.md`. - Standardized "Nodejs" to "Node.js" in multiple files. - Clarified "Fids" to "FIDs" in `Messages.md`. - Improved description in `README.md` for consistency. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
compusophy
|
df0b62987f |
Update path in README.md (#2403)
## Why is this change needed? The existing README.md for the write-data example contains an incorrect path, instructing users to navigate to the 'make-cast' instead of 'write-data'. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [ ] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the instructions in the `README.md` file for the `write-data` example in the `hub-nodejs` package. It corrects the navigation command and ensures the instructions are accurate for users. ### Detailed summary - Changed navigation command from `cd packages/hub-nodejs/examples/make-cast` to `cd packages/hub-nodejs/examples/write-data`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
15d0aec9ba |
chore: Release shuttle version (#2400)
## Why is this change needed? Release shuttle ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the version of the `@farcaster/shuttle` package from `0.6.10` to `0.6.11`, along with a corresponding entry in the `CHANGELOG.md` to document a bug fix related to using the `statsd` host from the environment. ### Detailed summary - Updated version of `@farcaster/shuttle` from `0.6.10` to `0.6.11` in `packages/shuttle/package.json`. - Added changelog entry for version `0.6.11` documenting a fix for using `statsd` host from the environment. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
d34a86df19 |
fix(shuttle): Use statsd host from env (#2399)
## Why is this change needed? Use statsd host from env for shuttle ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `statsd` configuration in the `shuttle` package to use the `STATSD_HOST` environment variable for the host address, enhancing flexibility and avoiding hardcoded values. ### Detailed summary - Updated `host` in `statsd` configuration from a hardcoded IP (`"127.0.0.1"`) to use `process.env["STATSD_HOST"]` with a fallback to `"127.0.0.1"`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Aditi Srinivasan
|
66d6af9e59 |
chore: release hubble v1.16.3 and shuttle v0.6.10 (#2397)
Release hubble v1.16.3 and shuttle v0.6.10. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on updating version numbers and changelogs for the `@farcaster/hubble` and `@farcaster/shuttle` packages, along with some minor code adjustments. ### Detailed summary - Updated `@farcaster/hubble` version from `1.16.2` to `1.16.3`. - Added changelog entry for `1.16.3` with a log tag standardization change. - Updated `@farcaster/shuttle` version from `0.6.9` to `0.6.10`. - Added changelog entry for `0.6.10` regarding RPC fallback improvements. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
07aaf852ec |
Fix: Fallback to RPC in more cases when reconcile stream errors (#2396)
## Why is this change needed?
In cases like this, we're not falling back to the RPC
```
{"jobName":"reconcile","jobId":"9273216","reason":"Unable to get all casts for FID 652934: server timeout","errorName":"Error","errorMessage":"Unable to get all casts for FID 652934: server timeout","errorStack":"Error: Unable to get all casts for FID 652934: server timeout\n at
MessageReconciliation.getAllCastMessagesByFidInBatchesOf (file:///app/node_modules/@farcaster/shuttle/dist/index.mjs:1060:15)\n at runNextTicks (node:internal/process/task_queues:60:5)\n at process.processTimers (node:internal/timers:511:9)\n at async MessageReconciliation.allHubMessagesOfTypeForFid (file:///app/node_modules/@farcaster/shuttle/dist/index.mjs:980:22)\n at async MessageReconciliation.reconcileMessagesOfTypeForFid (file:///app/node_modules/@farcaster/shuttle/dist/index.mjs:918:22)\n at async MessageReconciliation.reconcileMessagesForFid (file:///app/node_modules/@farcaster/shuttle/dist/index.mjs:913:7)\n at App.reconcileFids (/app/src/shuttle.ts:132:13)\n at Worker.Worker.autorun (/app/src/worker.ts:21:9)\n at Worker.processJob (/app/node_modules/bullmq/src/classes/worker.ts:776:22)\n at Worker.retryIfFailed (/app/node_modules/bullmq/src/classes/worker.ts:982:16)"}
```
## Merge Checklist
_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_
- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [x] PR has a
[changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets)
- [x] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [ ] PR includes
[documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs)
if necessary.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on improving error handling in the `reconcile` process
by enhancing the fallback mechanism to RPC in more scenarios when stream
errors occur, and temporarily skipping a test for unresponsive server
requests.
### Detailed summary
- Updated the `shuttle.integration.test.ts` file to skip the test for
unresponsive server requests.
- Enhanced the `messageReconciliation.ts` file to log a warning when a
stream fetch times out and fall back to RPC.
- Added a cancellation mechanism to prevent hanging connections.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Pratik Agarwal
|
2cc08d9a4d |
Fname register signature fix (#2384)
## Why is this change needed?
There was a bug due to which fname registration was failing on example
package `hello-world`. The PR fixes this.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a new function for creating user name proof claims
and updates the way user name proof signatures are generated and
processed in the `registerFname` function. It also adds a utility
function for converting bytes to hex.
### Detailed summary
- Added `makeUserNameProofClaim` function import.
- Introduced `bytesToHex` function import.
- Updated `registerFname` to use `await signer.signUserNameProofClaim`
with `makeUserNameProofClaim`.
- Changed signature processing to use `bytesToHex` for
`userNameProofSignature.value`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Sanjay
|
3ae52bc50c |
chore: Release shuttle (#2395)
## Why is this change needed? Release shuttle 0.6.9 ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the version of the `@farcaster/shuttle` package from `0.6.8` to `0.6.9` and includes notable changes in the changelog. ### Detailed summary - Updated `version` in `packages/shuttle/package.json` from `0.6.8` to `0.6.9`. - Added a new section for `0.6.9` in `packages/shuttle/CHANGELOG.md`: - `feat(shuttle)`: Pipe `connectionTimeout` argument through `EventStreamHubSubscriber`. - `chore`: Add event timestamp metric for event subscription monitoring. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
dependabot[bot]
|
57a87beebd |
chore(deps): bump elliptic from 6.5.7 to 6.6.0 in /packages/hub-nodejs/examples/hello-world (#2392)
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.7 to 6.6.0. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
4f6cfaaa0a |
chore(deps): bump axios from 1.6.0 to 1.7.4 in /packages/hub-web/examples/feed (#2376)
Bumps [axios](https://github.com/axios/axios) from 1.6.0 to 1.7.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.7.4</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>sec:</strong> CVE-2024-39338 (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://redirect.github.com/axios/axios/issues/6543">#6543</a>) (<a href=" |
||
|
Aditi Srinivasan
|
999821063d |
chore: add event timestamp metric for event subscription monitoring (#2391)
This will help us understand if hub are sending events from far back in time. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces an event timestamp metric for monitoring event subscriptions in the `EventStreamHubSubscriber` class. It enhances the telemetry by adding the earliest event timestamp and associates the metrics with the `hub` property. ### Detailed summary - Added a new private property `hub` to store the hub client host. - Extracted the earliest event timestamp using `extractEventTimestamp` and recorded it with `statsd.gauge`. - Updated existing metrics to include the `hub` property for better context in monitoring. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Ty Book
|
a9c45a3dfc |
feat(shuttle): Pipe connectionTimeout arg through EventStreamHubSubscriber (#2382)
## Why is this change needed? Follow-up to https://github.com/farcasterxyz/hub-monorepo/pull/2367. I missed piping through BaseHubSubscriber's new `connectionTimeout` param through to EventStreamHubSubscriber, which means `connectionTimeout` isn't really configurable for streaming right now like it should be. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on adding a new optional parameter, `connectionTimeout`, to the `EventStreamHubSubscriber` class, allowing for better control over connection timeouts. ### Detailed summary - Added `connectionTimeout?: number` as an optional parameter in the constructor of `EventStreamHubSubscriber`. - Updated the call to `super` in the constructor to include the new `connectionTimeout` argument. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Cassandra Heart
|
8c1364041f |
chore: bump version (#2387)
## Why is this change needed? Bumping version to release social verifications ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the versioning of several packages, enhancing support for Twitter and GitHub usernames, and making various dependency updates across the `@farcaster` ecosystem. ### Detailed summary - Updated `@farcaster/core` version from `0.15.5` to `0.15.6`. - Added support for Twitter and GitHub usernames in `@farcaster/core`. - Updated `@farcaster/hub-nodejs` version from `0.12.6` to `0.12.7`. - Updated `@farcaster/hub-web` version from `0.9.4` to `0.9.5`. - Updated `@farcaster/hubble` version from `1.16.1` to `1.16.2`. - Placed backups in a dedicated directory in `@farcaster/hub`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Cassandra Heart
|
913c0f6766 |
feat: support social verifications for twitter and github (#2370)
## Why is this change needed? Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces support for validating `twitter` and `github` usernames in the system. It adds new constants, validation functions, and test cases to ensure username formats comply with specified rules. ### Detailed summary - Added constants `USER_DATA_TYPE_TWITTER` and `USER_DATA_TYPE_GITHUB` in `message.proto`. - Implemented validation functions `validateTwitterUsername` and `validateGithubUsername` in `validations.ts`. - Added regex patterns for Twitter and GitHub usernames. - Created test cases for Twitter username validation in `validations.test.ts`. - Updated functions to handle new user data types in `userDataTypeFromJSON` and `userDataTypeToJSON` across several files. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
dependabot[bot]
|
a56ed67fe8 |
chore(deps): bump axios from 1.6.0 to 1.7.4 in /packages/hub-web/examples/profile (#2373)
Bumps [axios](https://github.com/axios/axios) from 1.6.0 to 1.7.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.7.4</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>sec:</strong> CVE-2024-39338 (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://redirect.github.com/axios/axios/issues/6543">#6543</a>) (<a href=" |
||
|
dependabot[bot]
|
90e72971ff |
chore(deps): bump secp256k1 from 4.0.3 to 4.0.4 in /packages/hub-nodejs/examples/contract-signatures (#2374)
Bumps [secp256k1](https://github.com/cryptocoinjs/secp256k1-node) from 4.0.3 to 4.0.4. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
9a5f0fcb52 |
chore(deps): bump secp256k1 from 5.0.0 to 5.0.1 in /packages/hub-nodejs/examples/hello-world (#2372)
Bumps [secp256k1](https://github.com/cryptocoinjs/secp256k1-node) from 5.0.0 to 5.0.1. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Sanjay
|
3955dba3e0 |
chore: Release 1.16 (#2369)
## Why is this change needed? Release 1.16 ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating version numbers and changelogs for the `@farcaster/hub-nodejs` and `@farcaster/shuttle` packages, along with modifications to the `FARCASTER_VERSION` in the `hubble.ts` file. ### Detailed summary - Updated `@farcaster/hub-nodejs` version from `0.12.5` to `0.12.6`. - Added `createDefaultMetadataKeyInterceptor` in `CHANGELOG.md`. - Updated `@farcaster/shuttle` version from `0.6.7` to `0.6.8`. - Parametrized hub connection timeouts for `HubSubscriber` and `MessageReconciliation`. - Updated `@farcaster/hubble` version from `1.15.7` to `1.16.0`. - Changed `FARCASTER_VERSION` from `2024.9.4` to `2024.10.16`. - Added new version `2024.10.16` to `FARCASTER_VERSIONS_SCHEDULE`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |