From b467475e38bb9a0de4fedcd26e0769b87293c8f7 Mon Sep 17 00:00:00 2001 From: Sheen Capadngan Date: Thu, 18 Dec 2025 00:37:06 +0800 Subject: [PATCH 1/2] misc: removed unnecessary secret reminder deletion --- backend/src/services/project/project-service.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/backend/src/services/project/project-service.ts b/backend/src/services/project/project-service.ts index a48daefdc2..55308bccb4 100644 --- a/backend/src/services/project/project-service.ts +++ b/backend/src/services/project/project-service.ts @@ -521,14 +521,6 @@ export const projectServiceFactory = ({ await userDAL.deleteById(projectGhostUser.id, tx); } - await fnDeleteProjectSecretReminders(project.id, { - secretDAL, - secretV2BridgeDAL, - reminderService, - projectBotService, - folderDAL - }); - return delProject; }); From 71845759b6745c6fefeb2083726eb1f90c0a461b Mon Sep 17 00:00:00 2001 From: Sheen Capadngan Date: Fri, 19 Dec 2025 02:50:12 +0800 Subject: [PATCH 2/2] misc: addressed lint --- backend/src/server/routes/index.ts | 4 ---- backend/src/services/project/project-service.ts | 13 ------------- 2 files changed, 17 deletions(-) diff --git a/backend/src/server/routes/index.ts b/backend/src/server/routes/index.ts index 640c4e9a49..5b46633b5f 100644 --- a/backend/src/server/routes/index.ts +++ b/backend/src/server/routes/index.ts @@ -1361,10 +1361,7 @@ export const registerRoutes = async ( permissionService, projectDAL, projectSshConfigDAL, - secretDAL, - secretV2BridgeDAL, projectQueue: projectQueueService, - projectBotService, userDAL, projectEnvDAL, orgDAL, @@ -1391,7 +1388,6 @@ export const registerRoutes = async ( microsoftTeamsIntegrationDAL, projectTemplateService, smtpService, - reminderService, notificationService, membershipGroupDAL, membershipIdentityDAL, diff --git a/backend/src/services/project/project-service.ts b/backend/src/services/project/project-service.ts index 55308bccb4..63424b1160 100644 --- a/backend/src/services/project/project-service.ts +++ b/backend/src/services/project/project-service.ts @@ -68,16 +68,11 @@ import { NotificationType } from "../notification/notification-types"; import { TOrgDALFactory } from "../org/org-dal"; import { TPkiAlertDALFactory } from "../pki-alert/pki-alert-dal"; import { TPkiCollectionDALFactory } from "../pki-collection/pki-collection-dal"; -import { TProjectBotServiceFactory } from "../project-bot/project-bot-service"; import { TProjectEnvDALFactory } from "../project-env/project-env-dal"; import { TProjectMembershipDALFactory } from "../project-membership/project-membership-dal"; import { getPredefinedRoles } from "../project-role/project-role-fns"; -import { TReminderServiceFactory } from "../reminder/reminder-types"; import { TRoleDALFactory } from "../role/role-dal"; -import { TSecretDALFactory } from "../secret/secret-dal"; -import { fnDeleteProjectSecretReminders } from "../secret/secret-fns"; import { ROOT_FOLDER_NAME, TSecretFolderDALFactory } from "../secret-folder/secret-folder-dal"; -import { TSecretV2BridgeDALFactory } from "../secret-v2-bridge/secret-v2-bridge-dal"; import { TProjectSlackConfigDALFactory } from "../slack/project-slack-config-dal"; import { validateSlackChannelsField } from "../slack/slack-auth-validators"; import { TSlackIntegrationDALFactory } from "../slack/slack-integration-dal"; @@ -133,10 +128,7 @@ type TProjectServiceFactoryDep = { projectSshConfigDAL: Pick; projectQueue: TProjectQueueFactory; userDAL: TUserDALFactory; - projectBotService: Pick; folderDAL: Pick; - secretDAL: Pick; - secretV2BridgeDAL: Pick; projectEnvDAL: Pick; projectMembershipDAL: Pick; membershipUserDAL: Pick; @@ -192,7 +184,6 @@ type TProjectServiceFactoryDep = { | "createCipherPairWithDataKey" >; projectTemplateService: TProjectTemplateServiceFactory; - reminderService: Pick; notificationService: Pick; }; @@ -201,11 +192,8 @@ export type TProjectServiceFactory = ReturnType; export const projectServiceFactory = ({ projectDAL, projectSshConfigDAL, - secretDAL, - secretV2BridgeDAL, projectQueue, permissionService, - projectBotService, orgDAL, userDAL, folderDAL, @@ -232,7 +220,6 @@ export const projectServiceFactory = ({ microsoftTeamsIntegrationDAL, projectTemplateService, smtpService, - reminderService, notificationService, membershipIdentityDAL, membershipUserDAL,