github/infisical
1
0
Fork 0
mirror of https://github.com/Infisical/infisical.git synced 2026-01-09 15:38:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

improve some wording & hide max request TTL for simplicity

Browse Source
This commit is contained in:
x032205
2025-12-09 11:56:41 -05:00
parent f3291ead8d
commit d4609829fa
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PoliciesTable.tsx
View File

@@ -98,9 +98,7 @@ export const PoliciesTable = ({ handlePopUpOpen }: Props) => {
<Tr> <Tr>
<Th className="w-10" /> <Th className="w-10" />
<Th>Policy Name</Th> <Th>Policy Name</Th>
<Th>Max Approval Request TTL</Th> <Th>Access Duration (min - max)</Th>
<Th>Min Access Duration</Th>
<Th>Max Access Duration</Th>
<Th>Conditions</Th> <Th>Conditions</Th>
<Th className="w-5" /> <Th className="w-5" />
</Tr> </Tr>
@@ -117,7 +115,6 @@ export const PoliciesTable = ({ handlePopUpOpen }: Props) => {
{!isPoliciesLoading && {!isPoliciesLoading &&
policies.map((policy) => { policies.map((policy) => {
const isExpanded = expandedRows.has(policy.id); const isExpanded = expandedRows.has(policy.id);
const maxTtl = policy.maxRequestTtl ? policy.maxRequestTtl : "No limit";
const conditionsCount = policy.conditions.conditions.length; const conditionsCount = policy.conditions.conditions.length;
return ( return (
@@ -144,9 +141,10 @@ export const PoliciesTable = ({ handlePopUpOpen }: Props) => {
</IconButton> </IconButton>
</Td> </Td>
<Td>{policy.name}</Td> <Td>{policy.name}</Td>
<Td>{maxTtl}</Td> <Td>
<Td>{policy.constraints.constraints.accessDuration.min}</Td> {policy.constraints.constraints.accessDuration.min} -{" "}
<Td>{policy.constraints.constraints.accessDuration.max}</Td> {policy.constraints.constraints.accessDuration.max}
</Td>
<Td> <Td>
{conditionsCount} condition{conditionsCount !== 1 ? "s" : ""} {conditionsCount} condition{conditionsCount !== 1 ? "s" : ""}
</Td> </Td>

4
frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyDetailsStep.tsx
View File

@@ -24,7 +24,8 @@ export const PolicyDetailsStep = () => {
</FormControl> </FormControl>
)} )}
/> />
<Controller {/*
<Controller
control={control} control={control}
name="maxRequestTtl" name="maxRequestTtl"
render={({ field, fieldState: { error } }) => ( render={({ field, fieldState: { error } }) => (
@@ -38,6 +39,7 @@ export const PolicyDetailsStep = () => {
</FormControl> </FormControl>
)} )}
/> />
*/}
<div className="border-t border-mineshaft-600 pt-4"> <div className="border-t border-mineshaft-600 pt-4">
<div className="mb-3"> <div className="mb-3">
<p className="pb-0.5 text-sm font-medium text-mineshaft-200"> <p className="pb-0.5 text-sm font-medium text-mineshaft-200">

4
frontend/src/pages/pam/ApprovalsPage/components/PolicyTab/components/PolicySteps/PolicyReviewStep.tsx
View File

@@ -187,8 +187,8 @@ export const PolicyReviewStep = () => {
{/* Summary Notice */} {/* Summary Notice */}
<div className="rounded-md border border-primary/30 bg-primary/5 p-3"> <div className="rounded-md border border-primary/30 bg-primary/5 p-3">
<p className="text-xs text-mineshaft-300"> <p className="text-xs text-mineshaft-300">
Please review all the details above. Click &quot;Create&quot; to save this policy or Please review all the details above. Submit to save this policy or go back to make
&quot;Back&quot; to make changes. changes.
</p> </p>
</div> </div>
</div> </div>