From b799d6444f6c47545bf08d634c35187dbf26fd99 Mon Sep 17 00:00:00 2001 From: PuBHARGAVI Date: Mon, 6 Mar 2023 22:30:12 +0530 Subject: [PATCH] refactor(#607): [Bhargavi] change the labels in the app profile screen --- components/EditableListItem.tsx | 6 +++++- locales/ara.json | 4 ++-- locales/en.json | 4 ++-- locales/fil.json | 4 ++-- locales/hin.json | 4 ++-- locales/kan.json | 4 ++-- locales/tam.json | 4 ++-- machines/settings.ts | 4 ++-- routes/main.ts | 12 ++++++------ screens/MainLayout.strings.json | 2 +- screens/Profile/Credits.tsx | 5 ++++- screens/Profile/ProfileScreen.strings.json | 2 +- screens/Profile/ProfileScreen.tsx | 3 ++- screens/Profile/Revoke.tsx | 5 ++++- 14 files changed, 37 insertions(+), 26 deletions(-) diff --git a/components/EditableListItem.tsx b/components/EditableListItem.tsx index e50b628a..550b8924 100644 --- a/components/EditableListItem.tsx +++ b/components/EditableListItem.tsx @@ -11,7 +11,10 @@ export const EditableListItem: React.FC = (props) => { const [newValue, setNewValue] = useState(props.value); return ( - setIsEditing(true)}> + setIsEditing(true)} + style={{ display: props.display }}> void; + display?: 'none' | 'flex'; } diff --git a/locales/ara.json b/locales/ara.json index 331f6661..c2057cb6 100644 --- a/locales/ara.json +++ b/locales/ara.json @@ -186,7 +186,7 @@ "home": "المنزل", "scan": "مسح", "request": "طلب", - "profile": "الملف الشخصي" + "settings": "إعدادات" }, "PasscodeScreen": { "header": "تعيين رمز مرور لتأمين تطبيقك", @@ -201,7 +201,7 @@ "name": "اسم", "vcLabel": "تسمية VC", "language": "اللغة", - "bioUnlock": "فتح المقاييس الحيوية", + "bioUnlock":"افتح مع القياسات الحيوية", "authFactorUnlock": "إلغاء تأمين عامل المصادقة", "credits": "القانونية", "logout": "تسجيل الخروج", diff --git a/locales/en.json b/locales/en.json index c02f7102..c9e36ed6 100644 --- a/locales/en.json +++ b/locales/en.json @@ -186,7 +186,7 @@ "home": "Home", "scan": "Scan", "request": "Request", - "profile": "Profile" + "settings": "Settings" }, "PasscodeScreen": { "header": "Set a passcode to secure your application", @@ -201,7 +201,7 @@ "name": "Name", "vcLabel": "VC Label", "language": "Language", - "bioUnlock": "Biometric unlock", + "bioUnlock": "Unlock with biometrics", "authFactorUnlock": "Unlock auth factor", "credits": "Credits and legal notices", "logout": "Log-out", diff --git a/locales/fil.json b/locales/fil.json index e70f10c0..5cdbfb5b 100644 --- a/locales/fil.json +++ b/locales/fil.json @@ -176,7 +176,7 @@ "home": "Home", "scan": "Scan", "request": "Request", - "profile": "Profile" + "settings": "mga setting" }, "PasscodeScreen": { "header": "Magtakda ng passcode upang masigurado ang iyong aplikasyon", @@ -191,7 +191,7 @@ "name": "Pangalan", "vcLabel": "Panawag sa VC", "language": "Wika", - "bioUnlock": "Pagbukas gamit Biometric", + "bioUnlock": "I-unlock gamit ang biometrics", "authFactorUnlock": "Pagbukas ng auth factor", "credits": "Mga kredito at legal na abiso", "logout": "Mag log-out", diff --git a/locales/hin.json b/locales/hin.json index ced80fb8..8555ec58 100644 --- a/locales/hin.json +++ b/locales/hin.json @@ -186,7 +186,7 @@ "home": "घर", "scan": "स्कैन", "request": "अनुरोध", - "profile": "प्रोफाइल" + "settings": "सेटिंग्स" }, "PasscodeScreen": { "header": "अपना आवेदन सुरक्षित करने के लिए पासकोड सेट करें", @@ -201,7 +201,7 @@ "name": "नाम", "vcLabel": "वीसी लेबल", "language": "भाषा", - "bioUnlock": "बायोमेट्रिक अनलॉक", + "bioUnlock": "बायोमेट्रिक्स से अनलॉक करें", "authFactorUnlock": "अनलॉक ऑथ फैक्टर", "credits": "क्रेडिट और कानूनी नोटिस", "logout": "लॉग आउट", diff --git a/locales/kan.json b/locales/kan.json index 6822f3d1..1a15e2a1 100644 --- a/locales/kan.json +++ b/locales/kan.json @@ -186,7 +186,7 @@ "home": "ಲೇಔಟ್", "scan": "ಮನೆ", "request": "ವಿನಂತಿ", - "profile": "ಪ್ರೊಫೈಲ್" + "settings": "ಸೆಟ್ಟಿಂಗ್‌ಗಳು" }, "PasscodeScreen": { "header": "ನಿಮ್ಮ ಅಪ್ಲಿಕೇಶನ್ ಅನ್ನು ಸುರಕ್ಷಿತವಾಗಿರಿಸಲು ಪಾಸ್ಕೋಡ್ ಅನ್ನು ಹೊಂದಿಸಿ", @@ -201,7 +201,7 @@ "name": "ಹೆಸರು", "vcLabel": "VC ಲೇಬಲ್", "language": "ಭಾಷೆ", - "bioUnlock": "ಬಯೋಮೆಟ್ರಿಕ್ ಅನ್‌ಲಾಕ್", + "bioUnlock": "ಬಯೋಮೆಟ್ರಿಕ್‌ಗಳೊಂದಿಗೆ ಅನ್‌ಲಾಕ್ ಮಾಡಿ", "authFactorUnlock": "ಅನ್ಲಾಕ್ ದೃಢೀಕರಣ ಅಂಶ", "credits": "ಕ್ರೆಡಿಟ್ಸ್ ಮತ್ತು ಲೀಗಲ್ ನೋಟಿಸ್", "logout": "ಲಾಗ್-ಔಟ್", diff --git a/locales/tam.json b/locales/tam.json index c8223c0e..b5cc5143 100644 --- a/locales/tam.json +++ b/locales/tam.json @@ -186,7 +186,7 @@ "home": "வீடு", "scan": "ஸ்கேன்", "request": "கோரிக்கை", - "profile": "சுயவிவரம்" + "settings": "செட்டிங்ஸ்" }, "PasscodeScreen": { "header": "உங்கள் விண்ணப்பத்தைப் பாதுகாக்க கடவுக்குறியீட்டை அமைக்கவும்", @@ -201,7 +201,7 @@ "name": "பெயர்", "vcLabel": "VC லேபிள்", "language": "மொழி", - "bioUnlock": "பயோமெட்ரிக் அன்லாக்", + "bioUnlock": "பயோமெட்ரிக்ஸ் மூலம் திறக்கவும்", "authFactorUnlock": "அங்கீகார காரணியைத் திற", "credits": "வரவுகள் மற்றும் சட்ட அறிவிப்புகள்", "logout": "வெளியேறு", diff --git a/machines/settings.ts b/machines/settings.ts index 84a21bcb..cf8d2949 100644 --- a/machines/settings.ts +++ b/machines/settings.ts @@ -10,8 +10,8 @@ const model = createModel( serviceRefs: {} as AppServices, name: '', vcLabel: { - singular: 'ID', - plural: 'IDs', + singular: 'Card', + plural: 'Cards', } as VCLabel, isBiometricUnlockEnabled: false, }, diff --git a/routes/main.ts b/routes/main.ts index e542b801..e50ea8f8 100644 --- a/routes/main.ts +++ b/routes/main.ts @@ -38,12 +38,12 @@ const request: TabScreen = { headerShown: false, }, }; -const profile: TabScreen = { - name: 'Profile', +const settings: TabScreen = { + name: 'Settings', component: ProfileScreen, - icon: 'person', + icon: 'settings', options: { - title: i18n.t('MainLayout:profile'), + title: i18n.t('MainLayout:Settings'), }, }; @@ -55,7 +55,7 @@ if (Platform.OS !== 'ios' || isGoogleNearbyEnabled) { mainRoutes.push(request); } -mainRoutes.push(profile); +mainRoutes.push(settings); export type MainBottomTabParamList = { Home: { @@ -63,7 +63,7 @@ export type MainBottomTabParamList = { }; Scan: undefined; Request: undefined; - Profile: undefined; + Settings: undefined; }; export interface TabScreen { diff --git a/screens/MainLayout.strings.json b/screens/MainLayout.strings.json index 7fd40a57..520b6d86 100644 --- a/screens/MainLayout.strings.json +++ b/screens/MainLayout.strings.json @@ -2,5 +2,5 @@ "home": "Home", "scan": "Scan", "request": "Request", - "profile": "Profile" + "settings": "Settings" } \ No newline at end of file diff --git a/screens/Profile/Credits.tsx b/screens/Profile/Credits.tsx index 08c96410..29146713 100644 --- a/screens/Profile/Credits.tsx +++ b/screens/Profile/Credits.tsx @@ -46,7 +46,10 @@ export const Credits: React.FC = (props) => { }; return ( - setIsViewing(true)}> + setIsViewing(true)} + style={{ display: 'none' }}> = (props) => { value={controller.vcLabel.singular} onEdit={controller.UPDATE_VC_LABEL} Icon="star" + display="none" /> @@ -106,7 +107,7 @@ export const ProfileScreen: React.FC = (props) => { color={Theme.Colors.profileValue} /> - + = (props) => { const { t } = useTranslation('ProfileScreen'); return ( - controller.setAuthenticating(true)}> + controller.setAuthenticating(true)} + style={{ display: 'none' }}>