diff --git a/packages/eslint-config-airbnb-base/rules/best-practices.js b/packages/eslint-config-airbnb-base/rules/best-practices.js index 26602745..a6f714bc 100644 --- a/packages/eslint-config-airbnb-base/rules/best-practices.js +++ b/packages/eslint-config-airbnb-base/rules/best-practices.js @@ -92,6 +92,8 @@ module.exports = { // disallow reassignments of native objects or read-only globals // http://eslint.org/docs/rules/no-global-assign 'no-global-assign': ['error', { exceptions: [] }], + // deprecated in favor of no-global-assign + 'no-native-reassign': 'off', // disallow implicit type conversions // http://eslint.org/docs/rules/no-implicit-coercion @@ -139,10 +141,6 @@ module.exports = { // disallow use of multiline strings 'no-multi-str': 'error', - // disallow reassignments of native objects - // TODO: deprecated in favor of no-global-assign - 'no-native-reassign': 'off', - // disallow use of new operator when not part of the assignment or comparison 'no-new': 'error', diff --git a/packages/eslint-config-airbnb-base/rules/errors.js b/packages/eslint-config-airbnb-base/rules/errors.js index 6c932c8d..4dbed4f3 100644 --- a/packages/eslint-config-airbnb-base/rules/errors.js +++ b/packages/eslint-config-airbnb-base/rules/errors.js @@ -63,10 +63,6 @@ module.exports = { // disallow irregular whitespace outside of strings and comments 'no-irregular-whitespace': 'error', - // disallow negation of the left operand of an in expression - // TODO: deprecated in favor of no-unsafe-negation - 'no-negated-in-lhs': 'off', - // disallow the use of object properties of the global object (Math and JSON) as functions 'no-obj-calls': 'error', @@ -82,8 +78,7 @@ module.exports = { // Disallow template literal placeholder syntax in regular strings // http://eslint.org/docs/rules/no-template-curly-in-string - // TODO: enable, semver-major - 'no-template-curly-in-string': 'off', + 'no-template-curly-in-string': 'error', // Avoid code that looks like two expressions but is actually one // http://eslint.org/docs/rules/no-unexpected-multiline @@ -99,6 +94,9 @@ module.exports = { // disallow negating the left operand of relational operators // http://eslint.org/docs/rules/no-unsafe-negation 'no-unsafe-negation': 'error', + // disallow negation of the left operand of an in expression + // deprecated in favor of no-unsafe-negation + 'no-negated-in-lhs': 'off', // disallow comparisons with the value NaN 'use-isnan': 'error', diff --git a/packages/eslint-config-airbnb-base/rules/es6.js b/packages/eslint-config-airbnb-base/rules/es6.js index 169e30be..611dbe4d 100644 --- a/packages/eslint-config-airbnb-base/rules/es6.js +++ b/packages/eslint-config-airbnb-base/rules/es6.js @@ -103,7 +103,7 @@ module.exports = { // suggest using Reflect methods where applicable // http://eslint.org/docs/rules/prefer-reflect - // TODO: enable + // TODO: enable? 'prefer-reflect': 'off', // use rest parameters instead of arguments diff --git a/packages/eslint-config-airbnb-base/rules/variables.js b/packages/eslint-config-airbnb-base/rules/variables.js index 312ee768..8af041c0 100644 --- a/packages/eslint-config-airbnb-base/rules/variables.js +++ b/packages/eslint-config-airbnb-base/rules/variables.js @@ -29,6 +29,7 @@ module.exports = { 'no-undef-init': 'error', // disallow use of undefined variable + // http://eslint.org/docs/rules/no-undefined // TODO: enable? 'no-undefined': 'off',