From 282ef9ea9051dce725f382ac83cb5c3f2d4da0c2 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Fri, 9 Aug 2019 22:46:22 -0700 Subject: [PATCH] [eslint config] [base] [breaking] `no-self-assign`: enable `props` option --- packages/eslint-config-airbnb-base/rules/best-practices.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/eslint-config-airbnb-base/rules/best-practices.js b/packages/eslint-config-airbnb-base/rules/best-practices.js index 8c763dd6..41f85487 100644 --- a/packages/eslint-config-airbnb-base/rules/best-practices.js +++ b/packages/eslint-config-airbnb-base/rules/best-practices.js @@ -248,9 +248,8 @@ module.exports = { // disallow self assignment // https://eslint.org/docs/rules/no-self-assign - // TODO: semver-major: props -> true 'no-self-assign': ['error', { - props: false, + props: true, }], // disallow comparisons where both sides are exactly the same