From 31d95fded451b31695d9cc09abc117edcea4969d Mon Sep 17 00:00:00 2001 From: Sharmila Date: Wed, 4 Apr 2018 16:23:02 -0700 Subject: [PATCH] [eslint config] [*] [deps] update `eslint`, `eslint-plugin-import`, `eslint-find-rules` --- packages/eslint-config-airbnb-base/package.json | 10 +++++----- packages/eslint-config-airbnb-base/rules/imports.js | 5 +++++ packages/eslint-config-airbnb/package.json | 10 +++++----- 3 files changed, 15 insertions(+), 10 deletions(-) diff --git a/packages/eslint-config-airbnb-base/package.json b/packages/eslint-config-airbnb-base/package.json index e9a6589b..2c3d49bd 100644 --- a/packages/eslint-config-airbnb-base/package.json +++ b/packages/eslint-config-airbnb-base/package.json @@ -52,16 +52,16 @@ "babel-preset-airbnb": "^2.4.0", "babel-tape-runner": "^2.0.1", "editorconfig-tools": "^0.1.1", - "eslint": "^4.18.1", - "eslint-find-rules": "^3.2.0", - "eslint-plugin-import": "^2.9.0", + "eslint": "^4.19.1", + "eslint-find-rules": "^3.2.2", + "eslint-plugin-import": "^2.10.0", "in-publish": "^2.0.0", "safe-publish-latest": "^1.1.1", "tape": "^4.9.0" }, "peerDependencies": { - "eslint": "^4.18.1", - "eslint-plugin-import": "^2.9.0" + "eslint": "^4.19.1", + "eslint-plugin-import": "^2.10.0" }, "engines": { "node": ">= 4" diff --git a/packages/eslint-config-airbnb-base/rules/imports.js b/packages/eslint-config-airbnb-base/rules/imports.js index a34e7f25..3c76a5aa 100644 --- a/packages/eslint-config-airbnb-base/rules/imports.js +++ b/packages/eslint-config-airbnb-base/rules/imports.js @@ -226,6 +226,11 @@ module.exports = { // https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-self-import.md 'import/no-self-import': 'error', + // Forbid cyclical dependencies between modules + // https://github.com/benmosher/eslint-plugin-import/blob/d81f48a2506182738409805f5272eff4d77c9348/docs/rules/no-cycle.md + // TODO: enable, semver-major + 'import/no-cycle': ['off', { maxDepth: Infinity }], + // Ensures that there are no useless path segments // https://github.com/benmosher/eslint-plugin-import/issues/1032 'import/no-useless-path-segments': 'error', diff --git a/packages/eslint-config-airbnb/package.json b/packages/eslint-config-airbnb/package.json index df135d54..dfaadad2 100644 --- a/packages/eslint-config-airbnb/package.json +++ b/packages/eslint-config-airbnb/package.json @@ -57,9 +57,9 @@ "babel-preset-airbnb": "^2.4.0", "babel-tape-runner": "^2.0.1", "editorconfig-tools": "^0.1.1", - "eslint": "^4.18.1", - "eslint-find-rules": "^3.2.0", - "eslint-plugin-import": "^2.9.0", + "eslint": "^4.19.1", + "eslint-find-rules": "^3.2.2", + "eslint-plugin-import": "^2.10.0", "eslint-plugin-jsx-a11y": "^6.0.3", "eslint-plugin-react": "^7.7.0", "in-publish": "^2.0.0", @@ -68,8 +68,8 @@ "tape": "^4.9.0" }, "peerDependencies": { - "eslint": "^4.18.1", - "eslint-plugin-import": "^2.9.0", + "eslint": "^4.19.1", + "eslint-plugin-import": "^2.10.0", "eslint-plugin-jsx-a11y": "^6.0.3", "eslint-plugin-react": "^7.7.0" },