From 63bf905ed6ab4d33f75ee4147d9e38745aba4cf3 Mon Sep 17 00:00:00 2001 From: Harrison Shoff Date: Thu, 23 Jul 2015 10:28:28 -0700 Subject: [PATCH] [comments] update 17.4, 17.5 examples to follow 17.2. fixes #430 --- README.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index bd472845..7dff4675 100644 --- a/README.md +++ b/README.md @@ -573,7 +573,7 @@ ```javascript // bad var add = new Function('a', 'b', 'return a + b'); - + // still bad var subtract = Function('a', 'b', 'return a - b'); ``` @@ -1223,8 +1223,10 @@ - [17.4](#17.4) Use `// FIXME:` to annotate problems. ```javascript - class Calculator { + class Calculator extends Abacus { constructor() { + super(); + // FIXME: shouldn't use a global here total = 0; } @@ -1234,8 +1236,10 @@ - [17.5](#17.5) Use `// TODO:` to annotate solutions to problems. ```javascript - class Calculator { + class Calculator extends Abacus { constructor() { + super(); + // TODO: total should be configurable by an options param this.total = 0; }