From 7816731d4dabfcf6b01a22f70e497f0a24a14da0 Mon Sep 17 00:00:00 2001 From: Joe Lencioni Date: Tue, 5 Jul 2016 10:11:18 -0700 Subject: [PATCH] Allow importing devDependencies in tests This rule seems to be giving me errors for some places we have imported devDependencies in our tests such as tape and eslint. This is actually okay, so we just need to configure this rule to allow devDependencies for tests. While I was at it, I added some whitespace to improve readability and reduce the likelihood of merge conflicts. --- packages/eslint-config-airbnb/test/.eslintrc | 6 +++++- packages/eslint-config-airbnb/test/test-react-order.js | 9 +++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/packages/eslint-config-airbnb/test/.eslintrc b/packages/eslint-config-airbnb/test/.eslintrc index 7f79874e..eafcdbff 100644 --- a/packages/eslint-config-airbnb/test/.eslintrc +++ b/packages/eslint-config-airbnb/test/.eslintrc @@ -3,7 +3,11 @@ // disabled because I find it tedious to write tests while following this // rule "no-shadow": 0, + // tests uses `t` for tape - "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}] + "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}], + + // tests can import things in devDependencies + "import/no-extraneous-dependencies": [2, {"devDependencies": true}] } } diff --git a/packages/eslint-config-airbnb/test/test-react-order.js b/packages/eslint-config-airbnb/test/test-react-order.js index e3e4cfbd..016fef9d 100644 --- a/packages/eslint-config-airbnb/test/test-react-order.js +++ b/packages/eslint-config-airbnb/test/test-react-order.js @@ -8,8 +8,13 @@ const cli = new CLIEngine({ useEslintrc: false, baseConfig: eslintrc, - // This rule fails when executing on text. - rules: { indent: 0 }, + rules: { + // This rule fails when executing on text. + indent: 0, + + // It is okay to import devDependencies in tests. + 'import/no-extraneous-dependencies': [2, { devDependencies: true }], + }, }); function lint(text) {