From 8d0fda975c1b52dd6696d8f70219a00f9703871d Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Thu, 13 Oct 2016 00:33:29 -0700 Subject: [PATCH] [eslint config] [base] Add comments on new import rules. --- packages/eslint-config-airbnb-base/rules/imports.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/eslint-config-airbnb-base/rules/imports.js b/packages/eslint-config-airbnb-base/rules/imports.js index a02ef930..a8f4269c 100644 --- a/packages/eslint-config-airbnb-base/rules/imports.js +++ b/packages/eslint-config-airbnb-base/rules/imports.js @@ -155,9 +155,11 @@ module.exports = { allow: [], }], - // Warn if a module could be mistakenly parsed as a script by a consumer leveraging Unambiguous - // JavaScript Grammar + // Warn if a module could be mistakenly parsed as a script by a consumer + // leveraging Unambiguous JavaScript Grammar // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/unambiguous.md + // this should not be enabled until this proposal has at least been *presented* to TC39. + // At the moment, it's not a thing. 'import/unambiguous': 'off', // Forbid Webpack loader syntax in imports @@ -166,6 +168,7 @@ module.exports = { // Prevent unassigned imports // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unassigned-import.md + // importing for side effects is perfectly acceptable, if you need side effects. 'import/no-unassigned-import': 'off', }, };