From b7492ffe60483edd5f30819ceaa0f3f4b6e84886 Mon Sep 17 00:00:00 2001 From: "Randall Reed, Jr" Date: Sat, 8 Oct 2016 16:41:45 -0400 Subject: [PATCH] Update comparison recommendation * Use shortcuts for boolean comparisons * Use explicit comparisons for strings and numbers --- README.md | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 56580fee..60621cca 100644 --- a/README.md +++ b/README.md @@ -1652,26 +1652,36 @@ Other Style Guides ``` - - [15.3](#comparison--shortcuts) Use shortcuts. + - [15.3](#comparison--shortcuts) Use shortcuts for booleans, but explicit comparisons for strings and numbers. ```javascript // bad - if (name !== '') { + if (isValid === true) { // ...stuff... } // good + if (isValid) { + // ...stuff... + } + + // bad if (name) { // ...stuff... } + // good + if (name !== '') { + // ...stuff... + } + // bad - if (collection.length > 0) { + if (collection.length) { // ...stuff... } // good - if (collection.length) { + if (collection.length > 0) { // ...stuff... } ```