From d45349497a712395850bd5a24b7ded15e90913a1 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Tue, 26 Apr 2016 02:06:37 -0700 Subject: [PATCH] [eslint config] [base] [deps] update `eslint-find-rules`, `eslint-plugin-import` --- .../eslint-config-airbnb-base/package.json | 6 ++--- .../eslint-config-airbnb-base/rules/es6.js | 23 ++++++++++++++++--- 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/packages/eslint-config-airbnb-base/package.json b/packages/eslint-config-airbnb-base/package.json index b5642bfa..25dc9844 100644 --- a/packages/eslint-config-airbnb-base/package.json +++ b/packages/eslint-config-airbnb-base/package.json @@ -45,12 +45,12 @@ "devDependencies": { "babel-tape-runner": "^1.3.1", "eslint": "^2.8.0", - "eslint-find-rules": "^1.4.0", - "eslint-plugin-import": "^1.5.0", + "eslint-find-rules": "^1.7.0", + "eslint-plugin-import": "^1.6.0", "tape": "^4.5.1" }, "peerDependencies": { "eslint": "^2.8.0", - "eslint-plugin-import": "^1.5.0" + "eslint-plugin-import": "^1.6.0" } } diff --git a/packages/eslint-config-airbnb-base/rules/es6.js b/packages/eslint-config-airbnb-base/rules/es6.js index d0f7577a..77c0b325 100644 --- a/packages/eslint-config-airbnb-base/rules/es6.js +++ b/packages/eslint-config-airbnb-base/rules/es6.js @@ -89,17 +89,25 @@ module.exports = { // disallow invalid exports, e.g. multiple defaults // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/export.md 'import/export': 2, - // ensure imports point to files/modules that can be resolved - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md - 'import/no-unresolved': [2, { 'commonjs': true }], // ensure default import coupled with default export // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/default.md#when-not-to-use-it 'import/default': 0, + // Ensure consistent use of file extension within the import path + // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md + // TODO: enable + 'import/extensions': [0, 'never'], // ensure named imports coupled with named exports // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/named.md#when-not-to-use-it 'import/named': 0, // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/namespace.md 'import/namespace': 0, + // Forbid the use of extraneous packages + // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md + // TODO: enable + 'import/no-extraneous-dependencies': [0, { 'devDependencies': false }], + // ensure imports point to files/modules that can be resolved + // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md + 'import/no-unresolved': [2, { 'commonjs': true }], // do not allow a default import name to match a named export // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-as-default.md // TODO: enable @@ -130,6 +138,15 @@ module.exports = { // TODO: enable? // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-as-default-member.md 'import/no-named-as-default-member': 0, + // No Node.js builtin modules + // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-nodejs-modules.md + 'import/no-nodejs-modules': 0, + // Enforce a convention in module import order + // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md + // TODO: enable? + 'import/order': [0, { + 'groups': ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'], + }], }, 'settings': { 'import/resolver': {