github/javascript
1
1
Fork 0
mirror of https://github.com/airbnb/javascript.git synced 2026-01-13 19:58:00 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,985 Commits 5 Branches 102 Tags
master
Commit Graph

798 Commits

Author SHA1 Message Date
Jordan Harband
c25dbac620 v4.0.0 2016-01-22 16:27:43 -08:00
Harrison Shoff
0839881fd2 Merge pull request #679 from jshen212/patch-1 
Fix case type on line 3 comment
 2016-01-22 09:52:14 -08:00
Jordan Harband
396e4611c4 [Tests] use parallelshell to parallelize npm run-scripts 2016-01-16 11:02:04 -08:00
Jordan Harband
ab58d3b68e [Tests] run npm run lint as part of tests; fix errors. 
hat tip to https://github.com/airbnb/javascript/pull/678#issuecomment-172017623
 2016-01-15 10:31:00 -08:00
Jeff Shen
c778ade841 Fix case type on line 3 comment 
Update case type to resemble other comments
 2016-01-14 23:30:08 -08:00
Simon Olofsson
54b4dea0f9 Add prefer-arrow-callback to ES6 Rules. 
This prefers arrow functions as described in https://github.com/airbnb/javascript#8.1
 2016-01-13 17:32:30 +01:00
Jordan Harband
4ef335e242 [eslint config] [breaking] require outer IIFE wrapping; flesh out guide section. 
There was lots of discussion [here](https://github.com/airbnb/javascript/issues/21#issuecomment-10203921), but now that we have both a modern build system and an eslint rule requiring terminating semicolons, the concerns with the “crockford” style no longer apply.
 2016-01-10 15:11:05 -08:00
Simon Olofsson
c2fd8fbbd6 Add missing ES6 rules to ESLint config. 
`arrow-body-style` (8.2) and `prefer-template` (6.4) are described in
the Style Guide.
 2016-01-15 10:46:29 +01:00
Jordan Harband
af81beb6b8 v3.1.0 2016-01-07 22:21:21 -08:00
Simen Bekkhus
96ef087bdf Allow multiple stateless components in a single file 2016-01-07 19:22:18 +01:00
Jordan Harband
74561b6449 v3.0.2 2016-01-06 17:06:42 -08:00
Matija Marohnić
8c70a8bc6d Ignore URLs in max-len 2016-01-07 01:11:00 +01:00
Jordan Harband
ed1f484e1f v3.0.1 2016-01-06 11:24:10 -08:00
Jordan Harband
9af944dd05 [eslint config] [fix] because we use babel, keywords should not be quoted. 2016-01-06 09:06:57 -08:00
Jordan Harband
286e845b53 v3.0.0 2016-01-04 14:33:49 -08:00
Jordan Harband
81c58472b6 Fix a bug introduced in f2afce75e9 / #581 2016-01-04 14:33:49 -08:00
Jordan Harband
4cdc3fe483 [eslint config] [breaking] enable quote-props rule. 2015-12-22 09:49:25 -08:00
Gergo Erdosi
8e54961aeb Fix max-len rule definition 
The current definition is valid only in eslint@2.x.x, but this package has a dependency on eslint@1.10.3 which doesn't have all those options yet.
 2015-12-31 01:39:07 +01:00
Jordan Harband
8c241be003 Merge pull request #637 from evenfrost/master 
[eslint config] Permit strict mode in "legacy" config
 2015-12-24 08:35:26 -08:00
Christopher Banh
e2e4724fbb Address comments in #639 
[eslint] Add comment above `max-len` rule with link to its docs
[eslint] Change tab width for `max-len` rule from 4 to 2
[eslint] Replace double quotes around `max-len` with single quotes
[eslint] Use object form of `max-len` and include all of the options
 2015-12-24 02:08:16 -08:00
Christopher Banh
69d3327362 Enable ESLint rule on limiting maxiumum length of line (max-len) 
I moved the rule from legacy.js to style.js and enabled it
 2015-12-24 02:08:16 -08:00
Aleksey Kislov
c9a9194243 Preserve strict rule for default export 2015-12-24 11:31:33 +03:00
Mordy Tikotzky
f2afce75e9 add default config to all rules which take a config 2015-12-23 21:39:31 -05:00
Mordy Tikotzky
b294e7cbf2 add missing rules from eslint-plugin-react 2015-12-23 21:38:53 -05:00
Jordan Gensler
5c3137d736 Cleaning up the react styleguide. Adding additional info in props. 2015-12-23 14:57:22 -08:00
Jordan Harband
75617bd619 Merge pull request #536 from amsardesai/add-version-badge 
[eslint config] [Docs] Add version badge
 2015-12-23 12:17:27 -08:00
Aleksey Kislov
76ff913d26 Permit strict mode 
Permit strict mode for legacy configuration as it is not intended to be used with Babel.
 2015-12-23 17:34:31 +03:00
Jordan Harband
eea8efe551 Merge pull request #635 from lencioni/no-is-mounted 
[eslint-config] [breaking] Enable react/no-is-mounted rule
 2015-12-22 12:07:04 -08:00
Joe Lencioni
f2dc5043a1 [eslint-config] [minor] Enable react/no-is-mounted rule 
isMounted is an anti-pattern [0], is not available when using ES6
classes, and is on its way to being officially deprecated.
eslint-plugin-react recently added the react/no-is-mounted rule in
3.12.0 that prevents its use.

[0]: https://facebook.github.io/react/blog/2015/12/16/ismounted-antipattern.html

Finishes #633
 2015-12-22 12:04:03 -08:00
Joe Lencioni
6602586a20 [eslint config] [minor] Sort react/prefer-es6-class alphabetically 
All of the other rules in this file are in alphabetical order, but this
one was added by c98990c0f out of order at the end. Keeping these in
alphabetical order will help developers find the rules that they are
looking for.
 2015-12-22 11:44:28 -08:00
Jordan Harband
c98990c0f9 [eslint config] [minor] enable react/prefer-es6-class rule 2015-12-22 09:44:26 -08:00
Jordan Harband
c584319df8 [eslint config] [Dev Deps] update eslint-plugin-react 2015-12-22 09:44:07 -08:00
Thomas Shafer
f7971301b0 update examples for style 
add link to no-param-reassign rule documentation
 2015-12-16 20:21:38 -08:00
Thomas Shafer
2589c67b0c update best-practices config to prevent parameter object manipulation 
added good/bad examples of parameter mutation to the readme
 2015-12-16 15:43:00 -08:00
Jordan Harband
fcc41eecd7 v2.1.1 2015-12-15 13:07:24 -08:00
Jordan Harband
28476a25d8 [eslint config] add rule link and defaults to jsx-quotes rule 2015-12-15 13:06:28 -08:00
Billy Janitsch
bbcb1371e5 Remove deprecated react/jsx-quotes 2015-12-15 15:59:40 -05:00
Jordan Harband
60b01bdfb9 [eslint config] v2.1.0 2015-12-15 01:22:30 -08:00
Jordan Harband
0fc31eaf1c [eslint config] fix b1500397e1 2015-12-15 01:19:32 -08:00
Jordan Harband
4ab41ede1b [eslint config] [Dev Deps] update eslint 2015-12-14 23:55:21 -08:00
Jake Teton-Landis
a7541c9b22 Merge pull request #582 from jkrems/jk-require-resolve 
Use require.resolve to allow nested extend
 2015-12-14 23:49:00 -08:00
Jordan Harband
b1500397e1 [eslint config] enable object-shorthand rule. 
Fixes #621.
 2015-12-14 22:21:52 -08:00
Jordan Gensler
d02a506377 Adding links to react rules for quick reference. 2015-12-11 23:13:30 -08:00
Jordan Gensler
e9b1ef92bf Adding links to lint rules in react styleguide. 2015-12-11 23:00:10 -08:00
Jordan Gensler
d5a636f298 [react] Including missing defaults to the react eslint 2015-12-11 18:47:48 -08:00
Vladimir Kutepov
514bd87d1a Require space before/after arrow function's arrow (arrow-spacing) 
Enable [arrow-spacing](http://eslint.org/docs/rules/arrow-spacing.html) rule, code with space before/after arrow function's arrow is easier to read.
```js
() => {};
(a) => {};
a => a;
() => {'\n'};
()=> {};     /*error Missing space before =>*/
() =>{};     /*error Missing space after =>*/
(a)=> {};    /*error Missing space before =>*/
(a) =>{};    /*error Missing space after =>*/
a =>a;       /*error Missing space after =>*/
a=> a;       /*error Missing space before =>*/
()=> {'\n'}; /*error Missing space before =>*/
() =>{'\n'}; /*error Missing space after =>*/
```
 2015-12-11 13:50:46 +05:00
Jordan Harband
4c0a70e435 [eslint config] v2.0.0 
- separate changelog
 2015-12-03 13:55:09 -08:00
Jordan Harband
326100a7b9 Merge pull request #605 from airbnb/ljharb/fix_function_spacing 
[breaking] Require function spacing: `function <optional name>(`
 2015-12-03 13:33:45 -08:00
Jordan Harband
4ccd04b69a I abhor switch statements, but their indentation should be: 
```js
switch (foo) {
  case 'bar':
    break;
}
```

not what the plugin currently requires:
```js
switch (foo) {
case: 'bar':
  break;
}
```
 2015-12-03 00:09:12 -08:00
Jordan Harband
599ca4f123 Require a space between function and (, and function and the function's name, and disallow spaces between the function's name and (. 2015-12-02 22:58:11 -08:00