Jordan Harband
7412641af9
[eslint config] [base] [deps] update to eslint v3.5.0.
2016-09-10 14:28:26 -07:00
Joe Lencioni
ff69c8cb35
Prefer https over http
...
I checked all of the links in the JS style guide document and converted
as many as I could to use https.
2016-09-08 08:39:18 -07:00
Jordan Eldredge
7d46d3c59f
Document react/require-render-return as a fully fledged rule
...
Now that the pull request has been merged, we can reference the actual rule.
2016-09-08 09:56:57 -07:00
Joe Lencioni
25123199dc
Add JavaScript Air to list of Podcasts
...
It probably wouldn't be a bad idea for us to make a full pass on
updating the resources section, but I noticed the podcasts portion was
missing JS Air.
2016-09-08 08:29:10 -07:00
Joe Lencioni
68b7aeb6dd
Add rule about TC39 proposals that haven't reached stage 3
...
There has been some confusion around which language features should be
used and which should not be used yet. We have a pretty clear-cut rule
at Airbnb about this, which is do not use any TC39 proposals that have
not reached stage 3.
I considered putting this at the very top of the document, but I spotted
this section that seemed to fit.
Addresses #1057
2016-09-08 08:19:27 -07:00
Joe Lencioni
e6782493f3
Update ECMAScript 6 heading to match TOC
...
I plan to add some information to this section that applies to ES6 and
everything following ES6. Since we already list this as ES6+ in the
table of contents, I figured it would be a good idea to make this match.
I preserved the anchor to avoid breaking links for folks.
2016-09-08 08:11:32 -07:00
Jordan Harband
f769e35018
[eslint config] v11.0.0
2016-09-08 00:19:10 -07:00
Jordan Harband
ccd18f8b40
[guide] Update declarations section to prefer expressions.
...
Fixes #1008 .
2016-09-06 23:08:36 -07:00
Jordan Harband
7f12b9f043
[eslint config] [breaking] enable react rules:
...
- `react/no-danger-with-children`
- `react/no-unused-prop-types`
- `react/style-prop-object`
- `react/forbid-prop-types`
- `react/jsx-no-duplicate-props`
Also sets `react/no-danger` to “warn”.
2016-09-06 22:53:01 -07:00
Jordan Harband
4ce30fc891
[eslint config] [breaking] enable jsx-a11y rules:
...
- `jsx-a11y/anchor-has-content`
- `jsx-a11y/tabindex-no-positive`
- `jsx-a11y/no-static-element-interactions`
2016-09-06 22:46:52 -07:00
Jordan Harband
e037760bad
[eslint config] [deps] update eslint-config-airbnb-base, eslint, eslint-find-rules, eslint-plugin-import, eslint-plugin-jsx-a11y, eslint-plugin-react
2016-09-06 17:10:48 -07:00
cshg
9abe878941
Fix header link to Classes & Constructors from ECMAScript 6+ Styles
2016-09-07 11:30:58 +02:00
Jordan Harband
49045060e0
[eslint config] [base] v7.0.0
2016-09-06 12:21:22 -07:00
scott stern
55d044c7c1
[eslint config] [base] [breaking] Add no-plusplus in style.js and added explanation in README.
2016-09-06 11:59:01 -07:00
Jordan Harband
bc3b15d4d7
[eslint config] [*] [docs] use “#” in example command rather than version numbers.
...
Closes #984 .
2016-09-06 11:40:42 -07:00
Jordan Harband
e52f41c9cc
[eslint config] [base] v6.0.0
2016-09-06 10:56:02 -07:00
Jordan Harband
9750f4261c
[eslint config] [base] Update ecmaVersion to 2016.
2016-09-06 10:50:03 -07:00
Jordan Harband
d7d606ec0d
[eslint config] [base] [breaking] valid-typeof: enable requireStringLiterals option
2016-09-06 10:48:21 -07:00
Jordan Harband
06ff74801b
[eslint config] [base] [breaking] enable class-methods-use-this
2016-09-06 10:44:19 -07:00
Jordan Harband
2c5a775d7b
[eslint config] [base] [breaking] enable symbol-description
2016-09-06 10:44:00 -07:00
Jordan Harband
3bf7035cec
[eslint config] [base] [deps] update eslint, eslint-find-rules, eslint-plugin-import
2016-09-06 10:40:31 -07:00
Jordan Harband
a6d59f977e
[eslint config] [base] [breaking] enable no-bitwise
2016-09-06 01:07:56 -07:00
Jordan Harband
aa4e9c466a
[eslint config] [base] [breaking] enable no-tabs
2016-09-06 01:07:39 -07:00
Jordan Harband
27dcb99c6d
[eslint config] [base] [breaking] enable func-call-spacing
2016-09-06 01:07:16 -07:00
Jordan Harband
086cc0035d
[eslint config] [base] [breaking] enable no-template-curly-in-string
...
- Also, clean up rule documentation.
2016-09-06 00:36:04 -07:00
Jordan Harband
c829114a41
Merge pull request #1047 from airbnb/css-in-js
...
[guide] Add CSS-in-JavaScript section
2016-09-02 13:21:10 -07:00
Joe Lencioni
c6406330ea
Add note about where where mystery objects come from
...
As @ljharb pointed out, we are using some functions like `css()` and
`withStyles()`, but make no mention of what they are or where they come
from. Since they come from react-with-styles, let's make this clear.
2016-09-02 07:57:33 -07:00
Joe Lencioni
c74caead2a
Re-order breakpoints in CSS-in-JS document
...
This is more "mobile first".
2016-09-01 09:49:21 -07:00
Joe Lencioni
71a2b12262
Add CSS-in-JavaScript section
...
We have been writing CSS in JavaScript and have developed a set of best
practices around this type of thing. I thought it would be nice to
publish this document alongside our other JavaScript style guide
documents.
2016-09-01 09:49:21 -07:00
Jordan Harband
3a7210eac1
[guide] remove subtle endorsement of JSDoc-style commenting.
2016-08-31 21:54:51 -07:00
Jordan Harband
0e4517ea38
[eslint config] [patch] set ignoreCase to true in disabled rules.
...
When/if these rules are enabled, we will want to ignore case.
This also helps https://github.com/pinterest-web/eslint-config-pinterest/pull/46/files#r76165293
2016-08-29 00:11:52 -07:00
Thomas Marek
a43c16e330
Explain why not to prefix methods with underscores
2016-08-29 18:19:22 -04:00
Heejong Ahn
6944be009c
Fix a typo in commas section
...
Example code block following blockquote(line 2223) was broken as a line break was missing. So I just added single blank line.
2016-08-28 23:09:11 +09:00
Harrison Shoff
1541503fd4
[7.1] add link to fn names discussion. fixes #794
2016-08-25 21:48:31 -07:00
Jordan Harband
48f477db2a
[eslint config] [base] [patch] remove redundant DebuggerStatement from no-restricted-syntax
...
Fixes #1031 .
2016-08-23 15:19:34 -07:00
Jordan Harband
21846f6da0
[guide] fix “long lines” example to not include strings.
...
Fixes #1027 .
2016-08-23 15:07:42 -07:00
Jordan Harband
ca1124cd8d
[eslint config] [base] v5.0.3
2016-08-21 23:25:19 -07:00
Yang Su
2e694723bf
Changed ESLint rule configs to use 'off', 'warn', and 'error' instead of numbers for better readability
2016-08-20 15:36:57 -07:00
Jordan Harband
f1fedfa7ca
ES2015
2016-08-18 23:08:45 -07:00
soul-wish
baf0fa5343
fix issue with eslint-config-airbnb README.md file formatting
2016-08-18 22:35:42 +03:00
Joe Lencioni
39d5559b9a
Remove misleading reference to one-var eslint rule
...
This eslint rule does not enforce this style guide rule. I believe that
referencing it here will cause people to believe that this is enforced
via linting when it is not. As far as I know, there is no rule that
currently enforces this, but it would be nice to add one.
2016-08-18 10:35:23 -07:00
Olivier G
41623039e8
Typo : text link to 13.5 was not working ( #1020 )
2016-08-18 08:33:23 -07:00
Jordan Harband
3ad33681a7
[eslint config] [*] [deps] update eslint, eslint-plugin-react
2016-08-18 00:50:37 -07:00
Aniruddh Agarwal
b126016410
Add section on variable assignment chaining
2016-08-18 13:48:58 +08:00
Gerardo Renovales
e92eaef4e2
Update README.md
...
Add M2GEN to the list
2016-08-17 19:46:55 -04:00
Jordan Harband
db2e7bdf63
[eslint config] [base] [fix] correct import/extensions list.
...
From b45fdcd60ffixes #1013 .
2016-08-15 23:17:04 -07:00
Jordan Harband
424d74ec8d
[eslint config] [deps] update eslint-plugin-react
2016-08-15 00:21:39 -07:00
Jordan Harband
3fb9f2ec69
[eslint config] v10.0.1
2016-08-12 15:52:10 -07:00
Jordan Harband
7d9af14ce4
[eslint config] [deps] update eslint, eslint-plugin-jsx-a11y, eslint-plugin-import, eslint-config-airbnb-base
...
- add temp disabled `jsx-a11y/anchor-has-content` rule
2016-08-12 15:49:45 -07:00
Jordan Harband
be6e13f7b9
[eslint config] [base] v5.0.2
2016-08-12 15:38:44 -07:00
