217 Commits

Author SHA1 Message Date
Jordan Harband
0e627e2fa3 [readme] update eslint plugin repo URLs 2023-05-15 10:15:59 -07:00
Jordan Harband
bf536566ce [eslint config] [deps] update eslint-plugin-react, eslint-plugin-jsx-a11y 2023-02-08 22:59:18 -08:00
Jordan Harband
fd96a4fd57 [eslint config] [*] [refactor] use object spread instead of Object.assign 2022-12-30 14:48:36 -08:00
Jordan Harband
206d25b55a [eslint config] [deps] update eslint-plugin-react 2022-05-24 08:52:07 -07:00
Jordan Harband
1677ba6c6a [eslint config] [meta] update eslint-plugin-react repo URLs 2022-05-03 10:41:03 -07:00
Jordan Harband
7c0f28af8b [eslint config] [deps] update @babel/runtime, eslint-find-rules, eslint-plugin-import, eslint-plugin-react, eslint-plugin-react-hooks, tape 2022-05-03 10:33:40 -07:00
David Petersen
274c8d5701 [eslint config] [patch] set namedComponents option to match style guide
Change the `namedComponents` option to `function-declaration` to match what the style guide requires.

019e0f7e07 (r60060792)
2021-11-10 17:05:21 -06:00
Jordan Harband
1bc8cabd44 [eslint config] [breaking] support eslint 8; drop eslint < 7 2021-11-10 11:31:18 -08:00
Marko Schulz
4ee7326393 [eslint-config-airbnb] [patch] Explain why react/jsx-key is turned off 2021-09-24 11:26:03 +02:00
Jordan Harband
7fbed3b55c [eslint-config-airbnb] [deps] update eslint-plugin-react 2021-09-28 21:44:21 -07:00
Diane Ko
730b749274 [eslint config] [patch] Alphabetize the rules for react-a11y.js
The ordering of the rules are currently not alphabetical, which can make it hard to tell whether there are rules missing or what's set for each rule from eslint-plugin-jsx-a11y.

This change alphabetizes the list so it's easier to compare to the [list of supported rules](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y#supported-rules)
2021-03-24 18:38:08 -07:00
Jordan Harband
4d837646b7 [eslint config] [deps] update eslint-plugin-react 2021-03-24 23:33:38 -07:00
Jordan Harband
db8b6ceb33 [eslint config] update eslint-plugin-react, add new rules, disabled 2020-12-29 21:37:48 -08:00
Jordan Harband
e5de51e55f [eslint config] [patch] re-add jsx-a11y/accessible-emoji, but disabled
See #2322
2020-11-06 14:19:17 -08:00
Kyℓe Hensel
8996aa7c53 [eslint config] [patch] remove deprecated jsx-a11y/accessible-emoji rule 2020-10-27 08:54:41 +13:00
Alex Mercier
05c3bb0018 [eslint config] [patch] Fix ignoreNonDOM typo in jsx-a11y/aria-role rule
This should be `ignoreNonDOM` not `ignoreNonDom` according to [documentation](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-role.md).
2020-10-23 13:30:37 +01:00
alvyn le
d3c7b84d9e [eslint config] [patch] Fixed handle and on ordering in sort-comp rule
- fixes #2116
2020-09-23 01:30:35 -04:00
Jordan Harband
197b50c076 [eslint config] [deps] update eslint-config-airbnb-base, eslint-plugin-jsx-a11y 2020-06-18 11:57:41 -07:00
Severiano Badajoz
c48a060aff [eslint config] [patch] set explicitSpread to ignore for react/jsx-props-no-spreading 2020-06-05 15:09:12 -07:00
Jordan Harband
019e0f7e07 [eslint config] add config for disabled new rules 2020-02-13 17:42:08 -08:00
Alexander Wesolowski
3fb312f181 [eslint config] [patch] Add static-variables to sort-comp rule 2019-10-04 15:57:05 -07:00
Filipp Riabchun
ab72ab9e90 [eslint config] [patch] Remove duplicate componentDidCatch
See https://github.com/airbnb/javascript/pull/2043#discussion_r331208075

I left the one before `cWU`, as in [defaults](https://github.com/airbnb/javascript/pull/2043#discussion_r331208075)
2019-10-03 21:31:32 +02:00
Jordan Harband
530278467f [eslint config] [patch] react/state-in-constructor: fix incorrect configuration 2019-08-13 12:29:28 -07:00
Jordan Harband
1e0a696730 [eslint config] [breaking] disable label-has-for; enable control-has-associated-label 2019-08-09 23:54:08 -07:00
Jordan Harband
73f71d9ba4 [eslint config] [breaking] enable react/jsx-props-no-spreading 2019-08-09 23:53:03 -07:00
Jordan Harband
089022aeff [eslint config] [minor] enable react/static-property-placement 2019-08-09 23:52:44 -07:00
Jordan Harband
7f5a65832d [eslint config] [minor] enable react/state-in-constructor 2019-08-09 23:52:29 -07:00
Jordan Harband
25075b5f72 [eslint config] [minor] enable react/jsx-curly-newline 2019-08-09 23:50:40 -07:00
Jordan Harband
a23f93eb00 [eslint config] [breaking] enable react/jsx-fragments 2019-08-09 23:48:45 -07:00
Jordan Harband
6b5922ca21 [eslint config] [breaking] set react version to "detect"
Fixes #1983.
2019-08-09 22:39:06 -07:00
Felipe Pinheiro
61c7ae6189 [eslint config] Add missing/unsafe lifecycle methods to react/sort-comp rule 2019-06-17 12:58:54 -03:00
Rahil Vora
8c686eac4b [eslint config] add componentDidCatch to lifecycle for react/sort-comp 2019-07-22 11:27:02 -05:00
Waseem Dahman
2160a77baa [eslint config] [breaking] [react] add react-hooks plugin 2019-03-12 23:36:07 -04:00
Jordan Harband
6a50516df7 [eslint config] [meta] add disabled config for new react and a11y rules 2019-07-01 17:07:38 -07:00
Jordan Harband
a71c2d1ad3 [eslint config] add disabled jsx-fragments rule 2019-02-17 14:20:53 -08:00
Jamie
8694a87378 [eslint config] [react] [patch] Turn off react/no-multi-comp
Splitting up a component into multiple components can be useful for many reasons, including making important performance optimizations.

This lint rule discourages splitting up components because it forces you to: create a new file, copy over all the relevant imports, move over any local functions/values (or move them into yet another shared module), export the component (which makes your split off component now a public export), and re-import it into the new module.

Having multiple components per file shouldn't be much different from having multiple functions per file. And you shouldn't be forced to make a component a public export if it's really just an internal implementation detail of another component.

There's an argument to be made about _exporting_ multiple components, but mostly just in the context of React.lazy because it can only import default exports and you don't want something else in that file being statically imported (because that will prevent it from being code-split).
2019-02-14 11:57:20 -08:00
Jordan Harband
25f11fb31e [eslint config] [patch] extend no-underscore-dangle to allow for redux dev tools in the main config instead 2019-01-26 10:12:49 -08:00
Jordan Harband
9a5267684b [eslint config] [patch] re-enabling jsx-one-expression-per-line allowing single children, ignore DOM components on jsx-no-bind; re-enable restructuring-assignment
Reverts b6a268f780
2018-08-13 13:35:23 -07:00
Jordan Harband
b6a268f780 [eslint config] [react] disable two buggy rules, temporarily 2018-07-09 23:16:25 -07:00
Jordan Harband
7dda84a335 [eslint config] [deps] [minor] update jsx-a11y plugin; enable label-has-associated-control rule
This is semver-minor, because the `label-has-associated-control` rule is
the same as the `label-has-for` rule, theoretically. Both remain
enabled, but `label-has-for` will be disabled in the future if this rule
proves out.
2018-07-04 22:33:27 -07:00
Jordan Harband
363bb07765 [eslint config] [deps] update eslint-plugin-react 2018-06-24 22:57:06 -07:00
Jordan Harband
8be089eb11 [eslint config] fix tests 2018-06-21 14:46:24 -07:00
Jordan Harband
951825c6d2 [eslint config] set forbid-foreign-prop-types to "warn" 2018-06-21 14:22:54 -07:00
Gaurav Paliwal
25e711cedd [eslint config] [patch] Add new methods introduced in react@16.3 2018-06-20 17:31:00 +05:30
Jordan Harband
5e260928b6 [eslint config] [react] update eslint-plugin-react 2018-06-03 22:19:41 -07:00
Jimmy Jia
2bd77bc1e0 [eslint config] [base] [patch] label-has-for: Remove redundant component
Also make the rule configuration more explicit.
2018-05-05 22:34:19 -04:00
Jordan Harband
3c3074e502 [eslint config] [*] [deps] update eslint, eslint-find-rules, eslint-plugin-react, tape 2018-02-20 00:10:46 -08:00
Jordan Harband
ff1c12178e [eslint config] [breaking] update eslint-plugin-react to v7.6; update rule configs 2018-01-26 23:31:30 -08:00
Alex Baulch
53b2d7d245 [eslint config] [breaking] bump react pragma to v16; update class-methods-use-this's exceptMethods to include componentDidCatch 2018-01-22 10:42:28 +00:00
Kristóf Poduszló
4817a6b75c [eslint config] [patch] Add 'to' as a specialLink to the 'anchor-is-valid' a11y rule
Support React Router's `<Link to="...">` attribute out of the box.
2017-11-28 19:47:00 +01:00