783 Commits

Author SHA1 Message Date
Jordan Harband
81c58472b6 Fix a bug introduced in f2afce75e9 / #581 2016-01-04 14:33:49 -08:00
Jordan Harband
4cdc3fe483 [eslint config] [breaking] enable quote-props rule. 2015-12-22 09:49:25 -08:00
Gergo Erdosi
8e54961aeb Fix max-len rule definition
The current definition is valid only in eslint@2.x.x, but this package has a dependency on eslint@1.10.3 which doesn't have all those options yet.
2015-12-31 01:39:07 +01:00
Jordan Harband
8c241be003 Merge pull request #637 from evenfrost/master
[eslint config] Permit strict mode in "legacy" config
2015-12-24 08:35:26 -08:00
Christopher Banh
e2e4724fbb Address comments in #639
[eslint] Add comment above `max-len` rule with link to its docs
[eslint] Change tab width for `max-len` rule from 4 to 2
[eslint] Replace double quotes around `max-len` with single quotes
[eslint] Use object form of `max-len` and include all of the options
2015-12-24 02:08:16 -08:00
Christopher Banh
69d3327362 Enable ESLint rule on limiting maxiumum length of line (max-len)
I moved the rule from legacy.js to style.js and enabled it
2015-12-24 02:08:16 -08:00
Aleksey Kislov
c9a9194243 Preserve strict rule for default export 2015-12-24 11:31:33 +03:00
Mordy Tikotzky
f2afce75e9 add default config to all rules which take a config 2015-12-23 21:39:31 -05:00
Mordy Tikotzky
b294e7cbf2 add missing rules from eslint-plugin-react 2015-12-23 21:38:53 -05:00
Jordan Gensler
5c3137d736 Cleaning up the react styleguide. Adding additional info in props. 2015-12-23 14:57:22 -08:00
Jordan Harband
75617bd619 Merge pull request #536 from amsardesai/add-version-badge
[eslint config] [Docs] Add version badge
2015-12-23 12:17:27 -08:00
Aleksey Kislov
76ff913d26 Permit strict mode
Permit strict mode for legacy configuration as it is not intended to be used with Babel.
2015-12-23 17:34:31 +03:00
Jordan Harband
eea8efe551 Merge pull request #635 from lencioni/no-is-mounted
[eslint-config] [breaking] Enable react/no-is-mounted rule
2015-12-22 12:07:04 -08:00
Joe Lencioni
f2dc5043a1 [eslint-config] [minor] Enable react/no-is-mounted rule
isMounted is an anti-pattern [0], is not available when using ES6
classes, and is on its way to being officially deprecated.
eslint-plugin-react recently added the react/no-is-mounted rule in
3.12.0 that prevents its use.

[0]: https://facebook.github.io/react/blog/2015/12/16/ismounted-antipattern.html

Finishes #633
2015-12-22 12:04:03 -08:00
Joe Lencioni
6602586a20 [eslint config] [minor] Sort react/prefer-es6-class alphabetically
All of the other rules in this file are in alphabetical order, but this
one was added by c98990c0f out of order at the end. Keeping these in
alphabetical order will help developers find the rules that they are
looking for.
2015-12-22 11:44:28 -08:00
Jordan Harband
c98990c0f9 [eslint config] [minor] enable react/prefer-es6-class rule 2015-12-22 09:44:26 -08:00
Jordan Harband
c584319df8 [eslint config] [Dev Deps] update eslint-plugin-react 2015-12-22 09:44:07 -08:00
Thomas Shafer
f7971301b0 update examples for style
add link to no-param-reassign rule documentation
2015-12-16 20:21:38 -08:00
Thomas Shafer
2589c67b0c update best-practices config to prevent parameter object manipulation
added good/bad examples of parameter mutation to the readme
2015-12-16 15:43:00 -08:00
Jordan Harband
fcc41eecd7 v2.1.1 2015-12-15 13:07:24 -08:00
Jordan Harband
28476a25d8 [eslint config] add rule link and defaults to jsx-quotes rule 2015-12-15 13:06:28 -08:00
Billy Janitsch
bbcb1371e5 Remove deprecated react/jsx-quotes 2015-12-15 15:59:40 -05:00
Jordan Harband
60b01bdfb9 [eslint config] v2.1.0 2015-12-15 01:22:30 -08:00
Jordan Harband
0fc31eaf1c [eslint config] fix b1500397e1 2015-12-15 01:19:32 -08:00
Jordan Harband
4ab41ede1b [eslint config] [Dev Deps] update eslint 2015-12-14 23:55:21 -08:00
Jake Teton-Landis
a7541c9b22 Merge pull request #582 from jkrems/jk-require-resolve
Use require.resolve to allow nested extend
2015-12-14 23:49:00 -08:00
Jordan Harband
b1500397e1 [eslint config] enable object-shorthand rule.
Fixes #621.
2015-12-14 22:21:52 -08:00
Jordan Gensler
d02a506377 Adding links to react rules for quick reference. 2015-12-11 23:13:30 -08:00
Jordan Gensler
e9b1ef92bf Adding links to lint rules in react styleguide. 2015-12-11 23:00:10 -08:00
Jordan Gensler
d5a636f298 [react] Including missing defaults to the react eslint 2015-12-11 18:47:48 -08:00
Vladimir Kutepov
514bd87d1a Require space before/after arrow function's arrow (arrow-spacing)
Enable [arrow-spacing](http://eslint.org/docs/rules/arrow-spacing.html) rule, code with space before/after arrow function's arrow is easier to read.
```js
() => {};
(a) => {};
a => a;
() => {'\n'};
()=> {};     /*error Missing space before =>*/
() =>{};     /*error Missing space after =>*/
(a)=> {};    /*error Missing space before =>*/
(a) =>{};    /*error Missing space after =>*/
a =>a;       /*error Missing space after =>*/
a=> a;       /*error Missing space before =>*/
()=> {'\n'}; /*error Missing space before =>*/
() =>{'\n'}; /*error Missing space after =>*/
```
2015-12-11 13:50:46 +05:00
Jordan Harband
4c0a70e435 [eslint config] v2.0.0
- separate changelog
2015-12-03 13:55:09 -08:00
Jordan Harband
326100a7b9 Merge pull request #605 from airbnb/ljharb/fix_function_spacing
[breaking] Require function spacing: `function <optional name>(`
2015-12-03 13:33:45 -08:00
Jordan Harband
4ccd04b69a I abhor switch statements, but their indentation should be:
```js
switch (foo) {
  case 'bar':
    break;
}
```

not what the plugin currently requires:
```js
switch (foo) {
case: 'bar':
  break;
}
```
2015-12-03 00:09:12 -08:00
Jordan Harband
599ca4f123 Require a space between function and (, and function and the function's name, and disallow spaces between the function's name and (. 2015-12-02 22:58:11 -08:00
Stefano Pigozzi
6debbcdd73 Add Section 18.11 - Add spaces inside curly braces
Fixes #593
2015-11-28 18:47:46 +01:00
Stefano Pigozzi
ee3759a7ed Add Section 18.10 - No spaces inside brackets
See #593
2015-11-28 13:29:47 +01:00
Stefano Pigozzi
2557a5bca6 Add Section 18.9 - No spaces inside parentheses
See #593
2015-11-28 13:26:37 +01:00
Jake Teton-Landis
e0326137d4 [eslint config] v1.0.2 2015-11-26 15:30:30 -08:00
Ari Porad
e424a249e3 Enable rest params! 2015-11-25 20:48:48 -08:00
Jan Krems
c501e0d5a6 Use require.resolve to allow nested extend 2015-11-16 13:40:38 -08:00
Adrien Vergé
09c8589e44 [eslint] Enforce rule 18.5
Rule 18.5 [1] states that files shall end with a single newline
character. Until now, this was not checked because there was no such
option in eslint.

Since version 1.8.0, eslint provides the ability to do that. See pull
request on eslint [2] for details on implementation and usage. Let's use
it in airbnb eslint plugin now!

[1]: https://github.com/airbnb/javascript#18.5
[2]: https://github.com/eslint/eslint/pull/4266
2015-11-11 10:27:04 -08:00
Joscha Feth
aa6ca6ff68 docs: babel-eslint not neede since 1.0.0 any more 2015-11-09 14:44:17 +11:00
Jordan Harband
d9b5585be4 [eslint config] v1.0.0 2015-11-08 11:12:17 -08:00
Jordan Harband
d432f58655 Add eslint as a peer dep, 1.0 or greater 2015-11-06 16:32:28 -08:00
Jordan Harband
0b7c979d82 [eslint] Remove babel-eslint dependency. 2015-11-06 15:16:49 -08:00
Jordan Harband
88603b8445 [eslint] update eslint, eslint-plugin-react, react, tape. 2015-11-06 13:09:34 -08:00
Jake Teton-Landis
7b0ff1246e eslint-config-airbnb 0.1.1 2015-11-05 15:36:01 -08:00
Jake Teton-Landis
06ed38d57f [eslint] remove id length rule (too much nutrage) 2015-11-05 15:18:59 -08:00
Adrien Vergé
7b834b989c eslint: Fix no-mixed-spaces-and-tabs turn off
Currently the way the rule is defined, mixing spaces and tabulations in
indentation is allowed. However, the comments and documents seems to say
the opposite.

This patchs turns the rule on so mixing spaces and tabs is NOT allowed.

Fixes: #539
2015-10-30 17:00:14 +01:00