github/javascript
1
1
Fork 0
mirror of https://github.com/airbnb/javascript.git synced 2026-01-14 06:48:05 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,953 Commits 5 Branches 102 Tags
temp
Commit Graph

1953 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jordan Harband
77eda9a8e3 Merge pull request #632 from airbnb/ljharb/quote_props 
[eslint config] [breaking] enable `quote-props` rule.
 2016-01-04 13:36:34 -08:00
Jordan Harband
ccc1fab899 Merge pull request #579 from tomekwi/fix-braces-text 
[guide] Bring back note about braces
 2016-01-04 11:38:20 -08:00
Tomek Wiszniewski
4ca5764a30 Require parentheses 
As suggested by @ljharb in https://github.com/airbnb/javascript/pull/579#issuecomment-166981740
 2016-01-04 20:35:42 +01:00
Tomek Wiszniewski
766f3585db Fix typo 2016-01-04 20:35:42 +01:00
Tomek Wiszniewski
b54ce438c8 Clarify 8.4 2016-01-04 20:35:42 +01:00
Tomek Wiszniewski
32ec9dd03a Make 8.2 and 8.4 simpler and more explicit 2016-01-04 20:35:42 +01:00
Tomek Wiszniewski
bc9faf6fec Bring back note about braces 2016-01-04 20:35:42 +01:00
Jordan Harband
619ff1cfd1 Merge pull request #655 from awitherow/master 
[guide] missing 's', create(s) under Method
 2016-01-04 11:03:18 -08:00
Austin Witherow
fd6867d964 missing 's', create(s) under Method 2016-01-04 16:19:24 +01:00
Jordan Harband
7890b6c5d6 Merge pull request #652 from strburst/link-comma-dangle 
[docs] Link newer ESLint rule (no-comma-dangle → comma-dangle)
 2016-01-01 09:16:48 -08:00
Allen Zheng
896783d20c Link newer ESLint rule (namely comma-dangle) 
The "no-comma-dangle" rule was deprecated in favor or "comma-dangle" in
ESLint v1.0.

See http://eslint.org/docs/rules/no-comma-dangle.html,
http://eslint.org/docs/rules/comma-dangle, and line 4 of
packages/eslint-config-airbnb/rules/errors.js.
 2015-12-31 20:23:35 -05:00
Jordan Harband
ceb4195636 Merge pull request #651 from gergoerdosi/max-len 
[Fix] fix max-len rule definition for eslint 1.x
 2015-12-30 17:45:52 -08:00
Gergo Erdosi
8e54961aeb Fix max-len rule definition 
The current definition is valid only in eslint@2.x.x, but this package has a dependency on eslint@1.10.3 which doesn't have all those options yet.
 2015-12-31 01:39:07 +01:00
Jordan Harband
6184703f1c Merge pull request #649 from AlicanC/never-mutate-parameters-link 
[Docs] Add eslint link for "Never mutate parameters." rule
 2015-12-29 15:59:17 -08:00
Alican Çubukçuoğlu
f4b4ff6e1e Add ESLint link for "Never mutate parameters." rule. 2015-12-30 01:54:16 +02:00
Jordan Harband
799085ff41 Merge pull request #647 from AlicanC/cleanup 
[Docs] Cleanup markdown indentation
 2015-12-29 15:47:26 -08:00
Jordan Harband
d97ed42ee4 Merge pull request #648 from yuyokk/patch-1 
[Docs] Add missing back tick
 2015-12-29 15:32:39 -08:00
Iurii Kucherov
bbaaf746db Add missing back tick 2015-12-29 22:54:02 +01:00
Alican Çubukçuoğlu
3869c21182 Fix indentation and spacing. 2015-12-29 19:48:16 +02:00
Jordan Harband
aacaca81c8 Merge pull request #643 from AlicanC/split-never-mutate-parameters 
[Docs] Make no-param-reassign a separate section.
 2015-12-29 09:26:24 -08:00
Alican Çubukçuoğlu
6d9a787ae2 Make reassigning a separate rule. 2015-12-29 19:11:52 +02:00
Jordan Harband
8c241be003 Merge pull request #637 from evenfrost/master 
[eslint config] Permit strict mode in "legacy" config
 2015-12-24 08:35:26 -08:00
Jordan Harband
6d00939747 Merge pull request #639 from chrisngobanh/max-len 
[eslint config] [breaking] Define a max line length of 100 characters
 2015-12-24 08:35:04 -08:00
Christopher Banh
e2e4724fbb Address comments in #639 
[eslint] Add comment above `max-len` rule with link to its docs
[eslint] Change tab width for `max-len` rule from 4 to 2
[eslint] Replace double quotes around `max-len` with single quotes
[eslint] Use object form of `max-len` and include all of the options
 2015-12-24 02:08:16 -08:00
Christopher Banh
f1c249bcd3 Reword section 6.2 to recognize the line length 2015-12-24 02:08:16 -08:00
Christopher Banh
69d3327362 Enable ESLint rule on limiting maxiumum length of line (max-len) 
I moved the rule from legacy.js to style.js and enabled it
 2015-12-24 02:08:16 -08:00
Christopher Banh
d11f2663c5 Update .jshintrc with new line length 2015-12-24 02:08:16 -08:00
Christopher Banh
b7fbc7b6df Add section 18.12 on line length 2015-12-24 02:08:16 -08:00
Aleksey Kislov
c9a9194243 Preserve strict rule for default export 2015-12-24 11:31:33 +03:00
Jordan Harband
fbf81eba3a Merge pull request #581 from tikotzky/update-eslint-react 
[eslint config] [react] add missing rules from eslint-plugin-react (enforcing where necessary)
 2015-12-23 18:56:40 -08:00
Mordy Tikotzky
f2afce75e9 add default config to all rules which take a config 2015-12-23 21:39:31 -05:00
Mordy Tikotzky
b294e7cbf2 add missing rules from eslint-plugin-react 2015-12-23 21:38:53 -05:00
Jordan Harband
fcd1c1d9dc Merge pull request #619 from kesne/jgens/react-cleanup 
[eslint config] [breaking] [react] Minor cleanup for the React styleguide
 2015-12-23 15:04:00 -08:00
Jordan Gensler
e12e5f0480 Removing name prefix rules. 2015-12-23 14:57:22 -08:00
Jordan Gensler
ae69188304 Removing file extensions. Fixing typos. 2015-12-23 14:57:22 -08:00
Jordan Gensler
5c3137d736 Cleaning up the react styleguide. Adding additional info in props. 2015-12-23 14:57:22 -08:00
Jordan Harband
8815205471 Merge pull request #421 from chrisngobanh/jshintrc-fix 
Rename jshintrc to .jshintrc
 2015-12-23 12:52:54 -08:00
Christopher Banh
8989a8a513 Rename jshintrc to .jshintrc 
According to http://jshint.com/docs/, the "special file" to configure JSHint is named `.jshintrc`, not `jshintrc`.
 2015-12-23 12:46:03 -08:00
Jordan Harband
75617bd619 Merge pull request #536 from amsardesai/add-version-badge 
[eslint config] [Docs] Add version badge
 2015-12-23 12:17:27 -08:00
Jordan Harband
4adf9303c2 Merge pull request #576 from evolution-gaming/in-the-wild 
[in the wild] Add Evolution Gaming
 2015-12-23 12:12:07 -08:00
Jordan Harband
1ac8baa97c Merge pull request #636 from lencioni/react-readme-cleanup 
[Docs] React readme cleanup
 2015-12-23 11:44:40 -08:00
Joe Lencioni
474087c426 [readme] Use consistent whitespace in react readme 
I noticed that some newlines and indentation were a little inconsistent
in this file, so I decided to smooth things out a bit. This should help
people who decide to modify this document in the future. When
determining which is the "right" way to format these things, I decided
to use the style used by base readme as a guide.
 2015-12-23 10:12:42 -08:00
Joe Lencioni
a7d3e02a77 [readme] Add missing heading to react TOC 
I noticed that this heading wasn't listed in the table of contents.
Adding it will help people see at-a-glance what they might find in this
document.
 2015-12-23 10:12:42 -08:00
Joe Lencioni
450e64c9d2 [readme] Add backticks around code items in react readme 
I noticed a number of places in this document where code was being
referenced but it was not marked as such. Adding backticks will instruct
the markdown parser to format these bits as code, which should improve
the readability of this document.
 2015-12-23 10:12:42 -08:00
Aleksey Kislov
76ff913d26 Permit strict mode 
Permit strict mode for legacy configuration as it is not intended to be used with Babel.
 2015-12-23 17:34:31 +03:00
Joe Lencioni
055aa14518 [readme] Clean up isMounted section in react readme 
When I added this section in f2dc5043a I didn't do a very good job of
following the style used in other parts of this repo. This commit
remedies that.
 2015-12-22 22:46:25 -08:00
Jordan Harband
eea8efe551 Merge pull request #635 from lencioni/no-is-mounted 
[eslint-config] [breaking] Enable react/no-is-mounted rule
 2015-12-22 12:07:04 -08:00
Joe Lencioni
f2dc5043a1 [eslint-config] [minor] Enable react/no-is-mounted rule 
isMounted is an anti-pattern [0], is not available when using ES6
classes, and is on its way to being officially deprecated.
eslint-plugin-react recently added the react/no-is-mounted rule in
3.12.0 that prevents its use.

[0]: https://facebook.github.io/react/blog/2015/12/16/ismounted-antipattern.html

Finishes #633
 2015-12-22 12:04:03 -08:00
Jordan Harband
0af35c9883 Merge pull request #634 from lencioni/sort-prefer-es6-class 
[eslint config] Sort react/prefer-es6-class alphabetically
 2015-12-22 11:47:34 -08:00
Joe Lencioni
6602586a20 [eslint config] [minor] Sort react/prefer-es6-class alphabetically 
All of the other rules in this file are in alphabetical order, but this
one was added by c98990c0f out of order at the end. Keeping these in
alphabetical order will help developers find the rules that they are
looking for.
 2015-12-22 11:44:28 -08:00