Commit Graph

272 Commits

Author SHA1 Message Date
Harrison Shoff
0ffbdd3692 [comments] fix example 2015-04-29 12:26:14 -07:00
Harrison Shoff
2521d46683 [readme] update additional trailing commas, examples 2015-04-29 11:49:28 -07:00
Harrison Shoff
07bba234a0 [readme] update additional trailing commas, examples 2015-04-29 11:48:52 -07:00
Harrison Shoff
7ade95434c [commas] fix bad git diff example 2015-04-29 10:42:03 -07:00
Harrison Shoff
a2034b0f6c [commas] additional trailing commas good in es6. fixes #323 2015-04-29 10:39:01 -07:00
Harrison Shoff
a41c1fab68 [intro] our es5 guide is still up to date 2015-04-29 10:07:11 -07:00
Josh Perez
cc460132cc Learn you some ES6 2015-04-28 21:31:58 -07:00
Josh Perez
cb47b478c7 Amend grammar for default parameters 2015-04-28 21:28:05 -07:00
Herrington Darkholme
d0028724ea add semicolons 2015-04-28 21:28:05 -07:00
Matias Singers
e5006931f1 Use modules in naming conventions example
Following the rule from further up: "Always use modules (import/export) over a non-standard module system."
2015-04-28 21:28:05 -07:00
Tomek Wiszniewski
0cca5e21fc Fix hoisting examples
Hoisting only happens to `var`. As kangax describes in [Why `typeof` is no longer “safe”](http://es-discourse.com/t/why-typeof-is-no-longer-safe/15/3).

Also, I wonder if we need the whole section, since you recommend to [avoid using `var` altogether](https://github.com/airbnb/javascript/blob/b492/README.md#references).
2015-04-28 21:28:05 -07:00
dsc
ee176044c3 Rename two let keywords to const 2015-04-28 21:28:05 -07:00
Harrison Shoff
f7321b303d [modules] fix invalid syntax in bad example. fixes #287 2015-04-28 21:28:05 -07:00
Harrison Shoff
6d34c516cc [toc] remove extra modules link 2015-04-28 21:28:05 -07:00
Sean Massa
38ae6b6df2 add bad comment to bad section of destructuring 2015-04-28 21:28:05 -07:00
NoNameSheep
e826067498 advice against side effect in default parameter 2015-04-28 21:28:05 -07:00
Luke Westby
bc5b0ee007 Change wording in Iterators and Generators
I found the term "function constructors" to be confusing as the functions the section refers to are not constructors. I think "higher-order functions" or something similar would be more clear.

Thanks!
2015-04-28 21:28:05 -07:00
Josh Perez
22e3c89d04 Removing a few trailing commas 2015-04-28 21:28:05 -07:00
Josh Perez
a6a573e3cc Use more template literals, s/suffer/blessed with 2015-04-28 21:28:04 -07:00
Casey Jenks
b8fd0438fb Iterators and Generators: sum should be 15, not 10 2015-04-28 21:27:44 -07:00
Josh Perez
58cdc731f4 Initial ES6 style guide 2015-04-28 21:27:44 -07:00
Josh Perez
8d0f04c492 Merge pull request #322 from kzsh/clarifying-enforced-rule
Clarifying what rule is being enforced.
2015-04-27 17:43:30 -07:00
Andrew
a6e906a1b9 Clarifying what rule is being enforced.
Capitalization of constructors is not the rule in question here.  It makes it more clear what the offending difference is between `//bad` and `//good` to have consistent constructor capitalization.
2015-04-27 20:18:32 -04:00
Josh Perez
1282ee63df Add comment on why we're breaking a rule 2015-04-27 16:39:57 -07:00
Maxim
a1b53a1d85 Added new organization. 2015-04-23 15:25:49 +03:00
Jensen
17dde0d593 Remove excess whitespace in Whitespace section 2015-04-20 16:17:48 -07:00
Harrison Shoff
7fe4883a75 [variables] fix variable hoisting example. fixes #265 2015-04-19 15:42:15 -07:00
robertmargelli
5fe373c646 Added italian translation 2015-04-17 15:13:59 -07:00
nagits
64013fb578 Add Flexberry to the organizations list 2015-04-17 18:28:05 +05:00
Varayut Lerdkanlayanawat
67dda213b8 Add Thai language version 2015-04-16 10:12:06 +07:00
Harrison Shoff
d5cddf836c Merge pull request #292 from sunshinewyin/master
Fix minor punctuation errors in README
2015-04-08 10:52:36 -07:00
Harrison Shoff
540365c4cc [whitespace] class => classed. fixes #294 2015-04-06 18:00:36 -07:00
Josh Perez
0501155c5e Merge pull request #283 from marcioos/master
Rephrasing Array#push style guide
2015-04-05 21:05:51 -07:00
Josh Perez
7ed9511a2f Merge pull request #288 from RKushnir/master
Fix a typo in selector
2015-04-05 21:05:41 -07:00
Jan Hořava
999a9f3dc5 Alphabetized Translation links 2015-04-05 14:51:18 -07:00
Sunshine Yin
6cda67e2f5 Fix minor punctuation errors
(1) BEFORE: Never name a parameter `arguments`, this will take precedence over the `arguments` object.
AFTER: Never name a parameter `arguments`. This will take precedence over the `arguments` object.

(2) BEFORE: Variable declarations get hoisted to the top of their scope, their assignment does not.
AFTER:
Variable declarations get hoisted to the top of their scope, but their assignment does not.

(3) BEFORE: for multiline comments
AFTER: for multi-line comments

(4)BEFORE: It’s okay to write a custom toString() method, just make sure
AFTER: It's okay to write a custom toString() method. Just make sure
2015-04-05 12:57:01 -07:00
Roman
ebe8cb253d Fix a typo in selector 2015-04-04 11:47:48 +03:00
Marcio Oliveira
4b012cddf3 Rephrasing Array#push style guide 2015-04-03 19:51:16 -03:00
Josh Perez
483bc27a7c Merge pull request #277 from adult-swim/airbnb
Added Adult Swim to In the Wild section
2015-04-02 12:46:31 -07:00
Justin Gardner
2bccaf6203 Added Adult Swim to In the Wild section 2015-04-02 20:40:40 +01:00
Harrison Shoff
615dc76f63 [whitespace] remove dots, they look bad 2015-04-02 09:13:38 -07:00
Harrison Shoff
369fdb8f56 [whitespace] add dots for whitespace examples 2015-04-02 09:12:33 -07:00
Tomek Wiszniewski
2e51880f10 Specify whitespace rules for parentheses
Based on existing examples and <http://sideeffect.kr/popularconvention/#javascript>.
2015-04-02 04:10:21 +02:00
Harrison Shoff
520b6d658f [resources] add link to standard style by @feross 2015-03-30 13:07:29 -07:00
Christoph Jasinski
b91deedf22 Add You Don't Know JS to books 2015-03-30 00:41:28 +02:00
marcel-me
716a9658af Add Eloquent JavaScript to books 2015-03-27 22:02:39 +01:00
Joe Frambach
3dc4b5edc8 String concat code blocks were not equivalent.
If the array is empty, the "bad" code will return `<ul></ul>` and the "good" code will return `<ul><li></li></ul>`.

Although I would prefer this over the for loop:

    function inbox(messages) {
      items = messages.map(function(message) {
        return '<li>' + message.message + '</li>';
      });

      return '<ul>' + items.join('') + '</ul>';
2015-03-27 10:40:15 -07:00
Veikko Karsikko
78309e7ddb Add Nordic Venture Family to organizations list 2015-03-26 10:22:35 +02:00
Harrison Shoff
18abccb651 Merge pull request #238 from jigsawye/patch-1
Update README.md
2015-03-21 11:22:05 -07:00
Harrison Shoff
114f03539b Merge pull request #250 from vprasanth/master
Added a book to book list and created Podcasts section
2015-03-21 11:19:39 -07:00