Commit Graph

447 Commits

Author SHA1 Message Date
chief10
607ad012ee change wording for 8.2 for consistency 2016-03-01 15:28:10 -06:00
Boris Besemer
7684892951 fixes tiny typo's on JSCS rules 2016-02-25 09:12:52 +01:00
David Bows
30c448d1df Updated "In The Wild" to include Brainshark. 2016-02-23 12:54:20 -08:00
Felix Sanz
714f71d1d2 Added getter/setter info
I tried to search for getter/setter in the readme but nothing was found. Added some info to make a clear statement about them
2016-02-23 01:25:02 +01:00
NakShi
db8b07f51a Fixed README typo 2016-02-22 15:39:53 -08:00
Cihan Bebek
50ff33de88 Small typo fix in 18.6 'bad'-example.
Function call 'class()' to 'classed()'.
2016-02-21 21:38:33 +02:00
Jordan Harband
8a6f00968d Fix no-useless-constructor example.
Per https://github.com/airbnb/javascript/pull/730#discussion_r53565774
2016-02-21 10:28:54 -08:00
Harrison Shoff
3983d380ed [eslint-v2][arrays] fix example 2016-02-20 23:39:29 -08:00
Harrison Shoff
b79e951280 [eslint-v2][arrays] update array-callback-return good/bad ex 2016-02-20 23:33:39 -08:00
Harrison Shoff
e0959d0f1d [eslint-v2] fix rule links in readme 2016-02-14 19:04:12 -08:00
Harrison Shoff
65609373bf [eslint-v2][template strings] add template-curly-spacing rule, fix #716 2016-02-14 18:56:49 -08:00
Harrison Shoff
1f12a12be4 [eslint-v2] fix empty constructor example 2016-02-14 18:48:31 -08:00
Harrison Shoff
e1a087fbb1 [eslint-v2] add prefer-rest-params 2016-02-14 18:45:44 -08:00
Harrison Shoff
e6cbcf4cc5 [eslint-v2][whitespace] add no-whitespace-before-property rule 2016-02-14 18:35:23 -08:00
Harrison Shoff
ba10353e9b [eslint-v2][arrow functions] improve examples 2016-02-14 14:50:49 -08:00
Harrison Shoff
6a03a32915 [eslint-v2][arrow functions] add no-confusing-arrow rule 2016-02-14 14:47:23 -08:00
Harrison Shoff
172dffbb52 [eslint-v2][whitespace] add newline-per-chained-call rule 2016-02-14 11:48:04 -08:00
Harrison Shoff
fbd9c35dd3 [eslint-v2][arrays] add array-callback-return rule 2016-02-14 11:14:38 -08:00
Harrison Shoff
91b83650b0 [eslint-v2][constructors] fix bad + good examples 2016-02-14 02:34:47 -08:00
Harrison Shoff
1cbc628c49 [eslint-v2][constructors] disallow unnecessary constructors 2016-02-13 13:57:38 -08:00
Ray Sinlao
24e7fd0c14 Added parenthesis to 'good' example in 8.2 2016-02-04 00:00:58 -08:00
Jordan Harband
7e15ccf4cb [eslint config] [breaking] disallow unneeded ternary expressions. 2016-02-03 17:25:00 -08:00
Joe Lencioni
4d74fe1f5a Add example of a case clause that does not need a block
As @kesne and @ljharb pointed out, this section was unclear about
whether or not you should always include blocks for all case clauses. To
make things clearer, I am adding a case clause that does not need a
block to the good example.

We decided that we should only require blocks for case clauses that
actually need them because it matches the as-needed spirit of section
3.8 ("Only quote properties that are invalid identifiers"). Perhaps if
there was an as-needed but consistent setting for the ESLint rule, we
would consider revising this a little, but this seems good enough for
now.
2016-02-03 12:23:51 -08:00
Joe Lencioni
38d9b34b27 Avoid lexical declarations in case/default clauses
This commit adds guidance warning people to avoid lexical declarations
in case/default clauses and enables the corresponding ESLint rule.

  http://eslint.org/docs/rules/no-case-declarations.html

We didn't have a section on switch statements yet, so I thought about
starting one. It seemed like it would best fit between section 15
(Comparison Operators & Equality) and section 16 (Blocks), but I didn't
want to mess up all of the following numberings, since people probably
have references to them. I considered adding this near the end to
minimize this effect, but it really seemed to belong near these other
things. I landed on appending it to Section 15 (Comparison Operators &
Equality) and I think it sorta fits there since switch statements are a
related concept.
2016-02-02 16:11:53 -08:00
Jordan Harband
206e13b185 [guide] remove trailing whitespace 2016-02-02 10:33:18 -08:00
Barry Gitarts
d293e74872 add section 15.5 - Ternaries
add link to the relevant eslint rule
2016-02-02 13:11:55 -05:00
Prayag Verma
7eb7b78513 Minor typo
Remove extra dot
2016-01-30 10:42:33 +05:30
Mark Sanghoon Kim
51510a43c8 Fixed capitalization and comment spacing
Fixed line 1219 to have a lowercase 'a' to be consistent with the style guide.
Fixed line 1831 to only have one space between the // and the =>
2016-01-27 23:14:53 -08:00
Fredrik Olovsson
784d029980 Edit sample code in 24.1 to follow rule 8.1
Replaced function expression with arrow function notation.
2016-01-27 11:53:57 +01:00
LarryBattle
79a6bfa101 Added names to invalid function declarations 2016-01-26 23:53:51 -06:00
Ethan Rubio
760e50704c Fixed capitalization
Fixed capitalization of ES6 to match the rest of the README.
2016-01-26 15:09:05 -08:00
Harrison Shoff
7293a0f02d [rule links] add labels back 2016-01-25 22:34:39 -08:00
Harrison Shoff
2c06d87d86 [rule links] reduce visual clutter 2016-01-25 21:46:23 -08:00
Daniel Russell
02e1b4e395 Fixed capitalization
Bitshift changed to bitshift
2016-01-24 20:52:24 -08:00
David Sorrentino
2c9833fbc2 add WeBox Studio to the organizations list 2016-01-22 11:45:56 +01:00
Rick Yeh
fb3c4cac20 Fixed minor capitalization change in Hoisting
Not sure if it's an actual fix, but just noticed this was the only comment that had capitalization that wasn't a proper noun
2016-01-21 22:54:27 -08:00
Brett Jurgens
36765e4d88 add avant to users 2016-01-20 15:13:31 -06:00
Jordan Harband
fb65b9ae04 [guide] fix a few IIFE examples 2016-01-19 10:15:36 -08:00
Svein Halvor Halvorsen
018dd6e359 arrow-parens 2016-01-19 13:07:37 +01:00
Jordan Harband
586b7d9dfa [docs] remove trailing whitespace 2016-01-17 18:10:42 -08:00
Henry Zhu
56ea6c7351 remove specific rule values in text 2016-01-16 22:27:41 -05:00
Henry Zhu
2bd22f0475 Document corresponding jscs rules 2016-01-16 21:46:35 -05:00
Prayag Verma
a4845a82cf Update license year range to 2016 2016-01-16 17:33:50 +05:30
Jordan Harband
4ef335e242 [eslint config] [breaking] require outer IIFE wrapping; flesh out guide section.
There was lots of discussion [here](https://github.com/airbnb/javascript/issues/21#issuecomment-10203921), but now that we have both a modern build system and an eslint rule requiring terminating semicolons, the concerns with the “crockford” style no longer apply.
2016-01-10 15:11:05 -08:00
Peter Geiss
9498b3f7c4 Clearly show that [] is truthy 2016-01-13 23:12:06 -05:00
Eddie Monge
397f5bbd14 assign variables: give a reason for the assignment
The variable assignment wasn't necessary. This gives a reason to have it there
2016-01-13 14:19:14 -08:00
Simon Olofsson
90e6cd1c98 22.3: Add Link to eslint rule. 2016-01-13 17:45:43 +01:00
Simon Olofsson
59a0bccd92 7.3: Add Link to eslint rule. 2016-01-13 12:25:32 +01:00
Jordan Harband
7f62252e7f [guide] clarify function spacing in 18.3
Per #668.
2016-01-07 22:15:46 -08:00
Matija Marohnić
557b4dacd7 Link to the eslint rule for radix in parseInt 2016-01-07 00:19:06 +01:00