github/javascript
1
1
Fork 0
mirror of https://github.com/airbnb/javascript.git synced 2026-01-14 03:28:02 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,075 Commits 5 Branches 102 Tags
b3a02ae982140ff0a386d87465bc85462eab4e85
Commit Graph

277 Commits

Author SHA1 Message Date
Jordan Harband
b3a02ae982 [eslint config] [breaking] [base] update eslint to v3 
- drop support for node 4.
 2016-07-02 08:54:05 -07:00
Joe Lencioni
d282e059b1 Add import/no-restricted-paths to imports rules 
This rule was added by 1.10.0. I am setting it to be disabled because it
is very project-specific, so it doesn't make sense to enable it here.

https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-restricted-paths.md

I found the sections of this file a little confusing, so I didn't know
where to put it. I think it would be better to simply alphabetize the
rules but I'll leave that for another time.
 2016-07-05 10:04:28 -07:00
Jordan Harband
82629f126d [eslint config] [base] [Deps] update eslint-plugin-import, tape, eslint-find-rules 2016-07-02 08:53:21 -07:00
Jordan Harband
b45fdcd60f [eslint config] [base] add some import plugin settings 2016-07-05 10:35:40 -07:00
Jordan Harband
1f87054e4b [eslint config] [base] [patch] newline-per-chained-call: bump the limit to 4. 
Specifically, this is to allow this frequent pattern:
```js
$.ajax({
  …
}).done(() => {
  …
}).fail(() => {
  …
}).always(() => {
  …
});
```
 2016-07-05 10:35:40 -07:00
Jordan Harband
9028379f87 [eslint config] [base] [breaking] re-disable import/extensions rule 
ref https://github.com/benmosher/eslint-plugin-import/issues/390
 2016-07-05 10:35:40 -07:00
Kevin Grandon
36d1561596 Prevent using string refs. 
According to the official React documentation string refs are considered legacy and will be deprecated in the future.
 2016-06-28 10:13:36 -07:00
Jordan Harband
a597da56ca [eslint config] [base] [breaking] enable rest-spread-spacing rule 2016-06-20 17:59:03 -07:00
Jordan Harband
d0973e8e36 [eslint config] [base] add TODO for object-curly-newline. 
ref https://github.com/eslint/eslint/issues/6488
 2016-06-20 17:58:36 -07:00
Jordan Harband
622a3bc1ab [eslint config] [base] [breaking] re-disable newline-after-import 
Per https://github.com/benmosher/eslint-plugin-import/issues/386
 2016-06-20 16:11:24 -07:00
Jordan Harband
51f9b0450c [eslint config] [base] [breaking] enable import rules: newline-after-import, prefer-default-export 2016-06-20 15:53:26 -07:00
Jordan Harband
ee2cb41ec4 [eslint config] [base] [breaking] enable no-mixed-operators rule. 
Specifically, this is to require parens to avoid cognitive overhead about precedence.
 2016-06-20 15:52:05 -07:00
Jordan Harband
6980cce17f [eslint config] [base] [breaking] enable import rules: 
- `no-named-as-default`
 - `no-named-as-default-member`
 - `no-extraneous-dependencies`
 - `extensions`
 2016-06-20 14:32:19 -07:00
Jordan Harband
5651e607f3 [eslint config] [base] [breaking] enable object-property-newline rule 2016-06-20 14:31:26 -07:00
Jordan Harband
001efc722c [eslint config] [base] update eslint 2016-06-20 13:34:03 -07:00
Jordan Harband
0afde8f136 [eslint config] [base] [deps] update eslint 2016-06-17 16:03:03 -07:00
Jordan Harband
0814be638f [eslint config] [base] [deps] update eslint, eslint-find-rules 
Adds disabled rules: `max-lines`, `no-mixed-operators`, `rest-spread-spacing`, `object-curly-newline`
 2016-06-16 22:44:35 -07:00
Jordan Harband
f41b4df024 [eslint config] [base] [breaking] enable no-prototype-builtins rule. 2016-06-04 18:14:02 -07:00
Jordan Harband
4700d99864 [eslint config] [base] [breaking] enable no-useless-rename rule 2016-06-04 18:00:02 -07:00
Jordan Harband
d9cb343b51 [eslint config] [base] [breaking] enable unicode-bom rule 2016-06-04 17:58:25 -07:00
Jordan Harband
ab4baf457e [eslint config] [base] [deps] update eslint, eslint-plugin-import 2016-06-04 17:41:41 -07:00
Jordan Harband
89cfa0b81c [eslint config] [*] use in-publish because coffeescript screwed up the prepublish script for everyone 2016-06-04 17:38:41 -07:00
Jordan Harband
eb76edea32 [eslint config] [*] [tests] Only run eslint-find-rules on prepublish, not in tests. 2016-06-04 17:30:00 -07:00
Simen Bekkhus
d97d62a2ff Fix react dev dep version 2016-06-01 10:04:07 +02:00
Jordan Harband
b6e4b72fc2 [eslint config] [*] [deps] update eslint, eslint-plugin-jsx-a11y. ensure react is >= 13.0.0 2016-05-21 22:11:20 +02:00
Jordan Harband
429339ee37 [eslint config] [*] fix quoting of rule properties. 
Per #885.
 2016-05-18 20:00:04 -07:00
Jordan Harband
8e125fa07c [eslint config] [base] [breaking] Enforce proper generator star spacing. 
Fixes #887.
 2016-05-17 21:27:10 -07:00
Jordan Harband
312cd01a95 [eslint config] [base] quotes: Use object option form rather than deprecated string form. 
Per https://github.com/airbnb/javascript/pull/886
 2016-05-17 13:50:12 -07:00
Joe Lencioni
43ccc3fe11 Enable imports/imports-first rule 
Since imports are hoisted, keeping them all at the top prevents
surprising behavior.
 2016-05-17 09:14:48 -07:00
akai
34ccf905d6 [eslint config] [base] [breaking] migrate import's settings/rules to a separate file. 2016-05-17 01:10:00 +08:00
akai
3948eb66d6 [eslint config] [base] [breaking] re-order rules 2016-05-17 00:25:48 +08:00
Jordan Harband
10f4dd88aa [eslint config] [base] [patch] object-shorthand: do not warn when the concise form would have a string literal as a name. 2016-05-15 21:43:40 -05:00
Jordan Harband
7a8083795d [eslint config] [base] [patch] Loosen prefer-const to not warn when the variable is “read” before being assigned to. 2016-05-15 21:42:45 -05:00
Jordan Harband
8d6d227848 [eslint config] [*] [tests] Even though the base config may not be up to date in the main package, let’s npm link the base package into the main one for the sake of travis-ci tests. 
(Followup from c7faa91328)
 2016-05-15 20:56:54 -05:00
Jordan Harband
638b312b6c [eslint config] [base] update eslint 2016-05-15 21:14:59 -05:00
Joe Lencioni
4ac8aed126 Prepare to enable react-a11y rules 
When I first added these, I left TODO notes to come back and evaluate
enabling them. I've gone through and think that we should definitely at
least enable the rules that enforce basic spec compliance (e.g. that
props don't have typos and that all of the required props are provided
for the given role). Since these deal with basic correctness, I don't
think we need to add any verbiage to the style guide for these rules.

We still have some more that we should evaluate and decide about
enabling here, but this is a good step in the right direction.
 2016-05-13 11:25:44 -07:00
Jordan Harband
788fb2297a [eslint config] [*] [deps] update eslint-plugin-import 2016-05-12 17:28:57 -05:00
Joe Lencioni
d68a067f2b Prepare to enable import/prefer-default-export 
This was recently added to eslint-plugin-export. It enforces that
modules that only have a single export use a default export instead of a
named export. Since this is a breaking change and we want to cluster
breaking changes, I marked it as 0 for now with a TODO to enable when
that time comes.
 2016-05-12 15:21:07 -07:00
Joe Lencioni
5acae06653 Add whitespace between rules 
I found these rules all smashed together with comments a little
difficult to mentally parse, partly because it is ambiguous which line
the comment applies to. Separating with some whitespace helps a lot
here, and will also reduce the likelihood of merge conflicts in this
code.
 2016-05-12 11:43:53 -07:00
Jordan Harband
db732788e7 [eslint config] [react] [patch] loosen jsx-pascal-case rule to allow all caps component names 2016-05-09 15:41:52 -07:00
Jordan Harband
d25a199c56 [eslint config] [deps] update eslint-config-airbnb-base, eslint-plugin-react 2016-05-09 15:40:46 -07:00
Jordan Harband
03c5a1f955 [eslint config] v9.0.1 2016-05-08 14:57:25 -07:00
Jordan Harband
d95dc3d500 [eslint config] [base] v3.0.1 2016-05-08 14:55:42 -07:00
Jordan Harband
56a524a47e [eslint config] [base] [patch] re-disable no-extra-parens 
Fixes #869, #867.
 2016-05-08 14:53:24 -07:00
Jordan Harband
330169d15e [eslint config] v9.0.0 2016-05-07 10:39:47 -07:00
Jordan Harband
8b396ab9ef [eslint config] [deps] Update eslint-config-airbnb-base, eslint-plugin-jsx-a11y, eslint-plugin-import, eslint-find-rules 2016-05-07 10:33:05 -07:00
Jordan Harband
1b31efc07e [eslint config] [base] v3.0.0 2016-05-06 18:04:54 -07:00
Jordan Harband
92a3d5570b [eslint config] [base] [breaking] enable import/no-mutable-exports 2016-05-06 17:44:59 -07:00
Jordan Harband
36e088759f [eslint config] [base] [patch] enable import/no-duplicates 2016-05-06 17:40:57 -07:00
Jordan Harband
b20cf1966c [eslint config] [base] [minor] enable import/no-amd 
(per https://github.com/airbnb/javascript#modules--use-them )
 2016-05-06 17:40:20 -07:00