github/javascript
1
1
Fork 0
mirror of https://github.com/airbnb/javascript.git synced 2026-04-25 03:00:19 -04:00
Code Issues Packages Projects Releases Wiki Activity
1,140 Commits 5 Branches 102 Tags
e92eaef4e2aefc7bbd3576dc28e7d0c52ba63c7d
Commit Graph

509 Commits

Author SHA1 Message Date
Gerardo Renovales
e92eaef4e2 Update README.md 
Add M2GEN to the list
 2016-08-17 19:46:55 -04:00
Maxim
646fa70f59 Update README.md 2016-08-08 11:14:05 +03:00
felipethome
31265099af [guide] Simplify the examples of 'apply vs spread' topic 2016-08-05 18:38:35 -03:00
felipethome
c7d34b526a [guide] Add a topic about spread operator vs apply 2016-08-05 11:52:41 -03:00
felipethome
030598db09 [guide] Add ESlint rules to 'always use const' and 'decriptive variable names' topics 2016-08-04 14:13:12 -03:00
Joe Lencioni
dc7e7e77f2 Reverse rule on string concatenation for long lines (#995) 
Broken and concatenated long strings are painful to work with and
produce less readable and searchable code. I think we should reverse
this rule.

Unfortunately, the max-len rule currently does not allow for this, but
there is currently a proposal to add an option to ESLint's max-len rule
that would allow for strings to be ignored.

  https://github.com/eslint/eslint/issues/5805

There have also been discussions around performance of string
concatenation (https://github.com/airbnb/javascript/issues/40), but I
don't think that is very relevant here so I removed the links to them.
 2016-08-04 09:53:09 -07:00
Joe Lencioni
6d2fc89bd1 Add template literal "bad" example to single quotes guideline 
There has been some confusion around whether we should use single quotes
or template literals. To help avoid this confusion, I am adding a "bad"
example to the single quotes guideline. This rule is already enforced by
the quotes linter rule.

Generally, we want code to clearly express developer intention. Using
template literals communicates that you intend to use some of the
features that template literals offer (e.g. interpolation).

Fixes #992
 2016-08-04 09:38:12 -07:00
Joe Lencioni
bfc842e3ad Remove rules about reserved words 
In 53b4173b we removed the ES5 guide which contains a lot of guidelines
that are no longer very relevant for us. Similarly, some folks have
raised the relevance of these rules about reserved words, given that we
are now living in an age where ES3 support has mostly waned and
transpilers such as Babel are widely adopted and pave over these issues.
This seems like a good opportunity to simplify.

Fixes #61
 2016-08-03 14:41:16 -07:00
felipethome
f0b31960d3 [guide] Add eslint rules to function declaration and function constructor topics 2016-08-03 16:20:22 -03:00
felipethome
f94f6e21c6 [guide] Add eslint rule to spacing in a function signature topic 
[guide] Add eslint rules to spacing in a function signature topic
 2016-08-02 20:49:54 -03:00
Jordan Harband
6454839e76 [guide] Use var in reserved word examples, since they refer to untranspiled code. 2016-08-01 23:56:37 -07:00
Jordan Harband
53b4173b04 [guide] [es5] Remove ES5 guide and mark it deprecated. 
Fixes #941.
 2016-07-06 18:13:13 -07:00
Jordan Harband
a9bfee01cd [guide] Add link to eol-last rule. 
Fixes #945.
 2016-07-09 09:10:50 -07:00
Luke Libraro
3ad2404974 Added link to Mozilla documentation on Function.bind 2016-07-07 15:46:40 -05:00
Cédric Malard
7fb8b03714 Document for-in restricted usage 
https://github.com/airbnb/javascript/issues/851#issuecomment-213834028
 2016-07-06 17:00:42 +02:00
Shreevatsa
34a9f076df Minor typo: "coxcomb graph" v/s "coxcomb chart" 
The "bad" and "good" diffs in section 19.2 had different text; making them the same to avoid confusion about what the difference is.
 2016-06-23 10:58:12 -07:00
Jordan Harband
28a04a3a45 [docs] Clear up “confusing arrows” example. 
Closes #856.
 2016-06-21 22:41:03 -07:00
Michael Clawar
04138345ad Update README.md 2016-06-19 15:47:02 -04:00
Andrzej Duś
defa17e872 Added Syzygy Warsaw 2016-06-15 11:25:19 +02:00
Caleb
90f5a47c33 Updated deprecated Japanese translation link. 
old: https://github.com/mitsuruog/javacript-style-guide
new: https://github.com/mitsuruog/javascript-style-guide
 2016-06-13 19:15:19 +10:00
Jordan Harband
f41b4df024 [eslint config] [base] [breaking] enable no-prototype-builtins rule. 2016-06-04 18:14:02 -07:00
Wesley
3fb9db5a74 fixing broken link 
Google moved their style guides to Github (from an SVN server), and this link was broken
 2016-06-04 15:17:00 -07:00
Ross Kirsling
267eec57c6 Fix invalid code snippet in 23.2. 2016-06-02 10:24:30 -07:00
mifi
1db5522888 Fix typo 
disallowSpacesInsideObjectBrackets -> requireSpacesInsideObjectBrackets
 2016-05-26 22:54:27 +02:00
Sergii Tkachenko
199a0a700d Add DoSomething.org to the list of organizations in README 2016-05-25 17:49:40 +03:00
Jordan Harband
8e125fa07c [eslint config] [base] [breaking] Enforce proper generator star spacing. 
Fixes #887.
 2016-05-17 21:27:10 -07:00
Joe Lencioni
43ccc3fe11 Enable imports/imports-first rule 
Since imports are hoisted, keeping them all at the top prevents
surprising behavior.
 2016-05-17 09:14:48 -07:00
Joe Lencioni
d68a067f2b Prepare to enable import/prefer-default-export 
This was recently added to eslint-plugin-export. It enforces that
modules that only have a single export use a default export instead of a
named export. Since this is a breaking change and we want to cluster
breaking changes, I marked it as 0 for now with a TODO to enable when
that time comes.
 2016-05-12 15:21:07 -07:00
Felipe Vargas
b660d4cc3f Add semicolon in arrow functions section 2016-05-08 18:15:41 -04:00
Jordan Harband
be5c90a417 [docs] Array.from, not Array#from 2016-05-08 14:54:14 -07:00
Alejandro Oviedo
ba5d9f0cd7 add links to resources on mdn 2016-05-08 11:33:58 -03:00
Jordan Harband
92a3d5570b [eslint config] [base] [breaking] enable import/no-mutable-exports 2016-05-06 17:44:59 -07:00
Jimmy Jia
f9089d075a Add 4Catalyzer to users 2016-05-04 19:31:04 -04:00
Oliver THEBAULT
a71bffa5e3 Fix README "4.5" bad reduce example 2016-04-24 19:48:45 +02:00
alexpausan
2d81a2db4a Started using AirBnB style guide. 2016-04-21 10:23:12 +03:00
Oskar Cieslik
897732f6f0 Add arrow function returning object. 2016-04-20 10:39:06 +02:00
Victor Brouk
763416260a [guide] fix broken deep link to 'testing--yup' 2016-04-19 15:46:29 -07:00
Jordan Harband
52d3401f95 [eslint config] [eslint config base] [breaking] Migrate non-React rules to a separate linter config. 2016-04-16 11:04:28 -07:00
Jordan Harband
fc1443b80f [guide] add link on perf of array iteration methods 2016-04-16 09:54:28 -07:00
Jordan Harband
688ef3c2eb [guide] remove AIIFE to avoid CallExpression quirk. 
Fixes #828.
 2016-04-15 19:24:48 -07:00
Jordan Harband
56e6815a84 [guide] Attempt to clarify filename conventions 
Fixes #817.
 2016-04-13 22:37:46 -07:00
Jordan Harband
92a66ccc7c [guide] [breaking] Disallow leading underscores - there’s no such thing as “private properties”. 
Per https://github.com/airbnb/javascript/issues/490#issuecomment-209126331
 2016-04-12 15:27:09 -07:00
Brett Sanders
f5d6e9646c [guide] Update eslint rule for keyword-spacing, small fix for consistency 2016-04-07 14:02:11 -07:00
Kevin Moot
6e770062bb Adding The Nerdery to the "In the Wild" section 2016-04-04 19:07:35 -05:00
Peter Kuiper
a2bdbb83d1 Add KickorStick to 'In the Wild' 2016-04-04 14:20:17 +02:00
Amin
f21412cba9 Broken link to Classes and constructors 2016-04-04 11:39:47 +04:00
Jordan Harband
76e1e4c1de [eslint config] [breaking] Add no-dupe-class-members rule + section. 
Closes #785.
 2016-04-02 18:08:27 -07:00
Yarun Luon
5ec8765a28 Add Chartboost to 'In the Wild' 2016-03-31 18:17:26 -07:00
Saad Quadri
9415b88afd Add missing description for 7.2 2016-03-30 03:27:55 -04:00
Jordan Harband
81241b83cf [eslint config] [breaking] add no-useless-escape rule. 2016-03-26 23:11:23 -07:00