github/javascript
1
1
Fork 0
mirror of https://github.com/airbnb/javascript.git synced 2026-01-14 05:58:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,590 Commits 5 Branches 102 Tags
ea14bda1101abc2971c86b663fa7eed6bd4e6be8
Commit Graph

679 Commits

Author SHA1 Message Date
Song Xie
a7a7cab504 [guide] Add an anchor for rule 13.7 2018-02-21 14:44:58 -08:00
Rauno Freiberg
901fd85b7c Use single quotes for consistency 2018-02-19 14:58:24 +02:00
Jordan Harband
cfe10c17d3 fix linting error in guide 2018-02-08 21:45:14 -08:00
Kevin Ji
4c870cbd40 [guide] Fix function signature spacing 2018-02-08 11:29:44 -08:00
Gil Birman
c8b1164105 control-statement--value-selection 2 2018-02-08 13:07:34 -08:00
Ajay Poshak
16190d8cb5 Note added for translation 2018-02-04 18:52:51 +05:30
Teddy Katz
c5411a42d2 Suggest using WeakMaps when hidden properties are needed 
This updates the "trailing or leading underscores" guideline to suggest an better way to make properties hidden, as an alternative to just removing the underscore and making the property public.
 2018-02-04 17:11:01 -05:00
ParkSB
aefff97bd1 Update Korean translation link 2018-01-30 11:49:24 +09:00
David Clark
9a3e6356cf Added GreenChef organization to README 2018-01-28 00:38:48 -07:00
Jérémie Astori
fc99aefc4c [guide] Use acc as reduce accumulator instead of memo to make it valid 
In [this part of the `no-param-reassign` configuration](53b2d7d245/packages/eslint-config-airbnb-base/rules/best-practices.js (L174-L175)), `acc` is allowed to be mutated (rule [7.12](https://github.com/airbnb/javascript#functions--mutate-params), but `memo` is not.

This causes the [rule 4.6 example](https://github.com/airbnb/javascript#arrays--callback-return) in the README to actually be invalid.
 2018-01-26 13:16:39 -05:00
Sharmila
e9fff7adbf [eslint config] [base] [breaking] Prevent line breaks before and after = 2018-01-26 10:57:21 -08:00
zwei
c4dcfd93a7 [guide] fix indentation in section 4.7 2018-01-16 16:20:46 +08:00
Ben Fortner
262b07b106 fix example to meet standard listingId v listingID 
fixed code example to meet the standard. `listingId` changed to `listingID` 
See - Naming Conventions: Acronyms and initialisms should always be all capitalized, or all lowercased.
 2018-01-16 09:55:54 -05:00
Jordan Harband
be647a77fb Merge pull request #1538 from lanceli/patch-1 
Change Simplified Chinese translation link
 2018-01-09 22:32:15 -08:00
Sharmila
fe3a2de6b5 [fixes: #1678] Improves wording of no-mixed-operators recommendation. 2018-01-08 14:37:32 -08:00
Miguel Piedrafita
cb9482c04e [guide] Update license year 2018-01-01 00:50:59 +01:00
Jordan Harband
f9fcb37af1 [guide] Add link to "has" package 
Fixes #1670.
 2017-12-25 10:37:36 -08:00
Jordan Harband
0991476c9f [guide] Clarify that vars are hoisted to function scope, not block scope 
Fixes #1675.
 2017-12-25 10:27:33 -08:00
Jordan Harband
1b6bcd0e0f [guide] more precisely refer to an "object literal" instead of just a "hash" 
Fixes #1680.
 2017-12-25 10:24:54 -08:00
Thomas Broadley
8a12ffed19 [guide] Fix spelling error in link 
(preserve old link for back-compat)
 2017-12-15 20:31:09 -05:00
Ilici
255b0f369a Fix third example in Enclosed operators section 2017-12-14 23:14:27 +01:00
Josh Bourgeois
8cf2c70a41 [guide] Add explanation for semicolon enforcement rule 
Also update code samples to highlight ways in which ES6
currently mishandles code when relying on Automatic Semicolon
Insertion

Revise hyperlink and example

- Use more up-to-date TC39 reference page on github.io
- wrap returnless function with side-effects in curly braces

also, clean up punctuation on a long comment line

Always use single-quoted strings

Except for when the string needs to be double-quoted because the string contains apostrophes

Update second example to incorporate IIFE

An IIFE is a more realistic example of code that developers may encounter which would raise an exception when relying completely upon ASI
 2017-10-04 13:38:13 -07:00
Ed Morley
7ff6303513 [guide] Use HTTPS for links to ESLint documentation 
The result of a `s_http://eslint\.org_https://eslint\.org_g`.
Avoids the HTTP 302s of the non-HTTPs URLs.
 2017-10-30 13:19:22 +00:00
Jordan Harband
2d4343acd1 [guide] remove/update outdated links. 
Fixes #1626.
 2017-10-27 22:10:32 -07:00
Vse Mozhet Byt
c40d0d1f84 [guide] Fix a link, add an anchor 2017-10-28 03:41:29 +03:00
Pirasis Leelatanon
dbdf8ea0ef [doc] add eslint rule reference for no-multi-assign 2017-10-26 02:21:23 +07:00
Pirasis Leelatanon
327795bf3c [doc] add eslint rule reference for no-new-wrappers 2017-10-26 02:36:13 +07:00
Sharmila
2676cbfb2f [eslint config] [base] [breaking] Enables nonblock-statement-body-position rule and adds link to guide 2017-10-24 17:49:14 -07:00
Leonid Lebedev
ecf8e077a7 Remove unnecessary variables 2017-10-24 14:33:47 +03:00
Arnav
bd3ba6edfe Add symbol as a primitive type 
- Also add note that symbols cannot by polyfilled and should not be used in environments that don't support them
 2017-10-23 15:04:58 -07:00
Vse Mozhet Byt
dbd69346bd [guide] Fix a numeration typo in README.md 
- also remove legacy numbered link
 2017-10-24 00:07:05 +03:00
Sharmila
8161f32f1f [eslint config] [base] [breaking] no-mixed-operators: only warn on ** and % mixed with arithmetic operators; removes violation against mixing common math operators. 
Fixes #1071.
 2017-10-20 16:09:16 -07:00
Liu Chong
97a6883621 Fix markdown style breaking 
It came from the special characters "M-BM-":

```
diff README.md README.md.new | cat -A
651c651$
<     const foo = function uniqueMoreDescriptiveLexicalFoo() {$
---$
>  M-BM-  M-BM- const short = function longUniqueMoreDescriptiveLexicalFoo() {$
```
 2017-10-22 14:10:35 +08:00
刘冲
232b719fc5 To Clarify the func-style description 
As "foo" is still meaningless, but with "short", we can see that, we are intend to use a short alias name to make our coding happily.
 2017-10-21 22:11:18 +08:00
jabacchetta
3c6d40ccca [docs] Clarify reasoning for named function expressions 
For convenience, added brief explanations that are given in the linked discussion (mostly eliminating the need to scroll through the comments).
 2017-10-19 19:46:28 -05:00
jabacchetta
39cf84f43b [guide] Add clarification to arrow functions 
Clarify and correct explanation — to be consistent with section 7.1 (use named function expressions).
 2017-10-19 18:59:41 -05:00
Sharmila
67e34433e4 Adds guide section for no-return-else 2017-10-18 21:30:02 -07:00
Sharmila
2b3c86d812 Fixes indentation 2017-10-18 14:50:58 -07:00
Sharmila
cd4ec29ed3 [eslint config] [base] Enables eslint rule for operator-linebreak 
Requiring operators at the beginning of the line makes code more readable. When operators are on the left hand side they mirror the syntax of method chaining and it is easy to see the build of logic in a statement. This also updates the readme and fixes a style violation as a result of adding this rule in eslint-config-airbnb/test/test-base.js and eslint-config-airbnb-base/test/test-base.js.
 2017-10-18 14:15:39 -07:00
Sharmila
f2a65c6898 Improves 'Why?' message 2017-10-18 13:41:24 -07:00
Sharmila
2ab0e61858 Updates Control Statements section to reflect eslint config change 2017-10-18 13:37:49 -07:00
Pirasis Leelatanon
9025c52a73 [doc] add eslint rule reference for prefer-destructuring 2017-10-16 21:18:48 +07:00
David Künnen
ac2ed5a749 Added our company to "In The Wild" 2017-10-12 13:30:18 +02:00
Leonid Lebedev
faedb67042 Add Amendments 2017-10-01 17:36:45 +03:00
Josh
2380c0ddb8 [guide] Improve severity of warning comment 2017-09-27 12:51:40 -07:00
Vladimir Kovpak
3ad1ad1a6a [guide] Updated example in ternaries. 2017-09-21 02:11:14 +03:00
Nikita Lebedev
e16b03b841 [guide] require array spread operator or Array.from 
Fixes #1084.
 2017-09-20 14:12:25 -07:00
Carlos Soria
0aab14c364 Add Grupo Abraxas to In The Wild section 2017-09-14 16:09:30 -05:00
Jordan Harband
5b338e1937 [Tests] lint our markdown 2017-09-02 11:33:45 -07:00
Jordan Harband
9dee84796b [Docs] add note about requiring babel-preset-airbnb and airbnb-browser-shims. 
Fixes #1544.
 2017-09-02 11:28:53 -07:00