github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-04-20 03:01:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #13571. jQuery.isPlainObject 1.9.x compatibility

Browse Source 
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
This commit is contained in:
Rick Waldron
2013-03-06 14:42:24 -05:00
parent 49abe3dc92
commit 8d1c42296f
2 changed files with 49 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
test/unit/core.js
View File

@@ -296,9 +296,9 @@ test("type", function() {
});
asyncTest("isPlainObject", function() {
expect(15);
expect(16);
var pass, iframe, doc,
var pass, iframe, doc, c, extended,
fn = function() {};
// The use case that we want to match
@@ -360,6 +360,45 @@ asyncTest("isPlainObject", function() {
} catch(e) {
window.iframeDone( Object, "iframes not supported" );
}
// #13571
function C() {}
C.prototype = {
x: 1
};
c = new C();
extended = jQuery.extend( true, {}, {
target: c
});
strictEqual(
extended.target, c,
"Instances, whose constructor defined its prototype by assigning a plain object, " +
"will lie about their true identity to preserve a broken user-code expectation"
);
//
// The test above is broken and tests a broken feature, to support a misinformed
// assumption, as documented here:
//
// http://bugs.jquery.com/ticket/13571#comment:4
//
// It will not pass if the object being assigned as the prototype
// has no properties:
//
// function C() {}
// C.prototype = {};
// c = new C();
// extended = jQuery.extend( true, {}, {
// target: c
// });
// strictEqual( extended.target, c, "Undetectable, will fail every time" );
//
// The solution is to reset the constructor property of your plain object prototypes.
//
//
});
test("isFunction", function() {