github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-04-20 03:01:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

Offset: add tests for hidden elements + scroll

Browse Source 
- Also add comments to hidden/disconnected tests noting
  this is to ensure consistency between branches
This commit is contained in:
Timmy Willison
2015-06-16 13:24:12 -04:00
parent 3b1de11267
commit a0a5c0be2d
3 changed files with 28 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/unit/offset.js
View File

@@ -53,6 +53,9 @@ test("disconnected element", function() {
var result = jQuery( document.createElement( "div" ) ).offset();
// These tests are solely for master/compat consistency
// Retrieving offset on disconnected/hidden elements is not officially
// valid input, but will return zeros for back-compat
equal( result.top, 0, "Retrieving offset on disconnected elements returns zeros (gh-2310)" );
equal( result.left, 0, "Retrieving offset on disconnected elements returns zeros (gh-2310)" );
});
@@ -65,6 +68,9 @@ test("hidden (display: none) element", function() {
node.remove();
// These tests are solely for master/compat consistency
// Retrieving offset on disconnected/hidden elements is not officially
// valid input, but will return zeros for back-compat
equal( result.top, 0, "Retrieving offset on hidden elements returns zeros (gh-2310)" );
equal( result.left, 0, "Retrieving offset on hidden elements returns zeros (gh-2310)" );
});
@@ -406,7 +412,7 @@ testIframe("offset/table", "table", function( $ ) {
});
testIframe("offset/scroll", "scroll", function( $, win ) {
expect(28);
expect( 30 );
// If we're going to bastardize the tests, let's just DO it
var ie = /msie 8/i.test( navigator.userAgent );
@@ -425,6 +431,12 @@ testIframe("offset/scroll", "scroll", function( $, win ) {
}
equal( $("#scroll-1-1").offset().left, 11, "jQuery('#scroll-1-1').offset().left" );
// These tests are solely for master/compat consistency
// Retrieving offset on disconnected/hidden elements is not officially
// valid input, but will return zeros for back-compat
equal( $("#hidden").offset().top, 0, "Hidden elements do not subtract scroll" );
equal( $("#hidden").offset().left, 0, "Hidden elements do not subtract scroll" );
// scroll offset tests .scrollTop/Left
equal( $("#scroll-1").scrollTop(), 5, "jQuery('#scroll-1').scrollTop()" );
equal( $("#scroll-1").scrollLeft(), 5, "jQuery('#scroll-1').scrollLeft()" );