github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-01-31 16:07:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Attributes: Avoid infinite recursion on non-lowercase attribute getters

Browse Source 
Attribute hooks are determined for the lowercase versions of attribute names
but this has not been reflected in the bool attribute hooks. The code that
temporarily removed a handler to avoid an infinite loop was removing an
incorrect handler causing stack overflow.

Fixes gh-3133
Refs gh-2914
Refs gh-2916
Closes gh-3134
This commit is contained in:
Michał Gołębiowski
2016-05-29 22:24:28 +02:00
parent 5430c540df
commit e06fda69f0
2 changed files with 26 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/attributes/attr.js
View File

@@ -117,16 +117,18 @@ jQuery.each( jQuery.expr.match.bool.source.match( /\w+/g ), function( i, name )
var getter = attrHandle[ name ] || jQuery.find.attr;
attrHandle[ name ] = function( elem, name, isXML ) {
var ret, handle;
var ret, handle,
lowercaseName = name.toLowerCase();
if ( !isXML ) {
// Avoid an infinite loop by temporarily removing this function from the getter
handle = attrHandle[ name ];
attrHandle[ name ] = ret;
handle = attrHandle[ lowercaseName ];
attrHandle[ lowercaseName ] = ret;
ret = getter( elem, name, isXML ) != null ?
name.toLowerCase() :
lowercaseName :
null;
attrHandle[ name ] = handle;
attrHandle[ lowercaseName ] = handle;
}
return ret;
};