github/jquery
1
1
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2026-02-01 09:44:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

Core: Simplify isPlainObject

Browse Source 
Fixes gh-2986
Close gh-2998
This commit is contained in:
Richard Gibson
2016-03-14 16:46:51 -04:00
committed by Timmy Willison
parent 10fc59007d
commit e0d3bfa770
5 changed files with 37 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/unit/core.js
View File

@@ -287,7 +287,7 @@ QUnit.test( "type for `Symbol`", function( assert ) {
QUnit.asyncTest( "isPlainObject", function( assert ) {
assert.expect( 22 );
assert.expect( 23 );
var pass, iframe, doc, parentObj, childObj, deep,
fn = function() {};
@@ -300,12 +300,13 @@ QUnit.asyncTest( "isPlainObject", function( assert ) {
assert.ok( jQuery.isPlainObject( { constructor: "foo" } ),
"plain object with primitive constructor property" );
parentObj = { foo: "bar" };
parentObj = {};
childObj = Object.create( parentObj );
assert.ok( !jQuery.isPlainObject( childObj ), "isPlainObject(Object.create({}))" );
assert.ok( !jQuery.isPlainObject( childObj ), "Object.create({})" );
parentObj.foo = "bar";
assert.ok( !jQuery.isPlainObject( childObj ), "Object.create({...})" );
childObj.bar = "foo";
assert.ok( !jQuery.isPlainObject( childObj ), "isPlainObject(Object.create({}))" );
assert.ok( !jQuery.isPlainObject( childObj ), "extend(Object.create({...}), ...)" );
// Not objects shouldn't be matched
assert.ok( !jQuery.isPlainObject( "" ), "string" );