From 8f1c35a8149c2e95fafd5b1675f0253b70b8608b Mon Sep 17 00:00:00 2001
From: jurcovicovam <meri@meri.org>
Date: Fri, 23 Jan 2015 17:48:26 +0100
Subject: [PATCH 1/2] Extend looses @supports imported by reference

New logic: directive with body that contains something referenced (for
example by extend) will be shown in output too. @Media works with the same
logic - it shows up in output if it contains something visible.

Related to: #2359
---
 lib/less/tree/directive.js             |  3 ++
 lib/less/tree/ruleset.js               | 39 +++++++++++++++++++++++---
 lib/less/visitors/to-css-visitor.js    | 37 ++++++++++++++++++++++--
 test/css/import-reference.css          |  8 ++++++
 test/less/import-reference.less        |  2 +-
 test/less/import/import-reference.less | 16 ++++++++++-
 6 files changed, 96 insertions(+), 9 deletions(-)

diff --git a/lib/less/tree/directive.js b/lib/less/tree/directive.js
index e189128d..5a22abca 100644
--- a/lib/less/tree/directive.js
+++ b/lib/less/tree/directive.js
@@ -73,6 +73,9 @@ Directive.prototype.markReferenced = function () {
         }
     }
 };
+Directive.prototype.getIsReferenced = function () {
+    return !this.currentFileInfo || !this.currentFileInfo.reference || this.isReferenced;
+};
 Directive.prototype.outputRuleset = function (context, output, rules) {
     var ruleCnt = rules.length, i;
     context.tabLevel = (context.tabLevel | 0) + 1;
diff --git a/lib/less/tree/ruleset.js b/lib/less/tree/ruleset.js
index aa86214d..ce3cb541 100644
--- a/lib/less/tree/ruleset.js
+++ b/lib/less/tree/ruleset.js
@@ -414,13 +414,44 @@ Ruleset.prototype.genCSS = function (context, output) {
     }
 };
 Ruleset.prototype.markReferenced = function () {
-    if (!this.selectors) {
-        return;
+    var s;
+    if (this.selectors) {
+        for (s = 0; s < this.selectors.length; s++) {
+            this.selectors[s].markReferenced();
+        }
     }
-    for (var s = 0; s < this.selectors.length; s++) {
-        this.selectors[s].markReferenced();
+
+    if (this.rules) {
+        for (s = 0; s < this.rules.length; s++) {
+            if (this.rules[s].markReferenced)
+                this.rules[s].markReferenced();
+        }
     }
 };
+Ruleset.prototype.getIsReferenced = function() {
+    var i, j, path, selector;
+
+    if (this.paths) {
+        for (i=0; i<this.paths.length; i++) {
+            path = this.paths[i];
+            for (j=0; j<path.length; j++) {
+                if (path[j].getIsReferenced && path[j].getIsReferenced())
+                    return true;
+            }
+        }
+    }
+
+    if (this.selectors) {
+        for (i=0;i<this.selectors.length;i++) {
+            selector = this.selectors[i];
+            if (selector.getIsReferenced && selector.getIsReferenced())
+                return true;
+        }
+    }
+    return false;
+};
+
+
 Ruleset.prototype.joinSelectors = function (paths, context, selectors) {
     for (var s = 0; s < selectors.length; s++) {
         this.joinSelector(paths, context, selectors[s]);
diff --git a/lib/less/visitors/to-css-visitor.js b/lib/less/visitors/to-css-visitor.js
index 3e26f886..93cb6d63 100644
--- a/lib/less/visitors/to-css-visitor.js
+++ b/lib/less/visitors/to-css-visitor.js
@@ -46,10 +46,10 @@ ToCSSVisitor.prototype = {
     },
 
     visitDirective: function(directiveNode, visitArgs) {
-        if (directiveNode.currentFileInfo.reference && !directiveNode.isReferenced) {
-            return;
-        }
         if (directiveNode.name === "@charset") {
+            if (!directiveNode.getIsReferenced()) {
+                return;
+            }
             // Only output the debug info together with subsequent @charset definitions
             // a comment (or @media statement) before the actual @charset directive would
             // be considered illegal css as it has to be on the first line
@@ -65,6 +65,37 @@ ToCSSVisitor.prototype = {
         }
         if (directiveNode.rules && directiveNode.rules.rules) {
             this._mergeRules(directiveNode.rules.rules);
+            //process childs
+            directiveNode.accept(this._visitor);
+            visitArgs.visitDeeper = false;
+
+            // the directive was directly referenced and therefore needs to be shown in the output
+            if (directiveNode.getIsReferenced()) {
+                return directiveNode;
+            }
+
+            if (!directiveNode.rules.rules) {
+                return ;
+            }
+
+            //the directive was not directly referenced
+            for (var r = 0; r<directiveNode.rules.rules.length; r++) {
+                var rule = directiveNode.rules.rules[r];
+                if (rule.getIsReferenced && rule.getIsReferenced()) {
+                    //the directive contains something that was referenced (likely by extend)
+                    //therefore it needs to be shown in output too
+
+                    //marking as referenced in case the directive is stored inside another directive
+                    directiveNode.markReferenced();
+                    return directiveNode;
+                }
+            }
+            //The directive was not directly referenced and does not contain anything that
+            //was referenced. Therefore it must not be shown in output.
+            return ;
+        } else {
+            if (!directiveNode.getIsReferenced())
+                return;
         }
         return directiveNode;
     },
diff --git a/test/css/import-reference.css b/test/css/import-reference.css
index f25f4b1d..4dc5490b 100644
--- a/test/css/import-reference.css
+++ b/test/css/import-reference.css
@@ -34,6 +34,14 @@ div#id.class[a=1][b=2].class:not(1) {
 .visible + .visible .sub {
   color: green;
 }
+@supports (something: else) {
+  .class {
+    something: else;
+  }
+  .nestedToo .class {
+    something: else;
+  }
+}
 .b {
   color: red;
   color: green;
diff --git a/test/less/import-reference.less b/test/less/import-reference.less
index 93160ab5..e1477c50 100644
--- a/test/less/import-reference.less
+++ b/test/less/import-reference.less
@@ -18,4 +18,4 @@
 }
 
 .class:extend(.class all) {
-}
\ No newline at end of file
+}
diff --git a/test/less/import/import-reference.less b/test/less/import/import-reference.less
index c77f692e..f8f96425 100644
--- a/test/less/import/import-reference.less
+++ b/test/less/import/import-reference.less
@@ -48,4 +48,18 @@
   @media (max-size: @max-size) {
     color: red;
   }
-}
\ No newline at end of file
+}
+
+@supports (something: else) {
+  .class {
+    something: else;
+  }
+  .nestedToo {
+    .class {
+      something: else;
+    }
+  }
+  .invisible {
+    something: else;
+  }
+}

From dc2b6851947952d37fe6affd7950893242adbf60 Mon Sep 17 00:00:00 2001
From: jurcovicovam <meri@meri.org>
Date: Fri, 23 Jan 2015 18:42:02 +0100
Subject: [PATCH 2/2] Added unit test for referenced parent selectors

Name: Parent selectors not working within mixins using (reference)
Number: #1979
---
 test/css/import-reference.css          |  6 ++++++
 test/less/import-reference.less        |  1 +
 test/less/import/import-reference.less | 11 ++++++++++-
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/test/css/import-reference.css b/test/css/import-reference.css
index 4dc5490b..0d06c2bf 100644
--- a/test/css/import-reference.css
+++ b/test/css/import-reference.css
@@ -74,3 +74,9 @@ div#id.class[a=1][b=2].class:not(1) {
     color: red;
   }
 }
+.test {
+  color: red;
+}
+.test:first-child {
+  color: blue;
+}
diff --git a/test/less/import-reference.less b/test/less/import-reference.less
index e1477c50..77df43ba 100644
--- a/test/less/import-reference.less
+++ b/test/less/import-reference.less
@@ -19,3 +19,4 @@
 
 .class:extend(.class all) {
 }
+.mixin-with-nested-selectors();
\ No newline at end of file
diff --git a/test/less/import/import-reference.less b/test/less/import/import-reference.less
index f8f96425..f4c9c74d 100644
--- a/test/less/import/import-reference.less
+++ b/test/less/import/import-reference.less
@@ -49,7 +49,7 @@
     color: red;
   }
 }
-
+//https://github.com/less/less.js/issues/2359
 @supports (something: else) {
   .class {
     something: else;
@@ -63,3 +63,12 @@
     something: else;
   }
 }
+//https://github.com/less/less.js/issues/1979
+.mixin-with-nested-selectors() {
+  .test {
+    color: red;
+    &:first-child {
+      color: blue;
+    }
+  }
+}
\ No newline at end of file