From e3a78458ad64abdc16dd33c04a798cd3243b3102 Mon Sep 17 00:00:00 2001 From: Mohammad Samman Date: Fri, 6 Dec 2013 00:41:25 -0800 Subject: [PATCH] FIXES ISSUE #1453: let ModifyVar change numerical variables --- lib/less/browser.js | 2 +- test/browser/css/modify-vars/simple.css | 1 + test/browser/less/modify-vars/simple.less | 2 ++ test/browser/runner-modify-vars-spec.js | 3 ++- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/less/browser.js b/lib/less/browser.js index beeb82c0..3ab8ab05 100644 --- a/lib/less/browser.js +++ b/lib/less/browser.js @@ -600,7 +600,7 @@ function serializeVars(vars) { for (var name in vars) { s += ((name.slice(0,1) === '@')? '' : '@') + name +': '+ - ((vars[name].slice(-1) === ';')? vars[name] : vars[name] +';'); + ((vars[name].toString().slice(-1) === ';')? vars[name] : vars[name] +';'); } return s; diff --git a/test/browser/css/modify-vars/simple.css b/test/browser/css/modify-vars/simple.css index 4cb81bac..889cd53d 100644 --- a/test/browser/css/modify-vars/simple.css +++ b/test/browser/css/modify-vars/simple.css @@ -4,4 +4,5 @@ .test { color1: #008000; color2: #800080; + scalar: 20; } diff --git a/test/browser/less/modify-vars/simple.less b/test/browser/less/modify-vars/simple.less index 64d99302..ad998c5b 100644 --- a/test/browser/less/modify-vars/simple.less +++ b/test/browser/less/modify-vars/simple.less @@ -1,6 +1,8 @@ @import "imports/simple2"; @var1: red; +@scale: 10; .test { color1: @var1; color2: @var2; + scalar: @scale } \ No newline at end of file diff --git a/test/browser/runner-modify-vars-spec.js b/test/browser/runner-modify-vars-spec.js index 25ea5b68..0ce49986 100644 --- a/test/browser/runner-modify-vars-spec.js +++ b/test/browser/runner-modify-vars-spec.js @@ -20,7 +20,8 @@ describe("less.js modify vars", function() { lessOutputObj.type = "not compiled yet"; less.modifyVars({ var1: "green", - var2: "purple" + var2: "purple", + scale: 20 }); });